New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639871 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1.8%-2.4% regression in media.android.tough_video_cases at 413115:413147

Project Member Reported by chcunningham@google.com, Aug 22 2016

Issue description

Slight increase in vm_shared_dirty_delta
 
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Aug 22 2016

Cc: junov@chromium.org
Owner: junov@chromium.org

=== Auto-CCing suspected CL author junov@chromium.org ===

Hi junov@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Stop using GrTexture::get/setCustomData in Canvas2DLayerBridge
Author  : junov
Commit description:
  
Canvas2DLayerBridge was using custom data to cache mailbox names
associated with recycled textures managed by skia.  This helped
prevent leaking mailboxes.  This CL uses a different approach
that consists in disassociating mailboxes to prevent the mailbox
leak.  The goal is to allow the skia team to proceed with the
deprecation of texture custom data attachments.

BUG= 632722 

Review-Url: https://codereview.chromium.org/2262533002
Cr-Commit-Position: refs/heads/master@{#413129}
Commit  : 645b3cc4697033ab68738dc68d9dfd8db200c008
Date    : Fri Aug 19 14:02:25 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@413120  2558.33  10.9848  6  good
chromium@413125  2558.0   6.63325  5  good
chromium@413127  2563.6   10.139   5  good
chromium@413128  2560.8   11.3666  5  good
chromium@413129  2635.6   4.3359   5  bad    <--
chromium@413137  2635.2   8.89944  5  bad

Bisect job ran on: android_nexus5_perf_bisect
Bug ID: 639871

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests media.android.tough_video_cases
Test Metric: vm_shared_dirty_delta/crowd1080_vp9.webm_renderer
Relative Change: 2.86%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5_perf_bisect/builds/4029
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9003611806551898880


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5841066465427456

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 23 2016

Labels: Hotlist-Google

Comment 5 by junov@chromium.org, Oct 7 2016

Status: WontFix (was: Assigned)
This small regression is acceptable IMHO

Sign in to add a comment