New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639861 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

views::Widget still get mouse events when InitParams::accept_events is false in mus+ash

Project Member Reported by penghuang@chromium.org, Aug 22 2016

Issue description

views::Widget still get mouse events when InitParams::accept_events is false in mus+ash
 
https://codereview.chromium.org/2264503003/diff/1/components/exo/pointer.cc#newcode133

In this CL, the views::Widget for cursor spirit is created with accept_events = false, but it can still get mouse event sometimes.

Cc: reve...@chromium.org

Comment 3 by sadrul@chromium.org, Aug 22 2016

What sort of events do you receive? Enter/Exit? Or other types too?
Looks like, the ui::Window is created for views::Widget first, and then it will be initialized with InitParams. So the mouse events could be queued in mojo message pipe before views::Widget initialization.

All ET_MOUSE_* events have been observed.
Labels: Proj-Mustash-Mus
Owner: penghuang@chromium.org
Status: Assigned (was: Available)

Comment 8 by sadrul@chromium.org, Aug 24 2016

re #4: can you clarify why events are queued before the ui::Window is made visible?
https://cs.chromium.org/chromium/src/ui/views/mus/native_widget_mus.cc?rcl=0&l=716

From the code, the ui::Window could be visible before NativeWidgetMus::InitNativeWidget being called. In that case, the mouse events will be queued in MessagePipe, right? 
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d62216cfe1b73e2fa7c5384b3d8fb1dc03f794bb

commit d62216cfe1b73e2fa7c5384b3d8fb1dc03f794bb
Author: penghuang <penghuang@chromium.org>
Date: Thu Aug 25 22:44:00 2016

ui/views: Pass InitParams::accept_events to NativeWidgetMus::content_

BUG= 639861 

Review-Url: https://codereview.chromium.org/2272753002
Cr-Commit-Position: refs/heads/master@{#414565}

[modify] https://crrev.com/d62216cfe1b73e2fa7c5384b3d8fb1dc03f794bb/ui/views/mus/native_widget_mus.cc

Status: Fixed (was: Assigned)

Sign in to add a comment