New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 639852 link

Starred by 19 users
Status: Fixed
Owner:
altimin@chromium.org
Closed: Mar 2017
Cc:
klo...@chromium.org
█ kbr@chromium.org
qin...@chromium.org
snanda@chromium.org
█ jdduke@chromium.org
tedc...@chromium.org
█ nyquist@chromium.org
█ alberto@chromium.org
skyos...@chromium.org
█ ejcaruso@chromium.org
altimin@chromium.org
█ bccheng@chromium.org
█ alexclarke@chromium.org
ojan@chromium.org
█ rsch...@chromium.org
dbasehore@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 653865
issue 671814
issue 690375
issue 690929
Blocking:
issue 687833
issue 693054
issue 530437
issue 650594


Show other hotlists

Hotlists containing this issue:
Interventions


Sign in to add a comment

Implement time-based renderer task queues throttling

Project Member Reported by altimin@chromium.org, Aug 22 2016 
Add APIs to throttle renderer task queues based on CPU budgets.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ab9c0bc90a06439f5c2173b8a2ba3448d3b819a

commit 3ab9c0bc90a06439f5c2173b8a2ba3448d3b819a
Author: altimin <altimin@chromium.org>
Date: Tue Aug 23 17:57:12 2016

[scheduler] Monitor renderer main thread load level.

Add monitoring of main thread load level for background and foreground renderers.

BUG= 639852 

Review-Url: https://codereview.chromium.org/2265873004
Cr-Commit-Position: refs/heads/master@{#413783}

[modify] https://crrev.com/3ab9c0bc90a06439f5c2173b8a2ba3448d3b819a/third_party/WebKit/Source/platform/blink_platform.gypi
[add] https://crrev.com/3ab9c0bc90a06439f5c2173b8a2ba3448d3b819a/third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker.cc
[add] https://crrev.com/3ab9c0bc90a06439f5c2173b8a2ba3448d3b819a/third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker.h
[add] https://crrev.com/3ab9c0bc90a06439f5c2173b8a2ba3448d3b819a/third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker_unittest.cc
[modify] https://crrev.com/3ab9c0bc90a06439f5c2173b8a2ba3448d3b819a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/3ab9c0bc90a06439f5c2173b8a2ba3448d3b819a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
[modify] https://crrev.com/3ab9c0bc90a06439f5c2173b8a2ba3448d3b819a/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b437716023a23fc12ad9fff36c88de8034d8e796

commit b437716023a23fc12ad9fff36c88de8034d8e796
Author: altimin <altimin@chromium.org>
Date: Wed Aug 24 12:58:21 2016

[scheduler] Fix trace counter for renderer main thread load.

Convert load level from fraction value from [0, 1] range to 0-100% percentage for using as trace counter.

R=alexclarke@chromium.org, skyostil@chromium.org

BUG= 639852 

Review-Url: https://codereview.chromium.org/2278503002
Cr-Commit-Position: refs/heads/master@{#414057}

[modify] https://crrev.com/b437716023a23fc12ad9fff36c88de8034d8e796/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Comment 3 by skyos...@chromium.org, Sep 2 2016

Blocking: 530437

Comment 4 by dbasehore@chromium.org, Sep 6 2016 

What is the status and ETA of this feature?

Comment 5 by altimin@chromium.org, Sep 6 2016 

dbasehore@: prototype done, design doc done, implementing API now, hoping to ship intervention in M54.

Comment 6 by ojan@chromium.org, Sep 6 2016 

I think you mean M55 since M54 has already branched. :)

Comment 7 by altimin@chromium.org, Sep 7 2016 

Ooops, sorry, got things mixed up, thanks for pointing this out.
Yes, M55.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/906d4a1e806b27681bad0ec63f64c0c9fc239a77

commit 906d4a1e806b27681bad0ec63f64c0c9fc239a77
Author: altimin <altimin@chromium.org>
Date: Sat Sep 24 13:21:35 2016

[scheduler] Implement time-based cpu throttling.

This patch adds TimeBudgetPool API to renderer scheduler, which allows to group task queues into pools and set shared limits on how long this pool of queues is allowed to run (as per cent of wall time). Queues violating this limit will be throttled.

This patch also renames throttling_helper.cc to task_queue_throttler.cc.

BUG= 639852 

Review-Url: https://codereview.chromium.org/2258133002
Cr-Commit-Position: refs/heads/master@{#420842}

[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.cpp
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgent.h
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/core/inspector/InspectorWebPerfAgentTest.cpp
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/DEPS
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.cc
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/base/task_queue_impl.h
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/base/test_task_time_observer.h
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/base/time_domain.cc
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/base/time_domain.h
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/child/compositor_worker_scheduler.cc
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/child/scheduler_helper.h
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.h
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
[add] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[add] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
[add] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.cc
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/renderer/throttled_time_domain.h
[delete] https://crrev.com/e33bb1d7cd562d93467a55c0aff7d95769343f8f/third_party/WebKit/Source/platform/scheduler/renderer/throttling_helper.h
[delete] https://crrev.com/e33bb1d7cd562d93467a55c0aff7d95769343f8f/third_party/WebKit/Source/platform/scheduler/renderer/throttling_helper_unittest.cc
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/public/platform/scheduler/DEPS
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/public/platform/scheduler/base/task_queue.h
[modify] https://crrev.com/906d4a1e806b27681bad0ec63f64c0c9fc239a77/third_party/WebKit/public/platform/scheduler/base/task_time_observer.h

Comment 9 by skyos...@chromium.org, Sep 27 2016

Cc: klo...@chromium.org nyquist@chromium.org kbr@chromium.org tedc...@chromium.org qin...@chromium.org jdduke@chromium.org
 Issue 486135  has been merged into this issue.

Comment 10 by dbasehore@chromium.org, Sep 29 2016 

Is there anymore work that needs to be done for this?

Comment 11 by altimin@chromium.org, Sep 29 2016 

dbasehore@: There is a patch in review to add a flag to about://flags and actually start throttling: https://crrev.com/2345483002
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e25269603f52b2f26ab6db689f730af15a2607da

commit e25269603f52b2f26ab6db689f730af15a2607da
Author: altimin <altimin@chromium.org>
Date: Wed Oct 05 15:53:00 2016

[scheduler] Throttle background frames with 1% CPU limit

BUG= 639852 

Review-Url: https://codereview.chromium.org/2345483002
Cr-Commit-Position: refs/heads/master@{#423170}

[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/chrome/app/generated_resources.grd
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/chrome/browser/about_flags.cc
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/content/child/runtime_features.cc
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/content/public/common/content_features.cc
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/content/public/common/content_features.h
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/public/web/WebRuntimeFeatures.h
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/tools/metrics/histograms/histograms.xml
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88ca6a85e43bdc1944e6383981d645fed3db7509

commit 88ca6a85e43bdc1944e6383981d645fed3db7509
Author: penghuang <penghuang@chromium.org>
Date: Wed Oct 05 18:03:08 2016

Revert "[scheduler] Throttle background frames with 1% CPU limit"

This reverts commit e25269603f52b2f26ab6db689f730af15a2607da.

Revert this CL because content_browsertests failed on ubuntu-12.04.

See log:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/34119

TBR=jochen@chromium.org

# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 639852 

Review-Url: https://codereview.chromium.org/2393193003
Cr-Commit-Position: refs/heads/master@{#423218}

[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/chrome/app/generated_resources.grd
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/chrome/browser/about_flags.cc
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/content/child/runtime_features.cc
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/content/public/common/content_features.cc
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/content/public/common/content_features.h
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/public/web/WebRuntimeFeatures.h
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/tools/metrics/histograms/histograms.xml
Project Member

Comment 14 by bugdroid1@chromium.org, Oct 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ec676871d9e7963b3575cd76fda00d8077b7fe1

commit 4ec676871d9e7963b3575cd76fda00d8077b7fe1
Author: altimin <altimin@chromium.org>
Date: Thu Oct 06 13:39:33 2016

[scheduler] Change ThreadLoadTracker to use only recent data.

Currently ThreadLoadTracker accumulates data from the start and reports average load of an interval from the start to current moment.

This patch replaces cumulative approach with sliding window and makes ThreadLoadTracker report last minute average load.

BUG= 639852 

Review-Url: https://codereview.chromium.org/2391593002
Cr-Commit-Position: refs/heads/master@{#423509}

[modify] https://crrev.com/4ec676871d9e7963b3575cd76fda00d8077b7fe1/third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker.cc
[modify] https://crrev.com/4ec676871d9e7963b3575cd76fda00d8077b7fe1/third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker.h
[modify] https://crrev.com/4ec676871d9e7963b3575cd76fda00d8077b7fe1/third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker_unittest.cc
[modify] https://crrev.com/4ec676871d9e7963b3575cd76fda00d8077b7fe1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Oct 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac51fd04eefe80d22ecd5d0898fafad906f70f22

commit ac51fd04eefe80d22ecd5d0898fafad906f70f22
Author: altimin <altimin@chromium.org>
Date: Thu Oct 06 18:44:34 2016

[scheduler] Throttle background frames with 1% CPU limit

BUG= 639852 

Committed: https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da
Review-Url: https://codereview.chromium.org/2345483002
Cr-Original-Commit-Position: refs/heads/master@{#423170}
Cr-Commit-Position: refs/heads/master@{#423604}

[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/chrome/app/generated_resources.grd
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/chrome/browser/about_flags.cc
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/content/child/runtime_features.cc
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/content/public/common/content_features.cc
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/content/public/common/content_features.h
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/public/web/WebRuntimeFeatures.h
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/tools/metrics/histograms/histograms.xml

Comment 16 by altimin@chromium.org, Oct 7 2016

Labels: Merge-Request-55
4ec676871d9 "[scheduler] Change ThreadLoadTracker to use only recent data" revision was  landed on October 6th and contains UMA metric fix which we need. Please merge it into M55.

Comment 17 by dimu@chromium.org, Oct 7 2016

Labels: -Merge-Request-55 Merge-Review-55 Hotlist-Merge-Review
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.

Comment 18 by gov...@chromium.org, Oct 7 2016 

M55 Branched Chromium at revision: 423768. No merge is needed here. Could you please double check?

Comment 19 by altimin@chromium.org, Oct 7 2016

Labels: -Hotlist-Merge-review -Merge-Review-55
Sorry, got confused when looking at branches. No merge needed.
Project Member

Comment 20 by bugdroid1@chromium.org, Oct 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4702b576414fc5f06bb20454988d0705fba9e9e

commit b4702b576414fc5f06bb20454988d0705fba9e9e
Author: erikchen <erikchen@chromium.org>
Date: Mon Oct 10 23:29:32 2016

Revert "[scheduler] Throttle background frames with 1% CPU limit"

[Note that original CL had no description].

> BUG= 639852 
> Committed: https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da
> Committed: https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22
> Cr-Original-Commit-Position: refs/heads/master@{#423170}
> Cr-Commit-Position: refs/heads/master@{#423604}

BUG= 639852 , 653865
TBR=jochen@chromium.org, mpearson@chromium.org, altimin@chromium.org, skyostil@chromium.org, alexclarke@chromium.org

Review-Url: https://codereview.chromium.org/2407023002
Cr-Commit-Position: refs/heads/master@{#424283}

[modify] https://crrev.com/b4702b576414fc5f06bb20454988d0705fba9e9e/chrome/app/generated_resources.grd
[modify] https://crrev.com/b4702b576414fc5f06bb20454988d0705fba9e9e/chrome/browser/about_flags.cc
[modify] https://crrev.com/b4702b576414fc5f06bb20454988d0705fba9e9e/content/child/runtime_features.cc
[modify] https://crrev.com/b4702b576414fc5f06bb20454988d0705fba9e9e/content/public/common/content_features.cc
[modify] https://crrev.com/b4702b576414fc5f06bb20454988d0705fba9e9e/content/public/common/content_features.h
[modify] https://crrev.com/b4702b576414fc5f06bb20454988d0705fba9e9e/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/b4702b576414fc5f06bb20454988d0705fba9e9e/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/b4702b576414fc5f06bb20454988d0705fba9e9e/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
[modify] https://crrev.com/b4702b576414fc5f06bb20454988d0705fba9e9e/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/b4702b576414fc5f06bb20454988d0705fba9e9e/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/b4702b576414fc5f06bb20454988d0705fba9e9e/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/b4702b576414fc5f06bb20454988d0705fba9e9e/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/b4702b576414fc5f06bb20454988d0705fba9e9e/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/b4702b576414fc5f06bb20454988d0705fba9e9e/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/b4702b576414fc5f06bb20454988d0705fba9e9e/third_party/WebKit/public/web/WebRuntimeFeatures.h
[modify] https://crrev.com/b4702b576414fc5f06bb20454988d0705fba9e9e/tools/metrics/histograms/histograms.xml

Comment 21 by tbroch@chromium.org, Oct 10 2016

Blockedon: 653865
Project Member

Comment 22 by bugdroid1@chromium.org, Oct 11 2016

Labels: merge-merged-2883
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5d130905d1c817468474f0114bf99eea6914e45

commit d5d130905d1c817468474f0114bf99eea6914e45
Author: erikchen <erikchen@chromium.org>
Date: Tue Oct 11 00:10:34 2016

[Merge to 2883] Revert "[scheduler] Throttle background frames with 1% CPU limit"

> [Note that original CL had no description].
>
> > BUG= 639852 
> > Committed: https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da
> > Committed: https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22
> > Cr-Original-Commit-Position: refs/heads/master@{#423170}
> > Cr-Commit-Position: refs/heads/master@{#423604}
>
> BUG= 639852 , 653865
> TBR=jochen@chromium.org, mpearson@chromium.org, altimin@chromium.org, skyostil@chromium.org, alexclarke@chromium.org
>
> Review-Url: https://codereview.chromium.org/2407023002
> Cr-Commit-Position: refs/heads/master@{#424283}
> (cherry picked from commit b4702b576414fc5f06bb20454988d0705fba9e9e)

Review URL: https://codereview.chromium.org/2409653003 .

Cr-Commit-Position: refs/branch-heads/2883@{#28}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/chrome/app/generated_resources.grd
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/chrome/browser/about_flags.cc
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/content/child/runtime_features.cc
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/content/public/common/content_features.cc
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/content/public/common/content_features.h
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/public/web/WebRuntimeFeatures.h
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/tools/metrics/histograms/histograms.xml
Project Member

Comment 23 by bugdroid1@chromium.org, Oct 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f

commit 1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f
Author: altimin <altimin@chromium.org>
Date: Wed Oct 12 21:06:43 2016

[scheduler] Throttle background frames with 1% CPU limit

BUG= 639852 , 653865

Committed: https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da
Committed: https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22
Review-Url: https://codereview.chromium.org/2345483002
Cr-Original-Original-Commit-Position: refs/heads/master@{#423170}
Cr-Original-Commit-Position: refs/heads/master@{#423604}
Cr-Commit-Position: refs/heads/master@{#424850}

[modify] https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f/chrome/app/generated_resources.grd
[modify] https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f/chrome/browser/about_flags.cc
[modify] https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f/content/child/runtime_features.cc
[modify] https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f/content/public/common/content_features.cc
[modify] https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f/content/public/common/content_features.h
[modify] https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
[modify] https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f/third_party/WebKit/public/web/WebRuntimeFeatures.h
[modify] https://crrev.com/1fca2bed4bacd6fb1dc7ffacd4c2d92d59ceae8f/tools/metrics/histograms/histograms.xml
Project Member

Comment 24 by bugdroid1@chromium.org, Oct 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19cf23b8ffe72e4d1d069e4bdf4a996be67285c8

commit 19cf23b8ffe72e4d1d069e4bdf4a996be67285c8
Author: altimin <altimin@chromium.org>
Date: Tue Oct 18 10:20:28 2016

[scheduler] Support setting maximal throttling duration

This patch adds support of maximal throttling duration to Time Budget API
and makes both maximal throttling duration and maximal budget level optional.

Maximal throttling duration is enforced by setting a lower bound on budget level,
making sure that we will not throttle a queue for more than 1 minute.

R=alexclarke@chromium.org,skyostil@chromium.org
CC=ojan@chromium.org

BUG= 639852 

Review-Url: https://codereview.chromium.org/2412323003
Cr-Commit-Position: refs/heads/master@{#425938}

[modify] https://crrev.com/19cf23b8ffe72e4d1d069e4bdf4a996be67285c8/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/19cf23b8ffe72e4d1d069e4bdf4a996be67285c8/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
[modify] https://crrev.com/19cf23b8ffe72e4d1d069e4bdf4a996be67285c8/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc

Comment 25 by dbasehore@chromium.org, Oct 21 2016 

Is this implemented and will it be on R55?

Comment 26 by sebp.mue...@gmail.com, Oct 21 2016 

I would also like to understand how this could be affecting working code. From the one sentence description I cannot really see what code will be throttled by Chrome and when under what circumstances. Is there a link to some specification or discussion that I am not seeing? This sounds a bit like the recent setTimeout "improvements" so developers need to start working on workarounds and be prepared to be confronted with new bug reports for their existing applications. 
Does this mean that if you focus another tab that the original tabs can be throttled up to 99%?

Comment 27 by altimin@chromium.org, Oct 21 2016 

No, this is not in M55. This is implemented behind a flag in canary and dev.

Comment 28 by altimin@chromium.org, Oct 21 2016 

https://www.chromestatus.com/features/6172836527865856 contains some links with more detailed information about this.

TL;DR: Background timers (setTimeout & setInterval) will be throttled. Throttling will become active when a tab is backgrounded (you focus a new tab and old tab becomes completely invisible). We're also interested in use cases when this approach breaks something.
Project Member

Comment 29 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e25269603f52b2f26ab6db689f730af15a2607da

commit e25269603f52b2f26ab6db689f730af15a2607da
Author: altimin <altimin@chromium.org>
Date: Wed Oct 05 15:53:00 2016

[scheduler] Throttle background frames with 1% CPU limit

BUG= 639852 

Review-Url: https://codereview.chromium.org/2345483002
Cr-Commit-Position: refs/heads/master@{#423170}

[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/chrome/app/generated_resources.grd
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/chrome/browser/about_flags.cc
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/content/child/runtime_features.cc
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/content/public/common/content_features.cc
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/content/public/common/content_features.h
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/third_party/WebKit/public/web/WebRuntimeFeatures.h
[modify] https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da/tools/metrics/histograms/histograms.xml
Project Member

Comment 30 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88ca6a85e43bdc1944e6383981d645fed3db7509

commit 88ca6a85e43bdc1944e6383981d645fed3db7509
Author: penghuang <penghuang@chromium.org>
Date: Wed Oct 05 18:03:08 2016

Revert "[scheduler] Throttle background frames with 1% CPU limit"

This reverts commit e25269603f52b2f26ab6db689f730af15a2607da.

Revert this CL because content_browsertests failed on ubuntu-12.04.

See log:
https://uberchromegw.corp.google.com/i/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/34119

TBR=jochen@chromium.org

# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 639852 

Review-Url: https://codereview.chromium.org/2393193003
Cr-Commit-Position: refs/heads/master@{#423218}

[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/chrome/app/generated_resources.grd
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/chrome/browser/about_flags.cc
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/content/child/runtime_features.cc
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/content/public/common/content_features.cc
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/content/public/common/content_features.h
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/third_party/WebKit/public/web/WebRuntimeFeatures.h
[modify] https://crrev.com/88ca6a85e43bdc1944e6383981d645fed3db7509/tools/metrics/histograms/histograms.xml
Project Member

Comment 31 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ec676871d9e7963b3575cd76fda00d8077b7fe1

commit 4ec676871d9e7963b3575cd76fda00d8077b7fe1
Author: altimin <altimin@chromium.org>
Date: Thu Oct 06 13:39:33 2016

[scheduler] Change ThreadLoadTracker to use only recent data.

Currently ThreadLoadTracker accumulates data from the start and reports average load of an interval from the start to current moment.

This patch replaces cumulative approach with sliding window and makes ThreadLoadTracker report last minute average load.

BUG= 639852 

Review-Url: https://codereview.chromium.org/2391593002
Cr-Commit-Position: refs/heads/master@{#423509}

[modify] https://crrev.com/4ec676871d9e7963b3575cd76fda00d8077b7fe1/third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker.cc
[modify] https://crrev.com/4ec676871d9e7963b3575cd76fda00d8077b7fe1/third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker.h
[modify] https://crrev.com/4ec676871d9e7963b3575cd76fda00d8077b7fe1/third_party/WebKit/Source/platform/scheduler/base/thread_load_tracker_unittest.cc
[modify] https://crrev.com/4ec676871d9e7963b3575cd76fda00d8077b7fe1/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
Project Member

Comment 32 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac51fd04eefe80d22ecd5d0898fafad906f70f22

commit ac51fd04eefe80d22ecd5d0898fafad906f70f22
Author: altimin <altimin@chromium.org>
Date: Thu Oct 06 18:44:34 2016

[scheduler] Throttle background frames with 1% CPU limit

BUG= 639852 

Committed: https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da
Review-Url: https://codereview.chromium.org/2345483002
Cr-Original-Commit-Position: refs/heads/master@{#423170}
Cr-Commit-Position: refs/heads/master@{#423604}

[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/chrome/app/generated_resources.grd
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/chrome/browser/about_flags.cc
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/content/child/runtime_features.cc
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/content/public/common/content_features.cc
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/content/public/common/content_features.h
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/third_party/WebKit/public/web/WebRuntimeFeatures.h
[modify] https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22/tools/metrics/histograms/histograms.xml
Project Member

Comment 33 by bugdroid1@chromium.org, Oct 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5d130905d1c817468474f0114bf99eea6914e45

commit d5d130905d1c817468474f0114bf99eea6914e45
Author: erikchen <erikchen@chromium.org>
Date: Tue Oct 11 00:10:34 2016

[Merge to 2883] Revert "[scheduler] Throttle background frames with 1% CPU limit"

> [Note that original CL had no description].
>
> > BUG= 639852 
> > Committed: https://crrev.com/e25269603f52b2f26ab6db689f730af15a2607da
> > Committed: https://crrev.com/ac51fd04eefe80d22ecd5d0898fafad906f70f22
> > Cr-Original-Commit-Position: refs/heads/master@{#423170}
> > Cr-Commit-Position: refs/heads/master@{#423604}
>
> BUG= 639852 , 653865
> TBR=jochen@chromium.org, mpearson@chromium.org, altimin@chromium.org, skyostil@chromium.org, alexclarke@chromium.org
>
> Review-Url: https://codereview.chromium.org/2407023002
> Cr-Commit-Position: refs/heads/master@{#424283}
> (cherry picked from commit b4702b576414fc5f06bb20454988d0705fba9e9e)

Review URL: https://codereview.chromium.org/2409653003 .

Cr-Commit-Position: refs/branch-heads/2883@{#28}
Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768}

[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/chrome/app/generated_resources.grd
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/chrome/browser/about_flags.cc
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/content/child/runtime_features.cc
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/content/public/common/content_features.cc
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/content/public/common/content_features.h
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/Source/web/WebRuntimeFeatures.cpp
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/third_party/WebKit/public/web/WebRuntimeFeatures.h
[modify] https://crrev.com/d5d130905d1c817468474f0114bf99eea6914e45/tools/metrics/histograms/histograms.xml

Comment 34 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 35 by bugdroid1@chromium.org, Nov 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74942b51aa27981ee18d9cbfe1425a250ab76abc

commit 74942b51aa27981ee18d9cbfe1425a250ab76abc
Author: altimin <altimin@chromium.org>
Date: Tue Nov 08 20:41:30 2016

[scheduler] Report background timer throttling intervention.

Use InterventionReporter to report throttling to the console if the
throttling delay is greater than 3 seconds. (It doesn't make sense
to report smaller throttling durations given that we align timers to
1Hz).

BUG= 639852 

Review-Url: https://codereview.chromium.org/2476973002
Cr-Commit-Position: refs/heads/master@{#430704}

[modify] https://crrev.com/74942b51aa27981ee18d9cbfe1425a250ab76abc/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
[modify] https://crrev.com/74942b51aa27981ee18d9cbfe1425a250ab76abc/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/74942b51aa27981ee18d9cbfe1425a250ab76abc/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
[modify] https://crrev.com/74942b51aa27981ee18d9cbfe1425a250ab76abc/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/74942b51aa27981ee18d9cbfe1425a250ab76abc/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/74942b51aa27981ee18d9cbfe1425a250ab76abc/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
Project Member

Comment 36 by bugdroid1@chromium.org, Nov 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/56bb594b1b341695c09b9041cdf02a76af306cc3

commit 56bb594b1b341695c09b9041cdf02a76af306cc3
Author: altimin <altimin@chromium.org>
Date: Wed Nov 09 19:45:17 2016

[scheduler] Use Finch to control background throttling.

BUG= 639852 

Review-Url: https://codereview.chromium.org/2471153002
Cr-Commit-Position: refs/heads/master@{#431013}

[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/content/browser/BUILD.gn
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/content/browser/renderer_host/DEPS
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/content/public/common/web_preferences.cc
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/content/public/common/web_preferences.h
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/content/renderer/render_view_impl.cc
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.cc
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.h
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/platform/scheduler/renderer/renderer_web_scheduler_impl.cc
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/platform/scheduler/renderer/renderer_web_scheduler_impl.h
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/web/WebSettingsImpl.cpp
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/web/WebSettingsImpl.h
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/public/platform/WebScheduler.h
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/public/platform/WebViewScheduler.h
[modify] https://crrev.com/56bb594b1b341695c09b9041cdf02a76af306cc3/third_party/WebKit/public/web/WebSettings.h
Project Member

Comment 38 by bugdroid1@chromium.org, Nov 23 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8991961c94284b66c45ef222bdd3f787327a3c81

commit 8991961c94284b66c45ef222bdd3f787327a3c81
Author: altimin <altimin@chromium.org>
Date: Wed Nov 23 17:22:46 2016

[scheduler] Account for disabling throttling in TaskQueueThrottler::IsThrottled

TaskQueueThrottler::IsThrottled didn't respect global on/off throttling
switch. This led to TaskQueueThrottler::TimeBudgetPool::EnableThrottling
permanently disabling some queues.

R=skyostil@chromium.org
CC=alexclarke@chromium.org

BUG= 639852 

Review-Url: https://codereview.chromium.org/2523673003
Cr-Commit-Position: refs/heads/master@{#434195}

[modify] https://crrev.com/8991961c94284b66c45ef222bdd3f787327a3c81/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/8991961c94284b66c45ef222bdd3f787327a3c81/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
[modify] https://crrev.com/8991961c94284b66c45ef222bdd3f787327a3c81/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
Project Member

Comment 39 by bugdroid1@chromium.org, Nov 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2aefa856b292402f4be012f6006eebb55f2abf51

commit 2aefa856b292402f4be012f6006eebb55f2abf51
Author: altimin <altimin@chromium.org>
Date: Thu Nov 24 21:50:35 2016

[scheduler] Fix TaskQueueThrottler::SetQueueEnabled logic.

- At the moment check for scheduling a call to PumpThrottledTasks in
  TaskQueueThrottler::SetQueueEnabled is wrong, should be (enabled)
  instead of (!enabled).
- Added tzik@'s test.
- Improved comments in TaskQueueThrottler::SetQueueEnabled.

BUG= 639852 

Review-Url: https://codereview.chromium.org/2528963002
Cr-Commit-Position: refs/heads/master@{#434394}

[modify] https://crrev.com/2aefa856b292402f4be012f6006eebb55f2abf51/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/2aefa856b292402f4be012f6006eebb55f2abf51/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc

Comment 40 by skyos...@chromium.org, Nov 25 2016 

Thanks for the fixes. Should we backport something here yet?

Comment 41 by altimin@chromium.org, Nov 25 2016

Labels: -merge-merged-2883 Merge-Request-56
It's a good question. I think that the answer is yes.

Note: merge is requested for two last commits, which are bugfixes.

Comment 42 by dimu@chromium.org, Nov 25 2016

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.

Comment 43 by bustamante@google.com, Nov 30 2016

Labels: -Merge-Review-56 Merge-Approved-56
Approving for merge into M56 for the last two commits.
Project Member

Comment 44 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75054c3253330b7e4f66aced36f4c9b88bb9f1e8

commit 75054c3253330b7e4f66aced36f4c9b88bb9f1e8
Author: altimin <altimin@chromium.org>
Date: Thu Dec 01 00:36:31 2016

[scheduler] Enable expensive background timer throttling on waterfall.

BUG= 639852 

Review-Url: https://codereview.chromium.org/2532183002
Cr-Commit-Position: refs/heads/master@{#435496}

[modify] https://crrev.com/75054c3253330b7e4f66aced36f4c9b88bb9f1e8/testing/variations/fieldtrial_testing_config.json
Project Member

Comment 45 by bugdroid1@chromium.org, Dec 1 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7cff62eea021dba8b9b2949d58a3b477dd8eda4

commit a7cff62eea021dba8b9b2949d58a3b477dd8eda4
Author: Alexander Timin <altimin@chromium.org>
Date: Thu Dec 01 14:12:05 2016

[scheduler] Account for disabling throttling in TaskQueueThrottler::IsThrottled

TaskQueueThrottler::IsThrottled didn't respect global on/off throttling
switch. This led to TaskQueueThrottler::TimeBudgetPool::EnableThrottling
permanently disabling some queues.

R=skyostil@chromium.org
CC=alexclarke@chromium.org

BUG= 639852 

Review-Url: https://codereview.chromium.org/2523673003
Cr-Commit-Position: refs/heads/master@{#434195}
(cherry picked from commit 8991961c94284b66c45ef222bdd3f787327a3c81)

Review URL: https://codereview.chromium.org/2548483002 .

Cr-Commit-Position: refs/branch-heads/2924@{#243}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/a7cff62eea021dba8b9b2949d58a3b477dd8eda4/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.cc
[modify] https://crrev.com/a7cff62eea021dba8b9b2949d58a3b477dd8eda4/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler.h
[modify] https://crrev.com/a7cff62eea021dba8b9b2949d58a3b477dd8eda4/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc

Comment 46 by altimin@chromium.org, Dec 8 2016

Blockedon: 671814

Comment 47 by altimin@chromium.org, Dec 16 2016

Blocking: 650594

Comment 48 by hennessywill@google.com, Jan 20 2017 

this bug is unblocked. When can you start work on it? I would like to unblock the two bugs depending on this one

Comment 49 by ojan@chromium.org, Feb 2 2017

Blocking: 687833
Project Member

Comment 50 by bugdroid1@chromium.org, Feb 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0618218ad2514070703af6237b0ae3579276b433

commit 0618218ad2514070703af6237b0ae3579276b433
Author: altimin <altimin@chromium.org>
Date: Thu Feb 09 09:14:42 2017

[scheduler] Plumb websocket information to scheduler

Notify scheduler about websocket connections and stop budget-based
throttling when one is present.

BUG= 639852 

Review-Url: https://codereview.chromium.org/2652973002
Cr-Commit-Position: refs/heads/master@{#449243}

[modify] https://crrev.com/0618218ad2514070703af6237b0ae3579276b433/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
[modify] https://crrev.com/0618218ad2514070703af6237b0ae3579276b433/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h
[modify] https://crrev.com/0618218ad2514070703af6237b0ae3579276b433/third_party/WebKit/Source/platform/WebFrameScheduler.h
[modify] https://crrev.com/0618218ad2514070703af6237b0ae3579276b433/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/0618218ad2514070703af6237b0ae3579276b433/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/0618218ad2514070703af6237b0ae3579276b433/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/0618218ad2514070703af6237b0ae3579276b433/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/0618218ad2514070703af6237b0ae3579276b433/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
[modify] https://crrev.com/0618218ad2514070703af6237b0ae3579276b433/third_party/WebKit/Source/web/BUILD.gn
[add] https://crrev.com/0618218ad2514070703af6237b0ae3579276b433/third_party/WebKit/Source/web/tests/ActiveConnectionThrottlingTest.cpp
[modify] https://crrev.com/0618218ad2514070703af6237b0ae3579276b433/third_party/WebKit/public/platform/WebViewScheduler.h

Comment 51 by altimin@chromium.org, Feb 9 2017

Blockedon: 690375

Comment 52 by altimin@chromium.org, Feb 10 2017

Blockedon: 690929
Project Member

Comment 53 by bugdroid1@chromium.org, Feb 13 2017

Labels: merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d1089983ba725a41da52e32d19ca6dbd20fcdbd

commit 0d1089983ba725a41da52e32d19ca6dbd20fcdbd
Author: Alexander Timin <altimin@chromium.org>
Date: Mon Feb 13 14:16:50 2017

[scheduler] Plumb websocket information to scheduler

Notify scheduler about websocket connections and stop budget-based
throttling when one is present.

BUG= 639852 

Review-Url: https://codereview.chromium.org/2652973002
Cr-Commit-Position: refs/heads/master@{#449243}
(cherry picked from commit 0618218ad2514070703af6237b0ae3579276b433)

Review-Url: https://codereview.chromium.org/2696483003 .
Cr-Commit-Position: refs/branch-heads/2987@{#473}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/0d1089983ba725a41da52e32d19ca6dbd20fcdbd/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
[modify] https://crrev.com/0d1089983ba725a41da52e32d19ca6dbd20fcdbd/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h
[modify] https://crrev.com/0d1089983ba725a41da52e32d19ca6dbd20fcdbd/third_party/WebKit/Source/platform/WebFrameScheduler.h
[modify] https://crrev.com/0d1089983ba725a41da52e32d19ca6dbd20fcdbd/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.cc
[modify] https://crrev.com/0d1089983ba725a41da52e32d19ca6dbd20fcdbd/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl.h
[modify] https://crrev.com/0d1089983ba725a41da52e32d19ca6dbd20fcdbd/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/0d1089983ba725a41da52e32d19ca6dbd20fcdbd/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/0d1089983ba725a41da52e32d19ca6dbd20fcdbd/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
[modify] https://crrev.com/0d1089983ba725a41da52e32d19ca6dbd20fcdbd/third_party/WebKit/Source/web/BUILD.gn
[add] https://crrev.com/0d1089983ba725a41da52e32d19ca6dbd20fcdbd/third_party/WebKit/Source/web/tests/ActiveConnectionThrottlingTest.cpp
[modify] https://crrev.com/0d1089983ba725a41da52e32d19ca6dbd20fcdbd/third_party/WebKit/public/platform/WebViewScheduler.h

Comment 54 by ojan@chromium.org, Feb 24 2017

Blocking: 693054

Comment 55 by derat@chromium.org, Mar 20 2017

Cc: rsch...@chromium.org altimin@chromium.org alberto@chromium.org snanda@chromium.org bccheng@chromium.org dbasehore@chromium.org ejcaruso@chromium.org
 Issue 530437  has been merged into this issue.

Comment 56 by altimin@chromium.org, Mar 20 2017

Status: Fixed (was: Started)
This was shipped in Chrome 57, closing this bug.
Project Member

Comment 57 by bugdroid1@chromium.org, Jun 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1ec336f2617a7351f96362affff4e5a575baa2c

commit e1ec336f2617a7351f96362affff4e5a575baa2c
Author: Alexander Timin <altimin@chromium.org>
Date: Mon Jun 12 15:53:11 2017

[scheduler] Post-launch cleanup for background timer throttling

Turn on ExpensiveBackgroundTimerThrottling by default, but leave the
ability to turn it off quickly via Finch.

This patch also removes now-unneeded plumbing, given that now we can
access field trial parameters from a renderer process.

BUG= 639852 
R=jochen@chromium.org,haraken@chromium.org,alexclarke@chromium.org,skyostil@chromium.org

Change-Id: I8e3e342dd5f15a7f011fbe5d815f83b6fa46e124
Reviewed-on: https://chromium-review.googlesource.com/529109
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#478640}
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/content/public/common/common_param_traits_macros.h
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/content/public/common/content_features.cc
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/content/public/common/web_preferences.cc
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/content/public/common/web_preferences.h
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/content/renderer/render_view_impl.cc
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/core/dom/IdleDeadlineTest.cpp
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/core/dom/ScriptedIdleTaskControllerTest.cpp
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/core/exported/WebSettingsImpl.cpp
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/core/exported/WebSettingsImpl.h
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/platform/scheduler/DEPS
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/platform/scheduler/child/web_scheduler.h
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.cc
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/platform/scheduler/child/web_scheduler_impl.h
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/platform/scheduler/renderer/renderer_web_scheduler_impl.cc
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/platform/scheduler/renderer/renderer_web_scheduler_impl.h
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/platform/scheduler/renderer/web_frame_scheduler_impl_unittest.cc
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler.h
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.cc
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl.h
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/platform/scheduler/renderer/web_view_scheduler_impl_unittest.cc
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/e1ec336f2617a7351f96362affff4e5a575baa2c/third_party/WebKit/public/web/WebSettings.h
►

Sign in to add a comment