FrameSelection should observe style changes to trigger selection paint
Reported by
dea...@gmail.com,
Aug 22 2016
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36 Example URL: Steps to reproduce the problem: 1. create html page with some elements hidden by default 2. create text selection 3. make hidden elements visible What is the expected behavior? selected elements should have selection highlight What went wrong? new elements stays unselected. minimal example in the attach Does it occur on multiple sites: Yes Is it a problem with a plugin? No Did this work before? Yes Does this work in other browsers? Yes Chrome version: 52.0.2743.116 Channel: stable OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Shockwave Flash 22.0 r0
,
Aug 23 2016
Tested the same on win10 and mac 10.11.5 chrome version 52.0.2743.116 and canary - row1 and row3 are highlighted This issue can be seen from M47 builds as well This is working fine on Linux Firefox : All rows are highlighted as shown in the screenshot M46 and before builds: All the rows are highlighted as shown in the screenshot
,
Oct 12 2016
,
Oct 21 2016
,
Jun 13 2017
,
Jul 26 2017
,
Jul 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3050c92629b82edce0c74dcddce7cf836a39f046 commit 3050c92629b82edce0c74dcddce7cf836a39f046 Author: Yoichi Osato <yoichio@chromium.org> Date: Wed Jul 26 11:00:09 2017 Repaint selection even if SelectionPaintRange is same to previous. We didn't anything if we have same {LayoutObject,offset}s but we need to repaint in the case where just CSS display property is updated. Bug: 739062 , 639830 Change-Id: I2a9c7d69a87119dbc7679d1213ca39e8b277f7d3 Reviewed-on: https://chromium-review.googlesource.com/584665 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#489605} [add] https://crrev.com/3050c92629b82edce0c74dcddce7cf836a39f046/third_party/WebKit/LayoutTests/paint/selection/text-selection-update-style-expected.txt [add] https://crrev.com/3050c92629b82edce0c74dcddce7cf836a39f046/third_party/WebKit/LayoutTests/paint/selection/text-selection-update-style.html [modify] https://crrev.com/3050c92629b82edce0c74dcddce7cf836a39f046/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/selection-after-remove-expected.txt [modify] https://crrev.com/3050c92629b82edce0c74dcddce7cf836a39f046/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/selection-after-remove-expected.txt [add] https://crrev.com/3050c92629b82edce0c74dcddce7cf836a39f046/third_party/WebKit/LayoutTests/platform/mac/paint/selection/text-selection-update-style-expected.png [modify] https://crrev.com/3050c92629b82edce0c74dcddce7cf836a39f046/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/selection-after-remove-expected.txt [add] https://crrev.com/3050c92629b82edce0c74dcddce7cf836a39f046/third_party/WebKit/LayoutTests/platform/win/paint/selection/text-selection-update-style-expected.png [modify] https://crrev.com/3050c92629b82edce0c74dcddce7cf836a39f046/third_party/WebKit/Source/core/editing/LayoutSelection.cpp
,
Jul 27 2017
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by junov@chromium.org
, Aug 22 2016