New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639828 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 635918



Sign in to add a comment

Bisect marks a good revision as "bad"

Project Member Reported by petrcermak@chromium.org, Aug 22 2016

Issue description

Context: https://bugs.chromium.org/p/chromium/issues/detail?id=635918#c32

===== TESTED REVISIONS =====
Revision         Mean      Std Dev   N   Good?
chromium@409210  77676929  6094741   27  good
chromium@409262  75282267  6147158   27  bad    <---- ALL OF THESE ARE ACTUALLY
chromium@409314  76477740  2577.84   18  bad    <---- BETTER THAN THE "GOOD"
chromium@409417  76480840  0.0       5   bad    <---- REFERENCE (r409210)!!!
chromium@409624  80409160  11121104  8   bad

 
Components: Tests>AutoBisect
Wow, maybe something to do with the std dev being all over the map?

Prasad, can you take a look (maybe pairing with Dave) since you're the triage oncall this week?

Comment 2 by dtu@chromium.org, Aug 25 2016

It's that multiple bisect is not implemented.
If the algorithm matched what's written in the "Bisect Confidence" doc, the algorithm would've bisected on both an improvement between 409210 and 409417, and a regression between 409417 and 409624.

There's an improvement between 409210 and 409417 because the std dev at 409417 is 0, so any deviation from that value would indicate a regression or improvement.

Comment 3 by dtu@chromium.org, Aug 25 2016

(Because multiple bisect is not implemented, it just picks the first change, the improvement, to bisect on. This is not correct.)
OK, so you're saying that there are:

1. improvement from r409210 to r409417
2. regression  from r409417 to r409624

What I don't understand is that when you give it the initial reference range, where r409210 is "good" and r409624 is "bad", how come it decides that the middle revision (r409417) is also "bad" (even though it is even better than the "good" revision)?
Components: Speed>Bisection

Comment 6 by dtu@chromium.org, Jan 26 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment