Unnecessary 'loading' text is seen on chrome://history/syncedTabs page for long period of time after hiding all links.
Reported by
jshan...@etouch.net,
Aug 22 2016
|
||||
Issue descriptionChrome Version: 54.0.2836.0 (Official Build) 5916d5e380c5a9da48673de99d40267507d46f34-refs/heads/master@{#413363}-32/64 bit OS: Linux (14.04. LTS), Mac (10.10.5, 10.11.5), Windows (7,8,10) Steps: 1. Launch chrome, navigate to chrome://history/syncedTabs and 'Sign into Chrome' with valid credentials. 2. Hide all the links by selecting 'Hide for now' option from 'Actions' menu. 3. Now reload the page and observe. Actual: Unnecessary 'loading' text is seen for long period of time after reloading chrome://history/syncedTabs page. Expected: Unnecessary 'loading' text should not be seen for long period of time after reloading chrome://history/syncedTabs page. This is a non-regression issue seen from 'M-54', as this is new feature introduced in 54.0.2824.0
,
Aug 23 2016
,
Aug 29 2016
Anyone taking care of this? Otherwise I'll take a look:)
,
Aug 29 2016
Nope, go ahead~
,
Sep 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/93a39a3cfff736b8e10f65e9d7bf2612186a26c8 commit 93a39a3cfff736b8e10f65e9d7bf2612186a26c8 Author: lshang <lshang@chromium.org> Date: Fri Sep 30 05:52:11 2016 MD History: Update sign in state in data source Currently we get user's sign in state from LoadTimeData() on page load, but WebUI data source is re-used when refreshing the page, which will cause bugs if user changes sign in state(e.g. via sign in promo) and reload the page because LoadTimeData() will return out-dated sign in state. We made a quick fix before by chrome.sending 'otherDevicesInitialized' after synced device manager is attached to the document, so that signInStateChanged() gets called to update element's current state. But this would cause a *fake* sign-in action(when user signs in via promo and reload, signInState will first be set false from LoadTimeData and then changes to be true from otherDevicesInitialized) and 'Loading' message will keeps showing if no other actions trigger updateSyncedDevices() to stop the fetching state. So in this CL, we update the sign in state in WebUI data source, when profile info changed in HistoryLoginHandler. This will guarantee that LoadTimeData() returns updated state every time page gets loaded. BUG= 639811 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2361513003 Cr-Commit-Position: refs/heads/master@{#422038} [modify] https://crrev.com/93a39a3cfff736b8e10f65e9d7bf2612186a26c8/chrome/browser/resources/history/other_devices.js [modify] https://crrev.com/93a39a3cfff736b8e10f65e9d7bf2612186a26c8/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/93a39a3cfff736b8e10f65e9d7bf2612186a26c8/chrome/browser/resources/md_history/app.html [modify] https://crrev.com/93a39a3cfff736b8e10f65e9d7bf2612186a26c8/chrome/browser/resources/md_history/app.js [modify] https://crrev.com/93a39a3cfff736b8e10f65e9d7bf2612186a26c8/chrome/browser/resources/md_history/compiled_resources2.gyp [modify] https://crrev.com/93a39a3cfff736b8e10f65e9d7bf2612186a26c8/chrome/browser/ui/webui/history_login_handler.cc [modify] https://crrev.com/93a39a3cfff736b8e10f65e9d7bf2612186a26c8/chrome/browser/ui/webui/history_login_handler.h [modify] https://crrev.com/93a39a3cfff736b8e10f65e9d7bf2612186a26c8/chrome/browser/ui/webui/history_ui.cc [modify] https://crrev.com/93a39a3cfff736b8e10f65e9d7bf2612186a26c8/chrome/browser/ui/webui/history_ui.h [modify] https://crrev.com/93a39a3cfff736b8e10f65e9d7bf2612186a26c8/chrome/browser/ui/webui/md_history_ui.cc [modify] https://crrev.com/93a39a3cfff736b8e10f65e9d7bf2612186a26c8/chrome/browser/ui/webui/md_history_ui.h
,
Oct 4 2016
I believe this is now fixed. |
||||
►
Sign in to add a comment |
||||
Comment 1 by ranjitkan@chromium.org
, Aug 22 2016