New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639795 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

chrome://md-settings/searchEngines page goes blank after reloading.

Reported by jshan...@etouch.net, Aug 22 2016

Issue description

Chrome Version: 54.0.2836.0 (Official Build) 5916d5e380c5a9da48673de99d40267507d46f34-refs/heads/master@{#413363}-32/64 bit
OS: Mac (10.10.5, 10.11.5), Windows (7,8,10), Linux

Steps:
1. Launch Chrome and navigate to chrome://md-settings.
2. Click on 'Manage search engines', reload the page and observe.

Actual: chrome://md-settings/searchEngines page goes blank after reloading.

Expected: chrome://md-settings/searchEngines page should not go blank after reloading.

This is a regression issue broken in M-54, will soon update bisect info.

Good build: 54.0.2832.0 
Bad build: 54.0.2833.0 


 
Actual_settings.mp4
406 KB View Download
Expected_settings.mp4
526 KB View Download

Comment 1 by jshan...@etouch.net, Aug 22 2016

Labels: hasbisect
Owner: steve...@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/3839dbc4efacbba65f5d395301f2fecb9c58c1fa..01fae36efcb5eadacbd2fb8396456645a104876b?pretty=fuller&n=100

Suspecting: r412896 ?

Please help to re-assign if your change is not the cause.
Cc: dschuyler@chromium.org
Labels: OS-Chrome
I didn't think this was working before. Either way, we need to make this page work when navigating to it directly; I will take a look.

Labels: -Type-Bug-Regression Type-Bug
Marking MD-Settings bugs non-regressions since this is still in active development.
Summary: chrome://md-settings/searchEngines page goes blank after reloading. (was: Regression: chrome://md-settings/searchEngines page goes blank after reloading.)
Labels: -M-54 M-55
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Sep 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c697de24370a2156fe3a6d616d75105005d4029

commit 2c697de24370a2156fe3a6d616d75105005d4029
Author: stevenjb <stevenjb@chromium.org>
Date: Tue Sep 27 16:33:52 2016

MD Settings: Use scrollable behavior for all iron-list containers

This  adds a .scroll-container class which adds a 1px min-height
to ensure that scrollable iron-list elements update.

It also updates search_engines_page to use CrScrollableBehavior.

Note: Even though we are now using scrollable-behavior for search
engines, since we do not enforce a max height on the page or the
container, the containers will never actually scroll (but if we
do set a maximum page height they will, which is nice).

BUG= 639795 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2338133011
Cr-Commit-Position: refs/heads/master@{#421232}

[modify] https://crrev.com/2c697de24370a2156fe3a6d616d75105005d4029/chrome/browser/resources/settings/on_startup_page/startup_urls_page.html
[modify] https://crrev.com/2c697de24370a2156fe3a6d616d75105005d4029/chrome/browser/resources/settings/search_engines_page/compiled_resources2.gyp
[modify] https://crrev.com/2c697de24370a2156fe3a6d616d75105005d4029/chrome/browser/resources/settings/search_engines_page/search_engines_list.html
[modify] https://crrev.com/2c697de24370a2156fe3a6d616d75105005d4029/chrome/browser/resources/settings/search_engines_page/search_engines_list.js
[modify] https://crrev.com/2c697de24370a2156fe3a6d616d75105005d4029/ui/webui/resources/cr_elements/shared_style_css.html

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Verified on ChromeOS 8872.18.0, 55.0.2883.20

Sign in to add a comment