New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639783 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to open off-screen 'Actions' drop-down list

Reported by dchau...@etouch.net, Aug 22 2016

Issue description

Chrome Version: 54.0.2836.0 (Official Build)Revision5916d5e380c5a9da48673de99d40267507d46f34-refs/heads/master@{#413363} (32/64-bit)
OS: Linux (14.04. LTS), Mac (10.10.5, 10.11.5), Windows (7,8,10)

What steps will reproduce the problem?
1. Launch chrome, navigate to 20-25 webpages and then go to chrome://history page.
2. Set focus on 'Actions' icon using 'Tab' key from keyboard.
3. Scroll down the page to its bottom end using mouse wheel.
4. Now, press 'Enter' key from keyboard and observe.

Actions drop-down list doesn't get opened.
Actions drop-down list should get opened. 

This is a regression issue, broken in M-53 series, below is bisect.

Good build: 53.0.2754.0 
Bad build: 53.0.2756.0 

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/3cb4d9e227dfd94aea54f5a42734e136260f8a08..b403f7be0f0fb1cac7d3478b92c8c171060b4785?pretty=fuller&n=100

Suspecting: r397002 or r397007

Kindly review the attached screen-cast for reference.
 
Actual behavior.mp4
1.2 MB View Download
Expected behavior.mp4
1.0 MB View Download
Labels: -Pri-1 Proj-MaterialDesign-WebUI Pri-2
Summary: Regression: Unable to open off-screen 'Actions' drop-down list (was: Regression: [MD History]Unable to open 'Actions' drop down list using keyboard shortcut.)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/997841c120ef5c64f5ae10392619a88c0462fedd

commit 997841c120ef5c64f5ae10392619a88c0462fedd
Author: tsergeant <tsergeant@chromium.org>
Date: Thu Jan 19 04:55:25 2017

MD History: Scroll history-items into view when their action menu is opened

It is possible to use keyboard shortcuts to open the action menu of an
off-screen history-item. This does not cause any visible change, but
prevents scrolling until the (invisible) menu is closed by clicking or
pressing escape.

This CL fixes this behavior by ensuring that off-screen history-items
are scrolled into view when their menu is opened.

BUG= 639783 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2644733003
Cr-Commit-Position: refs/heads/master@{#444646}

[modify] https://crrev.com/997841c120ef5c64f5ae10392619a88c0462fedd/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/997841c120ef5c64f5ae10392619a88c0462fedd/chrome/browser/resources/md_history/history_list.js

Status: Fixed (was: Assigned)

Sign in to add a comment