New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639774 link

Starred by 4 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

REGRESSION: style issue with active tab on top tab-bar

Reported by geki...@gmail.com, Aug 22 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2832.2 Safari/537.36

Steps to reproduce the problem:
1. i tested it with a incognito window and 3 tabs
2. 
3. 

What is the expected behavior?

What went wrong?
it doesn't look ok ... see screenshot

Did this work before? Yes think with the dev before it was ok (but not sure)

Chrome version: 54.0.2832.2  Channel: dev
OS Version: 10.0
Flash Version: Shockwave Flash 23.0 r0
 
bug.png
2.3 KB View Download
Cc: msrchandra@chromium.org
Labels: Needs-Feedback
@geki007 -- Tested the issue on Chrome Dev# 54.0.2832.2 on Windows and did not find any style issue in incognito windows.
Could you please let us know what exactly the style issue you are observing.
Thanks in Advance.

Comment 2 by geki...@gmail.com, Aug 23 2016

see the red circle in the screenshot ... for me it looks like the cant of the active tab has a nice bold line when it overlaps the inactive tab but not when it doesn't overlap

if you say it's ok it could also be ok
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 30 2016

Labels: -Needs-Feedback Needs-Review
Owner: msrchandra@chromium.org
Thank you for providing more feedback. Adding requester "msrchandra@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Needs-Review Needs-Feedback
Owner: ----
@geki007 -- Tested the issue again on Chrome Dev# 54.0.2840.8 on Windows and could not observe anything as mentioned in the screenshot.
Could you please let us know whether there was any specific theme installed.
Thanks in Advance.

Comment 5 by geki...@gmail.com, Sep 6 2016

sry i'm not good in painting but i try it again
for me it looks like the blue line i painted should be there
if you still don't see it ... i think i'm the problem and you can close the bug :)
no theme, just incognito window
bug.png
2.3 KB View Download
Are you talking about the tab border that was intentionally added in an effort to visually separate tab strip and the window frame more on darkish themes, implemented in  issue 585470 ?

Comment 7 by geki...@gmail.com, Sep 7 2016

i'm not sure if it's the same ... but yes talking about the border
i just think there is no border or a ~1px bad positioned border where i painted the blue line

Comment 8 by geki...@gmail.com, Sep 7 2016

the border looks different where it overlaps another tab
Labels: Needs-Bisect
Components: UI>Browser>Incognito
Labels: -Needs-Bisect
Attaching the screenshot by checking on Chrome Dev# 55.0.2853.0 and Chrome Canary# 55.0.2858.0.
Could some one from incognito team please look into the issue and update.
Thanks in Advance.

Note: Removing Needs Bisect label as of now.
639774.jpg
99 KB View Download
Project Member

Comment 11 by sheriffbot@chromium.org, Sep 19 2016

Labels: -Needs-Feedback Needs-Review
Owner: msrchandra@chromium.org
Thank you for providing more feedback. Adding requester "msrchandra@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Needs-Review Needs-Feedback
Owner: ----

Comment 13 Deleted

Comment 14 by geki...@gmail.com, Nov 10 2016

do you need feedback from me?
Project Member

Comment 15 by sheriffbot@chromium.org, Nov 17 2016

Labels: -Needs-Feedback Needs-Review
Owner: msrchandra@chromium.org
Thank you for providing more feedback. Adding requester "msrchandra@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Needs-Review Needs-Feedback
Owner: ----
@geki007 -- Could you please respond to Comment# 10 by verifying on latest stable# 55.0.2883.75 and update the issue which would help us triaging further.
Thanks in Advance.

Comment 17 by geki...@gmail.com, Dec 5 2016

not sure what i should respond to Comment #10
in Comment #10 i can see it and it's still in latest stable and dev
Project Member

Comment 18 by sheriffbot@chromium.org, Dec 12 2016

Labels: -Needs-Feedback Needs-Review
Owner: msrchandra@chromium.org
Thank you for providing more feedback. Adding requester "msrchandra@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: M-57

Comment 20 by sdy@chromium.org, Dec 13 2016

Just to clarify, I *think* I see what this is about. I attached a HiDPI screenshot — there's no bug, but the semi-transparent border does make it look like there's a border where the tab overlaps the other tab, and no border where it doesn't. The tab looks thicker where it overlaps the other tab. It's purely a perceptual thing.

To the reporter: does that sound right?
Screen Shot 2016-12-13 at 9.56.23 AM.png
6.2 KB View Download

Comment 21 by sdy@chromium.org, Dec 13 2016

To put it another way, I think this looks more natural from a distance even though it's "wrong" up close (I just shifted the bottom half of the tab over by 1px in an image editor).
Screen Shot 2016-12-13 at 9.56.23 AM_edit.png
6.2 KB View Download

Comment 22 by geki...@gmail.com, Dec 14 2016

yes, this sounds very right!

if it's a "feature" i can live with it, but for me screenshot in comment #21 looks better (but not perfect ... think because of just shifted)

Comment 23 by ajha@chromium.org, Dec 16 2016

Cc: sdy@chromium.org
Labels: -Needs-Review
Owner: ----
Cc'ing sdy@ for update as per C#22.

Comment 24 by sdy@chromium.org, Dec 16 2016

ajha@: I don't have anything to add right now :). I just dropped in to help clarify the issue, I don't work on design (or Windows).

Comment 25 by ajha@chromium.org, Dec 19 2016

Components: -UI UI>Browser>TabStrip
Adding proper bug label for someone from the respective team for more inputs on this.
Status: WontFix (was: Unconfirmed)
This is as intended, although I agree that it's a bit odd as a design (but it's what our visual designer wanted).

The main issue here is that a single semitransparent stroke appears like a "border" or a "shadow" depending on what the relative colors of the foreground and background are.  The main way we are dealing with this is by implementing the engineering needed to avoid an #FFFFFF frame color in incognito windows by default on Win 10, since in that case, you're kind of screwed no matter what.

The proposal in comment 21 effectively separates things into a "border region" (only drawn where tabs overlap) and a "shadow region" (only drawn where they don't) that's physically outside it.  This looks OK in high DPI, but I suspect not as good in 1x, where it would make the tab borders feel thicker (if the border was drawn everywhere) or the two feel disconnected (if not).

Sign in to add a comment