REGRESSION: style issue with active tab on top tab-bar
Reported by
geki...@gmail.com,
Aug 22 2016
|
||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2832.2 Safari/537.36 Steps to reproduce the problem: 1. i tested it with a incognito window and 3 tabs 2. 3. What is the expected behavior? What went wrong? it doesn't look ok ... see screenshot Did this work before? Yes think with the dev before it was ok (but not sure) Chrome version: 54.0.2832.2 Channel: dev OS Version: 10.0 Flash Version: Shockwave Flash 23.0 r0
,
Aug 23 2016
see the red circle in the screenshot ... for me it looks like the cant of the active tab has a nice bold line when it overlaps the inactive tab but not when it doesn't overlap if you say it's ok it could also be ok
,
Aug 30 2016
Thank you for providing more feedback. Adding requester "msrchandra@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 6 2016
@geki007 -- Tested the issue again on Chrome Dev# 54.0.2840.8 on Windows and could not observe anything as mentioned in the screenshot. Could you please let us know whether there was any specific theme installed. Thanks in Advance.
,
Sep 6 2016
sry i'm not good in painting but i try it again for me it looks like the blue line i painted should be there if you still don't see it ... i think i'm the problem and you can close the bug :) no theme, just incognito window
,
Sep 7 2016
Are you talking about the tab border that was intentionally added in an effort to visually separate tab strip and the window frame more on darkish themes, implemented in issue 585470 ?
,
Sep 7 2016
i'm not sure if it's the same ... but yes talking about the border i just think there is no border or a ~1px bad positioned border where i painted the blue line
,
Sep 7 2016
the border looks different where it overlaps another tab
,
Sep 8 2016
,
Sep 12 2016
Attaching the screenshot by checking on Chrome Dev# 55.0.2853.0 and Chrome Canary# 55.0.2858.0. Could some one from incognito team please look into the issue and update. Thanks in Advance. Note: Removing Needs Bisect label as of now.
,
Sep 19 2016
Thank you for providing more feedback. Adding requester "msrchandra@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 19 2016
,
Nov 10 2016
do you need feedback from me?
,
Nov 17 2016
Thank you for providing more feedback. Adding requester "msrchandra@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 5 2016
@geki007 -- Could you please respond to Comment# 10 by verifying on latest stable# 55.0.2883.75 and update the issue which would help us triaging further. Thanks in Advance.
,
Dec 5 2016
not sure what i should respond to Comment #10 in Comment #10 i can see it and it's still in latest stable and dev
,
Dec 12 2016
Thank you for providing more feedback. Adding requester "msrchandra@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 13 2016
,
Dec 13 2016
Just to clarify, I *think* I see what this is about. I attached a HiDPI screenshot — there's no bug, but the semi-transparent border does make it look like there's a border where the tab overlaps the other tab, and no border where it doesn't. The tab looks thicker where it overlaps the other tab. It's purely a perceptual thing. To the reporter: does that sound right?
,
Dec 13 2016
To put it another way, I think this looks more natural from a distance even though it's "wrong" up close (I just shifted the bottom half of the tab over by 1px in an image editor).
,
Dec 14 2016
yes, this sounds very right! if it's a "feature" i can live with it, but for me screenshot in comment #21 looks better (but not perfect ... think because of just shifted)
,
Dec 16 2016
Cc'ing sdy@ for update as per C#22.
,
Dec 16 2016
ajha@: I don't have anything to add right now :). I just dropped in to help clarify the issue, I don't work on design (or Windows).
,
Dec 19 2016
Adding proper bug label for someone from the respective team for more inputs on this.
,
Dec 19 2016
This is as intended, although I agree that it's a bit odd as a design (but it's what our visual designer wanted). The main issue here is that a single semitransparent stroke appears like a "border" or a "shadow" depending on what the relative colors of the foreground and background are. The main way we are dealing with this is by implementing the engineering needed to avoid an #FFFFFF frame color in incognito windows by default on Win 10, since in that case, you're kind of screwed no matter what. The proposal in comment 21 effectively separates things into a "border region" (only drawn where tabs overlap) and a "shadow region" (only drawn where they don't) that's physically outside it. This looks OK in high DPI, but I suspect not as good in 1x, where it would make the tab borders feel thicker (if the border was drawn everywhere) or the two feel disconnected (if not). |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by msrchandra@chromium.org
, Aug 23 2016Labels: Needs-Feedback