New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639757 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

5.4%-123.3% regression in tab_switching.top_10 at 413328:413336

Project Member Reported by oth@chromium.org, Aug 22 2016

Issue description

See the link to graphs below.
 
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Aug 22 2016


===== BISECT JOB RESULTS =====
Status: completed


===== TESTED REVISIONS =====
Revision                             Mean     Std Dev   N  Good?
chromium@413333                      11.3851  5.94208   8  good
chromium@413333,catapult@8fdfb52f84  10.3146  1.464     5  good
chromium@413333,catapult@0389892bfa  9.77687  0.389629  5  good
chromium@413334                      25.2469  8.19968   8  bad
chromium@413335                      21.6688  1.84853   8  bad

Bisect job ran on: mac_10_10_perf_bisect
Bug ID: 639757

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests tab_switching.top_10
Test Metric: energy_consumption_mwh/energy_consumption_mwh
Relative Change: 76.26%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_10_10_perf_bisect/builds/2320
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9003644084326152496


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5314774057877504

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Comment 5 by oth@chromium.org, Aug 22 2016

Marked this bisect as bad as the output is not actionable (?). Sheriff documentation needs pointers on how to convert revision identifiers to changelists and owners. Will have to seek help to proceed.

Comment 6 by oth@chromium.org, Aug 22 2016

Status: Fixed (was: Assigned)
Appears to have reverted to baseline in chromium@413404 - chromium@413410.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Aug 22 2016


===== BISECT JOB RESULTS =====
Status: completed


===== TESTED REVISIONS =====
Revision                             Mean     Std Dev  N  Good?
chromium@413328                      35.0135  2.22422  5  good
chromium@413332                      35.6827  2.28799  5  good
chromium@413333                      34.9875  1.82224  5  good
chromium@413333,catapult@8fdfb52f84  34.8684  1.59332  5  good
chromium@413333,catapult@0389892bfa  35.0273  1.90013  5  good
chromium@413334                      42.5374  1.65837  5  bad
chromium@413335                      42.8756  1.76816  5  bad

Bisect job ran on: mac_retina_perf_bisect
Bug ID: 639757

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --upload-results --also-run-disabled-tests tab_switching.tough_energy_cases
Test Metric: energy_consumption_mwh/energy_consumption_mwh
Relative Change: 22.45%
Score: 0

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1597
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9003644015879361136


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5849269852962816

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Cc: robert...@chromium.org nednguyen@chromium.org
Labels: BadBisect
Owner: ----
Status: Available (was: Fixed)
#7 skipped over the last revision in the roll, the issue has been fixed since.

The skipped over revision is: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+/30ce231266c6fb6147bb6df7c56a7eb75c23fccf



It turns out that implicitly initialize network controller
whenever platform instance is created is a bad idea. Although
it's more ergonomic, it hides the responsiblity of call sites
to clean up the network_controller (shutting down
ts_proxy_server).

This CL makes remove implicitly initializing network_controller
and requires call sites to be explicit about doing so & clean
it up when they finish using network_controller.

BUG=catapult:#2584
TBR=sullivan@chromium.org, pmeenan@chromium.org

Review-Url: https://codereview.chromium.org/2265593003


Ned, do you think this regression is related to your change?
Not at all. It should be mostly a no-op.
Status: Fixed (was: Available)
Recovered.

Sign in to add a comment