New issue
Advanced search Search tips

Issue 639751 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1237.5%-5100% regression in browser_tests at 413092:413094

Project Member Reported by brandtr@chromium.org, Aug 22 2016

Issue description

See the link to graphs below.
 
Cc: brandtr@chromium.org
Owner: nisse@chromium.org
Hey nisse@, we are seeing some huge performance changes in the 'browser_tests/Max_repeated' metric after your change in https://codereview.chromium.org/2244213002.

Could you have a look?
Added some more alerts to the graphs.
Reduced received frame rate reproduced locally using Hangouts. Receiving side used stable Chrome, whereas sending side was tested using release build of this revision (https://crrev.com/5b9a4b339447b033ca52244a02c0bef17067385f) and the revision before (https://crrev.com/fce0b57ea91c0bbb263601906caf389ecf41c277).
Cc: hlundin@chromium.org
hlundin@: Some of the alerts in https://bugs.chromium.org/p/chromium/issues/detail?id=639744, e.g. the changes in 'Unique_frames_count', may be related to this one.

Comment 6 by nisse@chromium.org, Aug 22 2016

I've now tried running the tests locally. I get lots of warnings like

[1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp (3680861906110 <= 3680861906110) for incoming frame. Dropping.
[1:14:0822/153830:WARNING:video_capture_input.cc(79)] Same/old NTP timestamp (3680861906042 <= 3680861906042) for incoming frame. Dropping.

I'll revert while investigating.

Comment 7 by nisse@chromium.org, Aug 22 2016

Status: Fixed (was: Assigned)
Issue 639744 has been merged into this issue.

Sign in to add a comment