New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 639737 link

Starred by 2 users
Status: Fixed
Owner:
█ warx@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Regression: Warning message of the user profile is not seen on second instance.

Reported by dmascare...@etouch.net, Aug 22 2016 
Version: 54.0.2836.0 (Official Build)Revision5916d5e380c5a9da48673de99d40267507d46f34-refs/heads/master@{#413363} (32/64-bit)
OS: Windows (7,8,10), Mac (10.10.5, 10.11.5)

Pre-condition: Sign- in to browser with valid credentials.

What steps will reproduce the problem?
1. Launch chrome and click on 'Avatar' icon, select 'Switch person' option.
2. Click on arrow icon of the profile and then click on 'Remove this person such that "Warning message of the user profile" is seen.
3. Close the switch person overlay and repeat the above step.
4. Observe the "Warning message".

Actual:Warning message of the user profile is not seen on second instance.
Expected: Warning message of the user profile should be seen on second instance.

This is regression issue, broken in 'M54' and will soon update the bisect info.

Comment 1 by dmascare...@etouch.net, Aug 22 2016

Labels: hasbisect OS-Linux
Owner: warx@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/244a16046a4ffa8b9e0ec6b8a3ae79f4f74475cb..21f9b1fc35bfaab1d900d8c5fde3beb2a8eebdd8?pretty=fuller&n=1000

Suspecting: r413160

Good build:54.0.2833.0 
Bad build:54.0.2834.0 

Note: Issue is seen on Linux Os also.
user.png
64.3 KB View Download
Actual_profile.mp4
792 KB View Download

Comment 2 by ranjitkan@chromium.org, Aug 22 2016

Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.

Comment 3 by warx@chromium.org, Aug 22 2016 

Yes. That should be caused by my last CL. I will look into it.
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e900d297b6885a43b49fd61918eda4445315381

commit 7e900d297b6885a43b49fd61918eda4445315381
Author: warx <warx@chromium.org>
Date: Wed Aug 24 03:53:29 2016

Fix warning message of the user profile is not seen on second instance

In my cl: https://codereview.chromium.org/2258043002/, I combined updating
removing warning message for both desktopUser and non-owner User into one
function. However, for desktopUser build, it is done in a callback. To isolate
these two platform warning message updates, the updating removing warning
message function is divided into two functions.

BUG= 639737 
TEST=tested on both browser build and chromeOS build, the bug is fixed.

Review-Url: https://codereview.chromium.org/2265133003
Cr-Commit-Position: refs/heads/master@{#413974}

[modify] https://crrev.com/7e900d297b6885a43b49fd61918eda4445315381/chrome/app/generated_resources.grd
[modify] https://crrev.com/7e900d297b6885a43b49fd61918eda4445315381/ui/login/account_picker/user_pod_row.js

Comment 5 by warx@chromium.org, Aug 24 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment