New issue
Advanced search Search tips

Issue 639706 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Today
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Chrome
Pri: 1
Type: ----



Sign in to add a comment

BackgroundTracingManagerBrowserTest.* are flaky

Project Member Reported by tasak@google.com, Aug 22 2016

Issue description

BackgroundTracingManagerBrowserTest.CrashWhenSubprocessWithoutArgumentFilter is falky on Android
(content_browsertests on Android)

Failing builders:
Android Tests: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests


 
Project Member

Comment 1 by sheriffbot@chromium.org, Aug 22 2016

Labels: Hotlist-Google

Comment 2 by joh...@chromium.org, Aug 25 2016

Cc: oysteine@chromium.org simonhatch@chromium.org

Comment 3 by joh...@chromium.org, Aug 25 2016

Some of the others may also be flaky on Android Tests:
BackgroundTracingManagerBrowserTest.ReactiveSecondTriggerIgnored failed at:
[30897, 30899]
BackgroundTracingManagerBrowserTest.ReceiveTraceFinalContentsOnTrigger failed at:
[30922, 30933]
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/359659b88aea3ee465b5360151176626de554fe1

commit 359659b88aea3ee465b5360151176626de554fe1
Author: johnme <johnme@chromium.org>
Date: Thu Aug 25 14:39:47 2016

Mark BackgroundTracingManagerBrowserTest test flaky

BackgroundTracingManagerBrowserTest.CrashWhenSubprocessWithoutArgumentFilter
is flaky on android.

It failed at builds [30767, 30786, 30834, 30835, 30843, 30851, 30868, 30909,
30910, 30919, 30923] of
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests
amongst other failures.

NOTREECHECKS=true
NOTRY=true
BUG= 639706 
TBR=simonhatch@chromium.org

Review-Url: https://codereview.chromium.org/2272293003
Cr-Commit-Position: refs/heads/master@{#414433}

[modify] https://crrev.com/359659b88aea3ee465b5360151176626de554fe1/content/browser/tracing/background_tracing_manager_browsertest.cc

Comment 5 by joh...@chromium.org, Aug 26 2016

Labels: -Pri-2 OS-Chrome OS-Linux Pri-1
Summary: BackgroundTracingManagerBrowserTest.* are flaky (was: BackgroundTracingManagerBrowserTest.CrashWhenSubprocessWithoutArgumentFilter is flaky)
Actually, all BackgroundTracingManagerBrowserTest tests are flaky on Android.
CrashWhenSubprocessWithoutArgumentFilter is additionally flaky on Linux.
NoWhitelistedArgsStripped and TraceMetadataInTrace are additionally flaky on Chrome OS.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=BackgroundTracingManagerBrowserTest
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5542e7e0fc92d0e22f5a9cbd49263f562657fcee

commit 5542e7e0fc92d0e22f5a9cbd49263f562657fcee
Author: johnme <johnme@chromium.org>
Date: Fri Aug 26 13:17:30 2016

Mark more of BackgroundTracingManagerBrowserTest flaky

Based on the flakiness dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=BackgroundTracingManagerBrowserTest

- All tests BackgroundTracingManagerBrowserTest tests are flaky on Android

- BackgroundTracingManagerBrowserTest.CrashWhenSubprocessWithoutArgumentFilter
  is flaky on Android & Linux

- BackgroundTracingManagerBrowserTest.NoWhitelistedArgsStripped
  and BackgroundTracingManagerBrowserTest.TraceMetadataInTrace
  are flaky on Android & Chrome OS

NOTREECHECKS=true
NOTRY=true
BUG= 639706 
TBR=simonhatch@chromium.org

Review-Url: https://codereview.chromium.org/2280073002
Cr-Commit-Position: refs/heads/master@{#414697}

[modify] https://crrev.com/5542e7e0fc92d0e22f5a9cbd49263f562657fcee/content/browser/tracing/background_tracing_manager_browsertest.cc

 Issue 643415  has been merged into this issue.
Owner: oysteine@chromium.org
Status: Assigned (was: Available)
Assigning to oysteine@ since he is the author of the CrashWhenSubprocessWithoutArgumentFilter test.
Project Member

Comment 9 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12555044cc96932286e795bb28688c1d4c8a50ee

commit 12555044cc96932286e795bb28688c1d4c8a50ee
Author: magjed <magjed@chromium.org>
Date: Fri Sep 02 10:07:09 2016

Disable CrashWhenSubprocessWithoutArgumentFilter test

The test is flaky. It fails with:
[ RUN      ] BackgroundTracingManagerBrowserTest.CrashWhenSubprocessWithoutArgumentFilter
[5372:5704:0831/163159:16024204:FATAL:trace_log.cc(1091)] Check failed: !argument_filter_predicate_.is_null().

Backtrace:
	base::debug::StackTrace::StackTrace [0x02022B17+23]
	logging::LogMessage::~LogMessage [0x01FCA911+49]
	base::trace_event::TraceLog::FinishFlush [0x01FF104F+255]
	base::internal::Invoker<base::internal::BindState<void (__thiscall base::trace_event::TraceLog::*)(int,bool),base::internal::UnretainedWrapper<base::trace_event::TraceLog>,int,bool>,void __cdecl(void)>::Run [0x01FF2B06+22]
	base::debug::TaskAnnotator::RunTask [0x0203EF90+256]
	base::MessageLoop::RunTask [0x01FE101B+1211]
	base::MessageLoop::DoWork [0x01FE034E+606]
	base::MessagePumpForIO::DoRunLoop [0x02033FBC+188]
	base::MessagePumpWin::Run [0x02034DCA+74]
	base::MessageLoop::RunHandler [0x01FE0B57+103]
	base::RunLoop::Run [0x01FDCEA9+41]
	base::Thread::Run [0x020133AC+92]
	base::Thread::ThreadMain [0x02013D55+469]
	base::PlatformThread::Sleep [0x01FDE9C2+290]
	BaseThreadInitThunk [0x7693338A+18]
	RtlInitializeExceptionChain [0x772B9F72+99]
	RtlInitializeExceptionChain [0x772B9F45+54]

TBR=oysteine@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG= chromium:639706 ,  chromium:639706 

Review-Url: https://codereview.chromium.org/2307813002
Cr-Commit-Position: refs/heads/master@{#416229}

[modify] https://crrev.com/12555044cc96932286e795bb28688c1d4c8a50ee/content/browser/tracing/background_tracing_manager_browsertest.cc

Looking into this, but the renderer crash in #9 is the intended behavior.
Components: -Platform>DevTools>Tracing Speed>Tracing
TraceMetadataInTrace also flaky on linux_chromium_rel_ng:

https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQwsSBUZsYWtlIjhCYWNrZ3JvdW5kVHJhY2luZ01hbmFnZXJCcm93c2VyVGVzdC5UcmFjZU1ldGFkYXRhSW5UcmFjZQw

[ RUN      ] BackgroundTracingManagerBrowserTest.TraceMetadataInTrace
Xlib:  extension "RANDR" missing on display ":99".

DevTools listening on ws://127.0.0.1:53515/devtools/browser/328d17b1-f80c-46f4-9147-ccd9168c4650
Fontconfig warning: "/etc/fonts/fonts.conf", line 146: blank doesn't take any effect anymore. please remove it from your fonts.conf
../../content/browser/tracing/background_tracing_manager_browsertest.cc:434: Failure
Value of: upload_config_wrapper.TraceHasMatchingString("cpu-brand")
  Actual: false
Expected: true
../../content/browser/tracing/background_tracing_manager_browsertest.cc:435: Failure
Value of: upload_config_wrapper.TraceHasMatchingString("network-type")
  Actual: false
Expected: true
../../content/browser/tracing/background_tracing_manager_browsertest.cc:436: Failure
Value of: upload_config_wrapper.TraceHasMatchingString("user-agent")
  Actual: false
Expected: true
[1853:1853:1218/121952.118610:WARNING:gpu_info.cc(104)] No active GPU found, returning primary GPU.
[1797:1847:1218/121952.122172:ERROR:browser_gpu_channel_host_factory.cc(121)] Failed to launch GPU process.
[  FAILED  ] BackgroundTracingManagerBrowserTest.TraceMetadataInTrace, where TypeParam =  and GetParam() =  (142 ms)
 Issue 795893  has been merged into this issue.
Owner: etienneb@chromium.org
BackgroundTracingManagerBrowserTest.ReceiveTraceFailsOnLowerHistogramSample is failing:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20TSan%20Tests/31066
Fixes just landed.
Let keep eyes on this.

Comment 18 by etienneb@chromium.org, Today (15 hours ago)

Status: Fixed (was: Assigned)
closing. This is fixed.
Ping me if anything got broken again.

Comment 19 by oysteine@google.com, Today (14 hours ago)

\o/!

Sign in to add a comment