Regression: Toolbar is completely hidden, when focus is on Omnibox or the mousecursor is over the toolbars |
|||||||
Issue descriptionVersion: Chrome 54.0.2833.0 canary (64-bit) OS: 10.11.6 What steps will reproduce the problem? (1) Switch into Fullscreen (2) Disable showing Toolbars in fullscreen (3) Click into the Omnibox to focus it or mouseover the toolbars (Tabstrip/Omibox/Menubar/Bookmarksbar) What is the expected output? Toolbars should be visible as long as the mousecursor is over the toolbars and/or the Omnibox is focused. What do you see instead? Complete Toolbar is disappearing immediately. Please use labels and text to provide additional information. This seems to be a regression from https://codereview.chromium.org/2256993002 If you need more information, please let me know. Thanks Mehmet
,
Aug 22 2016
Have a working CL. Just need to refactor it
,
Aug 22 2016
,
Aug 26 2016
Friendly ping to get an update on this.
,
Aug 26 2016
CL in review: https://codereview.chromium.org/2272783002/
,
Aug 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e776f9c0602bafaf7ec33d022f543e86c4191a8f commit e776f9c0602bafaf7ec33d022f543e86c4191a8f Author: spqchan <spqchan@chromium.org> Date: Sat Aug 27 10:29:39 2016 [Mac] Fix for fullscreen toolbar Added back mouse tracking to fix an edge case where the menu bar disappears when but the mouse is still hovering the toolbar. The tracking area is only used to keep the toolbar active when this happens. The toolbar will hide when the mouse leaves the tracking area. BUG= 639562 Review-Url: https://codereview.chromium.org/2272783002 Cr-Commit-Position: refs/heads/master@{#414888} [modify] https://crrev.com/e776f9c0602bafaf7ec33d022f543e86c4191a8f/chrome/browser/ui/cocoa/browser_window_controller.h [modify] https://crrev.com/e776f9c0602bafaf7ec33d022f543e86c4191a8f/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/e776f9c0602bafaf7ec33d022f543e86c4191a8f/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm [modify] https://crrev.com/e776f9c0602bafaf7ec33d022f543e86c4191a8f/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/e776f9c0602bafaf7ec33d022f543e86c4191a8f/chrome/browser/ui/cocoa/browser_window_layout.mm [modify] https://crrev.com/e776f9c0602bafaf7ec33d022f543e86c4191a8f/chrome/browser/ui/cocoa/browser_window_layout_unittest.mm [modify] https://crrev.com/e776f9c0602bafaf7ec33d022f543e86c4191a8f/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h [modify] https://crrev.com/e776f9c0602bafaf7ec33d022f543e86c4191a8f/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm
,
Aug 28 2016
spqchan@: Thanks for fixing it latest Canary. I have just two questions: 1.) Is it intended to have approx. 40px tolerance below the toolbar, before the toolbar disappears? 2.) Is it intended, that the Menubar is only visible when you mouseover the Tabstrip, but it is disappearing, when the mouse cursor is moving further down over the Omnibox and Bookmarksbar? (Safari is keeping the Menubar visible until you leave the whole Toolbar incl. Address Bar/Tabstrip/Bookmarks Bar.) If you need more information, please let me know. Thanks Mehmet
,
Aug 29 2016
,
Aug 29 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Aug 29 2016
In regards to comment #7: 1) 20px, not 40px 2) For #2, unfortunately we can't copy Safari's behavior without a LOT of hacks. So yes, it is intended
,
Aug 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f47d14d961ef70dea76db3e01527783158a2f36a commit f47d14d961ef70dea76db3e01527783158a2f36a Author: spqchan <spqchan@chromium.org> Date: Mon Aug 29 17:07:27 2016 [Mac] Fix for fullscreen toolbar Added back mouse tracking to fix an edge case where the menu bar disappears when but the mouse is still hovering the toolbar. The tracking area is only used to keep the toolbar active when this happens. The toolbar will hide when the mouse leaves the tracking area. BUG= 639562 Review-Url: https://codereview.chromium.org/2272783002 Cr-Commit-Position: refs/heads/master@{#414888} (cherry picked from commit e776f9c0602bafaf7ec33d022f543e86c4191a8f) Review URL: https://codereview.chromium.org/2285323002 . Cr-Commit-Position: refs/branch-heads/2840@{#18} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/f47d14d961ef70dea76db3e01527783158a2f36a/chrome/browser/ui/cocoa/browser_window_controller.h [modify] https://crrev.com/f47d14d961ef70dea76db3e01527783158a2f36a/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/f47d14d961ef70dea76db3e01527783158a2f36a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm [modify] https://crrev.com/f47d14d961ef70dea76db3e01527783158a2f36a/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/f47d14d961ef70dea76db3e01527783158a2f36a/chrome/browser/ui/cocoa/browser_window_layout.mm [modify] https://crrev.com/f47d14d961ef70dea76db3e01527783158a2f36a/chrome/browser/ui/cocoa/browser_window_layout_unittest.mm [modify] https://crrev.com/f47d14d961ef70dea76db3e01527783158a2f36a/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h [modify] https://crrev.com/f47d14d961ef70dea76db3e01527783158a2f36a/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm
,
Aug 30 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f47d14d961ef70dea76db3e01527783158a2f36a commit f47d14d961ef70dea76db3e01527783158a2f36a Author: spqchan <spqchan@chromium.org> Date: Mon Aug 29 17:07:27 2016 [Mac] Fix for fullscreen toolbar Added back mouse tracking to fix an edge case where the menu bar disappears when but the mouse is still hovering the toolbar. The tracking area is only used to keep the toolbar active when this happens. The toolbar will hide when the mouse leaves the tracking area. BUG= 639562 Review-Url: https://codereview.chromium.org/2272783002 Cr-Commit-Position: refs/heads/master@{#414888} (cherry picked from commit e776f9c0602bafaf7ec33d022f543e86c4191a8f) Review URL: https://codereview.chromium.org/2285323002 . Cr-Commit-Position: refs/branch-heads/2840@{#18} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/f47d14d961ef70dea76db3e01527783158a2f36a/chrome/browser/ui/cocoa/browser_window_controller.h [modify] https://crrev.com/f47d14d961ef70dea76db3e01527783158a2f36a/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/f47d14d961ef70dea76db3e01527783158a2f36a/chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm [modify] https://crrev.com/f47d14d961ef70dea76db3e01527783158a2f36a/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/f47d14d961ef70dea76db3e01527783158a2f36a/chrome/browser/ui/cocoa/browser_window_layout.mm [modify] https://crrev.com/f47d14d961ef70dea76db3e01527783158a2f36a/chrome/browser/ui/cocoa/browser_window_layout_unittest.mm [modify] https://crrev.com/f47d14d961ef70dea76db3e01527783158a2f36a/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.h [modify] https://crrev.com/f47d14d961ef70dea76db3e01527783158a2f36a/chrome/browser/ui/cocoa/fullscreen_toolbar_controller.mm |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by meh...@chromium.org
, Aug 20 2016