Issue metadata
Sign in to add a comment
|
Composition string window is sometimes misplaced for Japanese IME. |
||||||||||||||||||||||
Issue descriptionVersion: 54.0.2833.0 (Official Build) canary (64-bit) OS: Mac (El Capitan) What steps will reproduce the problem? (1) Open a page with <input> element. (2) Enable Katakana IME (Japanese) (3) Press 'a' 3 times and observer IME composition string window appearing close to the string. (4) Press 'd' and press left arrow. What is the expected output? Drop-down window should appear close to the string. What do you see instead? Drop-down window appears on the bottom-left corner of the screen. This has something to do with enabling/disabling composition range computation.
,
Aug 22 2016
,
Aug 23 2016
,
Aug 25 2016
,
Aug 26 2016
Sorry I haven't noticed. Will take a look soon.
,
Aug 29 2016
Issue 640012 has been merged into this issue.
,
Aug 29 2016
Looks like not reproducible with Linux+mozc, please give a some time. I need to set up OSX for chromium development.
,
Aug 29 2016
Thanks nona@! I poked at it and noticed that setting |monitor_composition_info_| to true in RenderWidget constructor (for Mac) seems to have fixed the issue. But I am not quite certain if that is the right fix. Was this change for composition updates only targeted at Aura?
,
Aug 29 2016
According to Issue 640012 , this is also affecting Windows and Chrome OS.
,
Aug 30 2016
,
Sep 8 2016
ping? If it is unlikely that we can figure out a safe way to fix this issue, I'd recommend reverting https://codereview.chromium.org/2121953002 as soon as possible, before someone starts depending on that change.
,
Sep 8 2016
54 is not yet in beta so we still have a bit of time on this before there's a risk of the bug sticking, but marking RBS to make sure it's not forgotten.
,
Sep 8 2016
If it turns out to be due to my request in codereview to avoid platform ifdefs, ideally I'd like us to stick to the current approach and fix the problem directly, but as a quick fix I'd also tolerate a runtime setting.
,
Sep 8 2016
Removing Windows and Chrome OS labels as Issue 640012 was unduped from this. Let's use this issue for Mac, and use Issue 640012 for Windows/Chrome OS.
,
Sep 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbd66b59cd50bacb823d7aeb6396f32594583fb1 commit fbd66b59cd50bacb823d7aeb6396f32594583fb1 Author: nona <nona@chromium.org> Date: Mon Sep 12 06:10:39 2016 Fix the wrong candidate window on Mac OSX. After http://crrev.com/dac0c7af14c29c9d8509b775d5044e5448b6263b, renderer no longer capturing the composition bounds by default. To receive the latest composition bounds from renderer, we need to update the monitor state and it was done for aura platform in above CL. This CL introduces the similar logic to RWHVM to fix the wrong candidate window issue. BUG= 639552 Review-Url: https://codereview.chromium.org/2296623002 Cr-Commit-Position: refs/heads/master@{#417877} [modify] https://crrev.com/fbd66b59cd50bacb823d7aeb6396f32594583fb1/content/browser/renderer_host/render_widget_host_view_mac.mm
,
Sep 13 2016
Verified this issue on Mac 10.11.6 using chrome dev version #55.0.2859.0 and observed that the fix is working as expected. Attaching screencast for reference. Hence, adding the verified labels.
,
Sep 13 2016
Thank you for verifying the issue. Let me request the merge for the M54.
,
Sep 13 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c0e829d4ed12936c68a34ec918acaf4d9f7c0ef commit 3c0e829d4ed12936c68a34ec918acaf4d9f7c0ef Author: Seigo Nonaka <nona@google.com> Date: Wed Sep 14 05:53:39 2016 Fix the wrong candidate window on Mac OSX. After http://crrev.com/dac0c7af14c29c9d8509b775d5044e5448b6263b, renderer no longer capturing the composition bounds by default. To receive the latest composition bounds from renderer, we need to update the monitor state and it was done for aura platform in above CL. This CL introduces the similar logic to RWHVM to fix the wrong candidate window issue. BUG= 639552 Review-Url: https://codereview.chromium.org/2296623002 Cr-Commit-Position: refs/heads/master@{#417877} (cherry picked from commit fbd66b59cd50bacb823d7aeb6396f32594583fb1) Review URL: https://codereview.chromium.org/2337783004 . Cr-Commit-Position: refs/branch-heads/2840@{#358} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/3c0e829d4ed12936c68a34ec918acaf4d9f7c0ef/content/browser/renderer_host/render_widget_host_view_mac.mm
,
Sep 15 2016
,
Sep 29 2016
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c0e829d4ed12936c68a34ec918acaf4d9f7c0ef commit 3c0e829d4ed12936c68a34ec918acaf4d9f7c0ef Author: Seigo Nonaka <nona@google.com> Date: Wed Sep 14 05:53:39 2016 Fix the wrong candidate window on Mac OSX. After http://crrev.com/dac0c7af14c29c9d8509b775d5044e5448b6263b, renderer no longer capturing the composition bounds by default. To receive the latest composition bounds from renderer, we need to update the monitor state and it was done for aura platform in above CL. This CL introduces the similar logic to RWHVM to fix the wrong candidate window issue. BUG= 639552 Review-Url: https://codereview.chromium.org/2296623002 Cr-Commit-Position: refs/heads/master@{#417877} (cherry picked from commit fbd66b59cd50bacb823d7aeb6396f32594583fb1) Review URL: https://codereview.chromium.org/2337783004 . Cr-Commit-Position: refs/branch-heads/2840@{#358} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/3c0e829d4ed12936c68a34ec918acaf4d9f7c0ef/content/browser/renderer_host/render_widget_host_view_mac.mm |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ekaramad@chromium.org
, Aug 20 2016Status: Assigned (was: Available)