New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639543 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Need menu item ripple for Advance toggle

Project Member Reported by dschuyler@chromium.org, Aug 20 2016

Issue description

In the MD settings side nav menu, the ripple on the Advanced
menu toggle stopped working.

 
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f1e9640dbd205897b8d1b7c714f4eabb6da11b6

commit 4f1e9640dbd205897b8d1b7c714f4eabb6da11b6
Author: dschuyler <dschuyler@chromium.org>
Date: Mon Aug 22 19:56:13 2016

[MD settings] add ripple back to advanced settings menu

This CL re-adds the ripple effect to the Advanced toggle in the side
nav menu.

BUG= 639543 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2261703003
Cr-Commit-Position: refs/heads/master@{#413517}

[modify] https://crrev.com/4f1e9640dbd205897b8d1b7c714f4eabb6da11b6/chrome/browser/resources/settings/settings_menu/settings_menu.html
[modify] https://crrev.com/4f1e9640dbd205897b8d1b7c714f4eabb6da11b6/chrome/browser/resources/settings/settings_menu/settings_menu.js

Status: Fixed (was: Started)

Sign in to add a comment