New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639542 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Findit] Refactor work: move hard coded parameters to config

Project Member Reported by lijeffrey@chromium.org, Aug 20 2016

Issue description

Several hard-coded parameters have been introduced in Findit that can be moved to config.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/b1474528edcca30a7b4bfc7d16e725157bc764cd

commit b1474528edcca30a7b4bfc7d16e725157bc764cd
Author: lijeffrey <lijeffrey@chromium.org>
Date: Fri Aug 26 04:18:26 2016

[Findit] Moving check flake parameters to config

BUG= 639542 

Review-Url: https://codereview.chromium.org/2272953002

[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/handlers/config.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/handlers/test/config_test.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/model/wf_config.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/templates/config.html
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/waterfall/test/trigger_flake_swarming_task_pipeline_test.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/waterfall/test/waterfall_config_test.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/waterfall/test/wf_testcase.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/waterfall/trigger_flake_swarming_task_pipeline.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/waterfall/waterfall_config.py

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 26 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/b1474528edcca30a7b4bfc7d16e725157bc764cd

commit b1474528edcca30a7b4bfc7d16e725157bc764cd
Author: lijeffrey <lijeffrey@chromium.org>
Date: Fri Aug 26 04:18:26 2016

[Findit] Moving check flake parameters to config

BUG= 639542 

Review-Url: https://codereview.chromium.org/2272953002

[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/handlers/config.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/handlers/test/config_test.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/model/wf_config.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/templates/config.html
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/waterfall/flake/recursive_flake_pipeline.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/waterfall/test/trigger_flake_swarming_task_pipeline_test.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/waterfall/test/waterfall_config_test.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/waterfall/test/wf_testcase.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/waterfall/trigger_base_swarming_task_pipeline.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/waterfall/trigger_flake_swarming_task_pipeline.py
[modify] https://crrev.com/b1474528edcca30a7b4bfc7d16e725157bc764cd/appengine/findit/waterfall/waterfall_config.py

Status: Verified (was: Assigned)

Sign in to add a comment