Website doesn't render correctly.
Reported by
andrecar...@gmail.com,
Aug 20 2016
|
||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2824.0 Safari/537.36 Example URL: http://globoesporte.globo.com/ Steps to reproduce the problem: 1. Access globoesporte.com 2. 3. What is the expected behavior? Website should render correctly. What went wrong? Website doesn't render correctly. Does it occur on multiple sites: No Is it a problem with a plugin? No Did this work before? Yes 53.0 Does this work in other browsers? Yes Chrome version: 54.0.2824.0 Channel: dev OS Version: 10.0 Flash Version: Shockwave Flash 22.0 r0 Site renders correctly on other browsers and chrome versions.
,
Sep 8 2016
,
Sep 9 2016
Able to reproduce the issue on Chrome Dev# 54.0.2840.16 on Windows, Mac and Linux. This is a Regression issue in M54. Chrome Good Build# 54.0.2787.0. Chrome Bad Build# 54.0.2788.0. Below are the CL details, You are probably looking for a change made after 403629 (known good), but no later than 403630 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/f98d7fcfb80a98dea5492ae30d463aae43538072..30869b3a11a19398108e1ba1254858f3fcc735ca From the above provided CL, suspecting to the concern owner, Suspected Commit# Suspected Review URL# @dominicc -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to the concern owner. Thank You.
,
Sep 13 2016
,
Sep 15 2016
This looks like a pretty bad rendering regression that has not yet hit stable (perhaps more site are similarly broken)? Given that the per-revision bisect points pretty conclusively to r403630, reverting or fixing it should probably be a M54 release blocker.
,
Sep 16 2016
This issue is marked as Release Block Stable, M54 early stable is scheduled on the first week of October, please plan a fix accordingly.
,
Sep 23 2016
Still able to repro this issue on Google Chrome Latest Beta (54.0.2840.34) & Canary (55.0.2868.1) channels. Tested on Windows 7 & MAC (10.11.6)
,
Sep 26 2016
Gentle ping ,please revert the patch ASAP.
,
Sep 27 2016
I've done a manual rollout in https://codereview.chromium.org/2366203006 . I will reopen the original bug. We should merge this, or roll out r403630 on the branch, depending on what's on the branch.
,
Sep 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a454415188221d203662987d887c4ab70a2a877 commit 6a454415188221d203662987d887c4ab70a2a877 Author: dominicc <dominicc@chromium.org> Date: Tue Sep 27 12:02:15 2016 Revert r403630 which broke parsing on some sites. HTMLTreeBuilderSimulator needs to line up with HTML parsing. r403630 tried to bring them closer together, but this regressed some existing sites. This should be relanded but it needs to make the parser and simulator more reliably consistent. BUG=542803, 639541 Review-Url: https://codereview.chromium.org/2366203006 Cr-Commit-Position: refs/heads/master@{#421177} [modify] https://crrev.com/6a454415188221d203662987d887c4ab70a2a877/third_party/WebKit/LayoutTests/fast/parser/comment-in-title-expected.txt [modify] https://crrev.com/6a454415188221d203662987d887c4ab70a2a877/third_party/WebKit/LayoutTests/fast/parser/comment-in-title.html [modify] https://crrev.com/6a454415188221d203662987d887c4ab70a2a877/third_party/WebKit/Source/core/BUILD.gn [modify] https://crrev.com/6a454415188221d203662987d887c4ab70a2a877/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp [modify] https://crrev.com/6a454415188221d203662987d887c4ab70a2a877/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h [delete] https://crrev.com/c9b85a7b27cf9a07ce120b8e5303ab7672c83fb1/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp
,
Sep 28 2016
,
Sep 28 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Sep 28 2016
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b2166eee42a2936e0653929afb2595d614288fb commit 5b2166eee42a2936e0653929afb2595d614288fb Author: Dominic Cooney <dominicc@chromium.org> Date: Wed Sep 28 02:25:20 2016 Revert r403630 which broke parsing on some sites. HTMLTreeBuilderSimulator needs to line up with HTML parsing. r403630 tried to bring them closer together, but this regressed some existing sites. This should be relanded but it needs to make the parser and simulator more reliably consistent. BUG=542803, 639541 Review-Url: https://codereview.chromium.org/2366203006 Cr-Commit-Position: refs/heads/master@{#421177} (cherry picked from commit 6a454415188221d203662987d887c4ab70a2a877) Review URL: https://codereview.chromium.org/2380513002 . Cr-Commit-Position: refs/branch-heads/2840@{#559} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/5b2166eee42a2936e0653929afb2595d614288fb/third_party/WebKit/LayoutTests/fast/parser/comment-in-title-expected.txt [modify] https://crrev.com/5b2166eee42a2936e0653929afb2595d614288fb/third_party/WebKit/LayoutTests/fast/parser/comment-in-title.html [modify] https://crrev.com/5b2166eee42a2936e0653929afb2595d614288fb/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp [modify] https://crrev.com/5b2166eee42a2936e0653929afb2595d614288fb/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h [delete] https://crrev.com/cc8b385b71fb370ba75d615a6d7d7d1b533622a1/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp
,
Sep 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6be54e9098c6f7b3ed90d927093619efafaab0eb commit 6be54e9098c6f7b3ed90d927093619efafaab0eb Author: jwd <jwd@chromium.org> Date: Wed Sep 28 19:41:03 2016 Revert of Revert r403630 which broke parsing on some sites. (patchset #1 id:1 of https://codereview.chromium.org/2380513002/ ) Reason for revert: BUILD.gn change missing from this merge, causing breakage on the Beta builders https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/precise64%20beta/builds/4150 ERROR at //testing/test.gni:271:5: Source file not found. executable(target_name) { ^------------------------ The target: //third_party/WebKit/Source/web:webkit_unit_tests has a source file: //third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp Original issue's description: > Revert r403630 which broke parsing on some sites. > > HTMLTreeBuilderSimulator needs to line up with HTML parsing. r403630 > tried to bring them closer together, but this regressed some existing > sites. This should be relanded but it needs to make the parser and > simulator more reliably consistent. > > BUG=542803, 639541 > > Review-Url: https://codereview.chromium.org/2366203006 > Cr-Commit-Position: refs/heads/master@{#421177} > (cherry picked from commit 6a454415188221d203662987d887c4ab70a2a877) > > Committed: https://chromium.googlesource.com/chromium/src/+/5b2166eee42a2936e0653929afb2595d614288fb TBR=dominicc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=542803, 639541 Review-Url: https://codereview.chromium.org/2382523002 Cr-Commit-Position: refs/branch-heads/2840@{#567} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/6be54e9098c6f7b3ed90d927093619efafaab0eb/third_party/WebKit/LayoutTests/fast/parser/comment-in-title-expected.txt [modify] https://crrev.com/6be54e9098c6f7b3ed90d927093619efafaab0eb/third_party/WebKit/LayoutTests/fast/parser/comment-in-title.html [modify] https://crrev.com/6be54e9098c6f7b3ed90d927093619efafaab0eb/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp [modify] https://crrev.com/6be54e9098c6f7b3ed90d927093619efafaab0eb/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h [add] https://crrev.com/6be54e9098c6f7b3ed90d927093619efafaab0eb/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca0779373e8e350e84eb006ead1baea7957405bb commit ca0779373e8e350e84eb006ead1baea7957405bb Author: Dominic Cooney <dominicc@chromium.org> Date: Thu Sep 29 06:59:04 2016 Revert "Make HTML tree builder simulator switch modes at HTML integration points" This reverts commit 30869b3a11a19398108e1ba1254858f3fcc735ca. This is a "manual" (per git drover --help) revert of r403630. Drover can't merge the ToT revert at 6a454415188221d203662987d887c4ab70a2a877 because of the switch from gypi to BUILD.gn files. I tried using drover in refs/branch-heads/2840@{#559} which was rolled out in #567 because it broke the official builders. R=jwd@chromium.org BUG=542803, 639541 Review URL: https://codereview.chromium.org/2379943002 . Cr-Commit-Position: refs/branch-heads/2840@{#574} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/ca0779373e8e350e84eb006ead1baea7957405bb/third_party/WebKit/LayoutTests/fast/parser/comment-in-title-expected.txt [modify] https://crrev.com/ca0779373e8e350e84eb006ead1baea7957405bb/third_party/WebKit/LayoutTests/fast/parser/comment-in-title.html [modify] https://crrev.com/ca0779373e8e350e84eb006ead1baea7957405bb/third_party/WebKit/Source/core/core.gypi [modify] https://crrev.com/ca0779373e8e350e84eb006ead1baea7957405bb/third_party/WebKit/Source/core/html/parser/HTMLTokenizer.h [modify] https://crrev.com/ca0779373e8e350e84eb006ead1baea7957405bb/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp [modify] https://crrev.com/ca0779373e8e350e84eb006ead1baea7957405bb/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h [delete] https://crrev.com/be9ef3164c59aa7ffb2c3b90d3561c29fdd8a8ff/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp
,
Sep 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3efc96eb9fed38e73e50b5aac8ff25a1463836e commit b3efc96eb9fed38e73e50b5aac8ff25a1463836e Author: Dominic Cooney <dominicc@chromium.org> Date: Thu Sep 29 07:12:53 2016 Export HTMLTokenizer after ca0779373e8e350e84eb006ead1baea7957405bb. HTMLTokenizerTest added in r404150 depends on the CORE_EXPORT of HTMLTokenizer in r403630 that I'm trying to roll out in ca0779373e8e350e84eb006ead1baea7957405bb. R=jwd@chromium.org BUG=542803, 639541 Review URL: https://codereview.chromium.org/2379963002 . Cr-Commit-Position: refs/branch-heads/2840@{#576} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/b3efc96eb9fed38e73e50b5aac8ff25a1463836e/third_party/WebKit/Source/core/html/parser/HTMLTokenizer.h
,
Sep 29 2016
,
Sep 29 2016
Tested the issue on Chrome Canary# 55.0.2875.0 on Windows, Mac and Linux and is working without any rendering issue. Attaching screenshot for reference. Thank You.
,
Sep 29 2016
,
Oct 5 2016
Tested the issue on Chrome Beta# 54.0.2840.50 on Windows, Mac and Linux and is working without any rendering issue. Hence adding TE-Verified Labels. Attaching screenshot for reference. Thank You.
,
Oct 6 2016
Issue 653326 has been merged into this issue.
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b2166eee42a2936e0653929afb2595d614288fb commit 5b2166eee42a2936e0653929afb2595d614288fb Author: Dominic Cooney <dominicc@chromium.org> Date: Wed Sep 28 02:25:20 2016 Revert r403630 which broke parsing on some sites. HTMLTreeBuilderSimulator needs to line up with HTML parsing. r403630 tried to bring them closer together, but this regressed some existing sites. This should be relanded but it needs to make the parser and simulator more reliably consistent. BUG=542803, 639541 Review-Url: https://codereview.chromium.org/2366203006 Cr-Commit-Position: refs/heads/master@{#421177} (cherry picked from commit 6a454415188221d203662987d887c4ab70a2a877) Review URL: https://codereview.chromium.org/2380513002 . Cr-Commit-Position: refs/branch-heads/2840@{#559} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/5b2166eee42a2936e0653929afb2595d614288fb/third_party/WebKit/LayoutTests/fast/parser/comment-in-title-expected.txt [modify] https://crrev.com/5b2166eee42a2936e0653929afb2595d614288fb/third_party/WebKit/LayoutTests/fast/parser/comment-in-title.html [modify] https://crrev.com/5b2166eee42a2936e0653929afb2595d614288fb/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp [modify] https://crrev.com/5b2166eee42a2936e0653929afb2595d614288fb/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h [delete] https://crrev.com/cc8b385b71fb370ba75d615a6d7d7d1b533622a1/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6be54e9098c6f7b3ed90d927093619efafaab0eb commit 6be54e9098c6f7b3ed90d927093619efafaab0eb Author: jwd <jwd@chromium.org> Date: Wed Sep 28 19:41:03 2016 Revert of Revert r403630 which broke parsing on some sites. (patchset #1 id:1 of https://codereview.chromium.org/2380513002/ ) Reason for revert: BUILD.gn change missing from this merge, causing breakage on the Beta builders https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/precise64%20beta/builds/4150 ERROR at //testing/test.gni:271:5: Source file not found. executable(target_name) { ^------------------------ The target: //third_party/WebKit/Source/web:webkit_unit_tests has a source file: //third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp Original issue's description: > Revert r403630 which broke parsing on some sites. > > HTMLTreeBuilderSimulator needs to line up with HTML parsing. r403630 > tried to bring them closer together, but this regressed some existing > sites. This should be relanded but it needs to make the parser and > simulator more reliably consistent. > > BUG=542803, 639541 > > Review-Url: https://codereview.chromium.org/2366203006 > Cr-Commit-Position: refs/heads/master@{#421177} > (cherry picked from commit 6a454415188221d203662987d887c4ab70a2a877) > > Committed: https://chromium.googlesource.com/chromium/src/+/5b2166eee42a2936e0653929afb2595d614288fb TBR=dominicc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=542803, 639541 Review-Url: https://codereview.chromium.org/2382523002 Cr-Commit-Position: refs/branch-heads/2840@{#567} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/6be54e9098c6f7b3ed90d927093619efafaab0eb/third_party/WebKit/LayoutTests/fast/parser/comment-in-title-expected.txt [modify] https://crrev.com/6be54e9098c6f7b3ed90d927093619efafaab0eb/third_party/WebKit/LayoutTests/fast/parser/comment-in-title.html [modify] https://crrev.com/6be54e9098c6f7b3ed90d927093619efafaab0eb/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp [modify] https://crrev.com/6be54e9098c6f7b3ed90d927093619efafaab0eb/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h [add] https://crrev.com/6be54e9098c6f7b3ed90d927093619efafaab0eb/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca0779373e8e350e84eb006ead1baea7957405bb commit ca0779373e8e350e84eb006ead1baea7957405bb Author: Dominic Cooney <dominicc@chromium.org> Date: Thu Sep 29 06:59:04 2016 Revert "Make HTML tree builder simulator switch modes at HTML integration points" This reverts commit 30869b3a11a19398108e1ba1254858f3fcc735ca. This is a "manual" (per git drover --help) revert of r403630. Drover can't merge the ToT revert at 6a454415188221d203662987d887c4ab70a2a877 because of the switch from gypi to BUILD.gn files. I tried using drover in refs/branch-heads/2840@{#559} which was rolled out in #567 because it broke the official builders. R=jwd@chromium.org BUG=542803, 639541 Review URL: https://codereview.chromium.org/2379943002 . Cr-Commit-Position: refs/branch-heads/2840@{#574} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/ca0779373e8e350e84eb006ead1baea7957405bb/third_party/WebKit/LayoutTests/fast/parser/comment-in-title-expected.txt [modify] https://crrev.com/ca0779373e8e350e84eb006ead1baea7957405bb/third_party/WebKit/LayoutTests/fast/parser/comment-in-title.html [modify] https://crrev.com/ca0779373e8e350e84eb006ead1baea7957405bb/third_party/WebKit/Source/core/core.gypi [modify] https://crrev.com/ca0779373e8e350e84eb006ead1baea7957405bb/third_party/WebKit/Source/core/html/parser/HTMLTokenizer.h [modify] https://crrev.com/ca0779373e8e350e84eb006ead1baea7957405bb/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.cpp [modify] https://crrev.com/ca0779373e8e350e84eb006ead1baea7957405bb/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulator.h [delete] https://crrev.com/be9ef3164c59aa7ffb2c3b90d3561c29fdd8a8ff/third_party/WebKit/Source/core/html/parser/HTMLTreeBuilderSimulatorTest.cpp
,
Oct 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3efc96eb9fed38e73e50b5aac8ff25a1463836e commit b3efc96eb9fed38e73e50b5aac8ff25a1463836e Author: Dominic Cooney <dominicc@chromium.org> Date: Thu Sep 29 07:12:53 2016 Export HTMLTokenizer after ca0779373e8e350e84eb006ead1baea7957405bb. HTMLTokenizerTest added in r404150 depends on the CORE_EXPORT of HTMLTokenizer in r403630 that I'm trying to roll out in ca0779373e8e350e84eb006ead1baea7957405bb. R=jwd@chromium.org BUG=542803, 639541 Review URL: https://codereview.chromium.org/2379963002 . Cr-Commit-Position: refs/branch-heads/2840@{#576} Cr-Branched-From: 1ae106dbab4bddd85132d5b75c670794311f4c57-refs/heads/master@{#414607} [modify] https://crrev.com/b3efc96eb9fed38e73e50b5aac8ff25a1463836e/third_party/WebKit/Source/core/html/parser/HTMLTokenizer.h |
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by tkonch...@chromium.org
, Aug 22 2016