New issue
Advanced search Search tips

Issue 639539 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug

Blocking:
issue 636655



Sign in to add a comment

The generated extension schemas include unnecessary information

Project Member Reported by rdevlin....@chromium.org, Aug 20 2016

Issue description

We generate extension schemas to avoid things like whitespace, comments, and descriptions, but we can eat a little more of them up.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f7a11754e0362c81d8545e094eb87ee871dd7b4

commit 2f7a11754e0362c81d8545e094eb87ee871dd7b4
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Mon Aug 22 19:05:48 2016

[Extensions] Trim some fat around what we use in generated schemas

The generated extension schemas already omit comments, whitespace, and
descriptions, but we can do more. Specifically, we can also remove
entries for "compiler_options", "nodoc", and "noinline_doc".

BUG= 639539 

Review-Url: https://codereview.chromium.org/2266573003
Cr-Commit-Position: refs/heads/master@{#413499}

[modify] https://crrev.com/2f7a11754e0362c81d8545e094eb87ee871dd7b4/tools/json_schema_compiler/cpp_bundle_generator.py

Status: Fixed (was: Started)

Sign in to add a comment