We'd like to have one recipe for all of these. No more code duplication!
Note previous work in this area to unify chromium.perf, chromium.perf.fyi, and tryserver.chromium.perf ( issue 611484 )
Ok, with that CL landed, we are now still stuck.... :(
Now there's this error:
inflating: out/Release/clang_x64/proto_zero_plugin
inflating: out/Release/clang_x64/icudtl.dat
inflating: out/Release/clang_x64/character_data_generator
inflating: out/Release/clang_x64/android_protoc
inflating: out/Release/.goma_deps
extracting: out/Release/lib_gpu_perftests__library.so.whitelist
inflating: out/Release/args.gn
finishing deferred symbolic links:
out/Release/host_forwarder -> clang_x64/host_forwarder
out/Release/md5sum_bin_host -> clang_x64/md5sum_bin
Traceback (most recent call last):
File "/b/rr/tmpkR5rvC/rw/checkout/scripts/slave/extract_build.py", line 175, in real_main
shutil.move(output_dir, target_build_output_dir)
File "/usr/lib/python2.7/shutil.py", line 302, in move
copy2(src, real_dst)
File "/usr/lib/python2.7/shutil.py", line 130, in copy2
copyfile(src, dst)
File "/usr/lib/python2.7/shutil.py", line 82, in copyfile
with open(src, 'rb') as fsrc:
IOError: [Errno 2] No such file or directory: '/b/c/b/Android_Galaxy_S5_Perf__1_/src/out/full-build-linux'
Moving build from /b/c/b/Android_Galaxy_S5_Perf__1_/src/out/full-build-linux to /b/c/b/Android_Galaxy_S5_Perf__1_/src/out/Release
Failed to extract the build.
step returned non-zero exit code: 1
@@@STEP_EXCEPTION@@@
I don't know why that's failing. My suspicion is that the working directory is incorrect, but it looks basically identical to https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/6539/steps/extract%20build/logs/stdio and https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%281%29/builds/13080/steps/extract%20build/logs/stdio (randomly chosen similar steps).
Ok, it looks like the compile targets are not successfully being set.
Android compile targets are a pain; the AndroidInstrumentationTest class does a lot of this logic. Looks like we'll need to share it with DynamicPerfTests somehow. :/
Also, looks like the device finally died on us :/ starting at page_cycler_v2.typical_25 the device seems to have died. I tried running `adb devices` on the machine, and it timed out. Not sure exactly what to do :/ Galaxy phones are generally pretty flaky, right? So might just have to get labs to restart the phone.
Looks like it's running Telemetry benchmarks and reference benchmarks just fine. That's great! I'm not surprised that some of them are failing, as they often fail on the perf waterfall as well. As long as most of them are passing, I think we're okay.
Other things we'll want to ensure:
- That all the benchmarks are uploading data to the perf dashboard.
- There are additional non-Telemetry tests: gpu_perftests, cc_perftests. We'll want to ensure those run and upload data too. I think you can enable them in eyaich's script:
https://chromium.googlesource.com/chromium/src/+/master/tools/perf/generate_perf_json.py
From what I can tell, the device is pretty flaky, which is what causes these tests to fail. I think. issue 652250 is probably causing a lot of the failures. Just killed adb on it again (I didn't know how to kill the forwarder :( ) and it started running tests again.
I'll enable the gpu_perftests and cc_perftests; I wasn't sure if those needed to run, and i'll make sure they're uploading benchmarks.
An update.
Still not sure if it's correctly uploading data to the perf dashboard. I think it is? But I'm not totally sure. The stdout says that it's uploading data...
gpu_perftests and cc_perftests are now running, as of https://build.chromium.org/p/chromium.perf.fyi/builders/Android%20Galaxy%20S5%20Perf%20%281%29/builds/4802
cc_perftests all failed, although gpu_perftests passed. So not sure if the failures are device flakiness, or what. :/ I'll look at more test runs once this current build has cycled.
I believe we should be ok to start switching bots over to use the chromium recipe. I need to write up a plan, but I believe the rough plan is:
* Make sure we have a chromium recipe builder running on chromium.perf
* Make sure all perf builders have entries in the testing/buildbot json (https://codereview.chromium.org/2408283002 is an example CL)
* Start switching over builders.
We haven't totally merged these in; the resource sizes stuff still needs to be merged.
I'm not directly working on perf anymore though, so marking as Available.
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.
Sorry for the inconvenience if the bug really should have been left as Available.
For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Comment 1 by bugdroid1@chromium.org
, Aug 22 2016