WindowOpenPanelTest.WindowOpenFocus failing on the Site Isolation Win bot |
||
Issue descriptionThe failure has started happening in this build: https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/15757 This test was failing together with ExtensionDialogUiTest.TabFocusLoop, however the latter was also failing on other bots (and tracked in issue 639072 ), whereas WindowOpenPanelTest.WindowOpenFocus is failing only on the Site Isolation Win bot. Still, the two issues could be related. There's nothing obvious in the blamelist (r412822-r412861), and unfortunately I also haven't been able to repro this on a local Windows build. Sample failure output (the test times out after this): [ RUN ] WindowOpenPanelTest.WindowOpenFocus [4792:5068:0818/113635:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! [5896:2156:0818/113635:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! [5604:4908:0818/113635:INFO:CONSOLE(0)] "[SUCCESS] defaultHasFocus", source: chrome-extension://jabbemadebgcpgbgejoceccgpnlpmcnc/test.html (0) [5604:4908:0818/113636:INFO:CONSOLE(0)] "[SUCCESS] defaultHasFocusPopup", source: chrome-extension://jabbemadebgcpgbgejoceccgpnlpmcnc/test.html (0) [5604:4908:0818/113636:INFO:CONSOLE(0)] "[SUCCESS] defaultUnfocusedPanel", source: chrome-extension://jabbemadebgcpgbgejoceccgpnlpmcnc/test.html (0) [5604:4908:0818/113636:INFO:CONSOLE(0)] "[SUCCESS] withFocus", source: chrome-extension://jabbemadebgcpgbgejoceccgpnlpmcnc/test.html (0) [5604:4908:0818/113636:INFO:CONSOLE(0)] "[SUCCESS] withFocusPopup", source: chrome-extension://jabbemadebgcpgbgejoceccgpnlpmcnc/test.html (0) Sample output from my local Windows build, where this test succeeds: [ RUN ] WindowOpenPanelTest.WindowOpenFocus [74380:28556:0819/154359:INFO:CONSOLE(0)] "[SUCCESS] defaultHasFocus", source: chrome-extension://ppdajdknmakogabmgbfbbeddpenjikhp/test.html (0) [74380:28556:0819/154359:INFO:CONSOLE(0)] "[SUCCESS] defaultHasFocusPopup", source: chrome-extension://ppdajdknmakogabmgbfbbeddpenjikhp/test.html (0) [74380:28556:0819/154400:INFO:CONSOLE(0)] "[SUCCESS] defaultUnfocusedPanel", source: chrome-extension://ppdajdknmakogabmgbfbbeddpenjikhp/test.html (0) [74380:28556:0819/154400:INFO:CONSOLE(0)] "[SUCCESS] withFocus", source: chrome-extension://ppdajdknmakogabmgbfbbeddpenjikhp/test.html (0) [74380:28556:0819/154400:INFO:CONSOLE(0)] "[SUCCESS] withFocusPopup", source: chrome-extension://ppdajdknmakogabmgbfbbeddpenjikhp/test.html (0) [74380:28556:0819/154400:INFO:CONSOLE(0)] "[SUCCESS] withFocusPanel", source: chrome-extension://ppdajdknmakogabmgbfbbeddpenjikhp/test.html (0) [74380:28556:0819/154400:INFO:CONSOLE(0)] "[SUCCESS] withoutFocus", source: chrome-extension://ppdajdknmakogabmgbfbbeddpenjikhp/test.html (0) [74380:28556:0819/154401:INFO:CONSOLE(0)] "[SUCCESS] withoutFocusPopup", source: chrome-extension://ppdajdknmakogabmgbfbbeddpenjikhp/test.html (0) [74380:28556:0819/154401:INFO:CONSOLE(0)] "[SUCCESS] withoutFocusPanel", source: chrome-extension://ppdajdknmakogabmgbfbbeddpenjikhp/test.html (0) [74380:28556:0819/154402:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.always_authorize [74380:28556:0819/154402:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown printing.enabled [74380:28556:0819/154402:WARNING:pref_notifier_impl.cc(27)] pref observer found at shutdown plugins.allow_outdated [ OK ] WindowOpenPanelTest.WindowOpenFocus (3559 ms)
,
Aug 22 2016
This could also be related to issue 639350 , which is currently causing flakiness in interactive_ui_tests on Win bots. This failure is very consistent though.
,
Aug 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a98073ac85514395939268f9d71a5d609867d450 commit a98073ac85514395939268f9d71a5d609867d450 Author: lukasza <lukasza@chromium.org> Date: Tue Aug 23 17:27:53 2016 Adding Site Isolation Win bot filtering for WindowOpenPanelTest.WindowOpenFocus. BUG= 639510 Review-Url: https://codereview.chromium.org/2269523003 Cr-Commit-Position: refs/heads/master@{#413773} [modify] https://crrev.com/a98073ac85514395939268f9d71a5d609867d450/testing/buildbot/chromium.fyi.json [add] https://crrev.com/a98073ac85514395939268f9d71a5d609867d450/testing/buildbot/filters/isolate-extensions.interactive_ui_tests.filter
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/92c4a9fcfb32947cc40a9a4e3125d2e1992616f5 commit 92c4a9fcfb32947cc40a9a4e3125d2e1992616f5 Author: lukasza <lukasza@chromium.org> Date: Fri Aug 26 23:37:18 2016 Revert of Adding Site Isolation Win bot filtering for WindowOpenPanelTest.WindowOpenFocus. (patchset #1 id:1 of https://codereview.chromium.org/2269523003/ ) Reason for revert: The filter file is apparently not needed anymore: despite the fact that the test got renamed in r413759, we are not seeing failures in the WindowOpenFocus test in the latest builds on Site Isolation Win bot. Original issue's description: > Adding Site Isolation Win bot filtering for WindowOpenPanelTest.WindowOpenFocus. > > BUG= 639510 > > Committed: https://crrev.com/a98073ac85514395939268f9d71a5d609867d450 > Cr-Commit-Position: refs/heads/master@{#413773} TBR=creis@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= 639510 Review-Url: https://codereview.chromium.org/2287743002 Cr-Commit-Position: refs/heads/master@{#414857} [modify] https://crrev.com/92c4a9fcfb32947cc40a9a4e3125d2e1992616f5/testing/buildbot/chromium.fyi.json [delete] https://crrev.com/be2fa1a7f40f37fb052265b2183b65b3818c6682/testing/buildbot/filters/isolate-extensions.interactive_ui_tests.filter
,
Aug 26 2016
Closing this bug as the test seems to have healed itself :-o At least, there are no failures of this test in the last few builds from https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/15876 to https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Win/builds/15887 |
||
►
Sign in to add a comment |
||
Comment 1 by lukasza@chromium.org
, Aug 22 2016