New issue
Advanced search Search tips

Issue 639477 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Compat



Sign in to add a comment

Add use counters for caseless matching of radio groups and image maps

Project Member Reported by domenic@chromium.org, Aug 19 2016

Issue description

In https://github.com/whatwg/html/issues/1666 we are discussing whether we can remove the spec's use of "compatibility caseless" matching for radio groups and image maps. "Compatibility caseless" is a type of Unicode case-insensitive matching. It turns out that nobody actually implements "compatibility caseless" exactly, but Chrome, Firefox, and Edge all do implement some form of Unicode case-insensitive matching.

WebKit does completely case-sensitive matching for radio groups, but not for image maps.

It would be good to add use counters to see how often Chrome sees radio button names and image map hash names that are deemed "the same", but are not byte-for-byte equal. If this happens rarely, we can just move to case-sensitive matching in the spec and in Chrome, thus matching WebKit and simplifying everything.
 

Comment 1 by tkent@chromium.org, Aug 22 2016

Components: -Blink>HTML
Owner: tkent@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef41af2efc6bff8baf0b9f4872e1cb8809de2072

commit ef41af2efc6bff8baf0b9f4872e1cb8809de2072
Author: tkent <tkent@chromium.org>
Date: Mon Aug 22 21:31:07 2016

Add UseCounters for name attribute matching of <map> and <input type=radio>

https://github.com/whatwg/html/issues/1666
We'd like to know if Unicode caseless matching is really necessary for
them. This CL adds the following counters of cases where:
 - Exact codepoint matching is enough
 - ASCII-caseless matching is enough
 - Otherwise
for each of <map> and <input type=radio>.

BUG= 639477 

Review-Url: https://codereview.chromium.org/2264943002
Cr-Commit-Position: refs/heads/master@{#413538}

[modify] https://crrev.com/ef41af2efc6bff8baf0b9f4872e1cb8809de2072/third_party/WebKit/Source/core/dom/TreeScope.cpp
[modify] https://crrev.com/ef41af2efc6bff8baf0b9f4872e1cb8809de2072/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/ef41af2efc6bff8baf0b9f4872e1cb8809de2072/third_party/WebKit/Source/core/html/forms/RadioButtonGroupScope.cpp
[modify] https://crrev.com/ef41af2efc6bff8baf0b9f4872e1cb8809de2072/tools/metrics/histograms/histograms.xml

Comment 3 by tkent@chromium.org, Aug 22 2016

Labels: M-54
Status: Fixed (was: Started)
Added the following counters:
 - MapNameMatchingStrict
 - MapNameMatchingASCIICaseless
 - MapNameMatchingUnicodeLower
 - RadioNameMatchingStrict
 - RadioNameMatchingASCIICaseless
 - RadioNameMatchingCaseFolding

Comment 4 Deleted

Sign in to add a comment