New issue
Advanced search Search tips

Issue 639451 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-use-after-free in std::__1::__tree_const_iterator<std::__1::__value_type<CFX_ByteString, CPDF_Obje

Project Member Reported by ClusterFuzz, Aug 19 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4749371256340480

Fuzzer: ochang_neurofuzz_borgfuzz
Job Type: linux_asan_pdfium
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x6040000092e8
Crash State:
  std::__1::__tree_const_iterator<std::__1::__value_type<CFX_ByteString, CPDF_Obje
  CPDF_Dictionary::GetDictBy
  CPDF_Document::RetrievePageCount
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_pdfium&range=412760:412915

Minimized Testcase (21.79 Kb): https://cluster-fuzz.appspot.com/download/AMIfv95wuG3tR58pmbiyKW1YhQ9HlvUmGaGadDXbRIu-rgSBaiUVGj8LvjXMrFA1X76EHobiBLozufoAvOkKajPpZZh0Xk_paJQ9hlOmM6ieh1D3FHOYwbssh0GDJoWIJ_eSsXQ72Ju974BAn_XcwvBczH2RBgrPjxmmD-KdKMaHue73zzW4Bmw?testcase_id=4749371256340480

Issue manually filed by: inferno

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Components: Infra>Client>Pdfium
Owner: dsinclair@chromium.org
Status: Assigned (was: Untriaged)
+dsinclair@, could you take a look at this one? Since you're quite active in cpdf related code (and a couple of your CL in the regression range.)
Thanks! 
Project Member

Comment 2 by sheriffbot@chromium.org, Aug 20 2016

Labels: M-54
Project Member

Comment 3 by sheriffbot@chromium.org, Aug 20 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Aug 20 2016

Labels: Pri-1
Status: Started (was: Assigned)
This appears to have been caused by https://codereview.chromium.org/2266033002/ which is being reverted.
Components: -Infra>Client>Pdfium Internals>Plugins>PDF
Status: Fixed (was: Started)
Should be fixed with https://pdfium.googlesource.com/pdfium/+/8d6c929d2605dc568beb73aab2c585622947fee2 which should roll into Chromium soon.
Project Member

Comment 8 by ClusterFuzz, Aug 23 2016

ClusterFuzz has detected this issue as fixed in range 413455:413548.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=4749371256340480

Fuzzer: ochang_neurofuzz_borgfuzz
Job Type: linux_asan_pdfium
Platform Id: linux

Crash Type: Heap-use-after-free READ 8
Crash Address: 0x6040000092e8
Crash State:
  CPDF_Document::RetrievePageCount
  CPDF_Document::LoadDoc
  CPDF_Parser::StartParse
  
Recommended Security Severity: High

Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_pdfium&range=412760:412915
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_pdfium&range=413455:413548

Minimized Testcase (21.79 Kb): https://cluster-fuzz.appspot.com/download/AMIfv97zji36pxOFuqFCgt1uVu9dfne9zCDFb1ONy5gO6Dx3oTFyGZ1ButdWxBBeZcLEntQoqdqXgEmhyxwr_hPE9rIUuu2JAU43oLETNJ4Z-tyKgAUETYjAzzaLDGCUTbCjYSSVDb3xsdTL4-WmBaKFkHE9cs1TgOXhnxMhGOwns_o8cRzCxmA?testcase_id=4749371256340480

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by sheriffbot@chromium.org, Aug 23 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 29 2016

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by ClusterFuzz, Jul 14 2017

Labels: Needs-Feedback
ClusterFuzz testcase 5727537105993728 is still reproducing on tip-of-tree build (trunk).

Please re-test your fix against this testcase and if the fix was incorrect or incomplete, please re-open the bug. Otherwise, ignore this notification and add ClusterFuzz-Wrong label.
Labels: -ReleaseBlock-Beta
Status: Assigned (was: Fixed)
Reopening so we can test if this is still broken ... Removing RB-Beta as this was from M54.
Project Member

Comment 13 by sheriffbot@chromium.org, Jul 18 2017

Labels: -Security_Impact-Head -M-54 Security_Impact-Stable M-59
Project Member

Comment 14 by sheriffbot@chromium.org, Jul 18 2017

Labels: Deadline-Exceeded
We commit ourselves to a 60 day deadline for fixing for high severity vulnerabilities, and have exceeded it here. If you're unable to look into this soon, could you please find another owner or remove yourself so that this gets back into the security triage queue?

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 15 by sheriffbot@chromium.org, Jul 26 2017

Labels: -M-59 M-60
Project Member

Comment 16 by sheriffbot@chromium.org, Aug 1 2017

dsinclair: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Dan, this is now one of the stalest bugs -- can we close this out?
Status: Fixed (was: Assigned)
The clusterfuzz pages says Fixed. Closing.
Project Member

Comment 19 by sheriffbot@chromium.org, Aug 13 2017

Labels: Merge-Request-61
Project Member

Comment 20 by sheriffbot@chromium.org, Aug 13 2017

Labels: -Merge-Request-61 Merge-Review-61 Hotlist-Merge-Review
This bug requires manual review: M61 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), ketakid@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: awhalley@chromium.org
I don't think there is any merge is needed here. 
Also this bug has been exists since M54 reported on August 2016. So even if merge is needed, this can wait until M62. 
+awhalley@, pls double check. Thank you.



Labels: -Hotlist-Merge-Review -Merge-Review-61 Merge-Rejected-61
No 61 merge needed.
Labels: -M-60 M-62
Labels: Release-0-M62

Sign in to add a comment