New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639439 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit 15 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename Previews and LoFi in source

Project Member Reported by bengr@chromium.org, Aug 19 2016

Issue description

Please rename LoFiPreview as LitePagePreview. LoFiPreview is a name that should be used for previews that use the data reduction proxy's LoFi mode.

 
Cc: bengr@chromium.org
Currently in the code we use the following names:
Lo-Fi = server side image replacement
Preview or Lo-Fi Preview = WebLite

Is this suggesting we rename both
Lo-Fi -> LoFiPreview
Preview -> LitePagePreview 
Or just the latter?
Started on this cl. The language gets confusing in some places because previews are enabled by the Lo-Fi trigger. We considered previews a subset of Lo-Fi because of this. Would LoFiLitePage be better? Or should the RenderFrameImpl Lo-Fi boolean be expanded to an enum and we handle the plumbing of Lo-Fi and LitePages separately?
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/778536d860ed092880bdd114e8adee54c7f0dac3

commit 778536d860ed092880bdd114e8adee54c7f0dac3
Author: megjablon <megjablon@chromium.org>
Date: Fri Sep 30 19:49:19 2016

Rename Lo-Fi previews to lite pages

TBR=asvitkine@chromium.org
BUG= 639439 

Review-Url: https://codereview.chromium.org/2296043003
Cr-Commit-Position: refs/heads/master@{#422191}

[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/chrome/android/javatests/src/org/chromium/chrome/browser/TabsOpenedFromExternalAppTest.java
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/chrome/android/javatests/src/org/chromium/chrome/browser/customtabs/CustomTabActivityTest.java
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/chrome/app/generated_resources.grd
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/chrome/browser/about_flags.cc
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/chrome/browser/net/spdyproxy/data_reduction_proxy_settings_android.cc
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/chrome/browser/previews/previews_infobar_tab_helper.cc
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/components/data_reduction_proxy/content/browser/content_lofi_decider.cc
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/components/data_reduction_proxy/content/browser/content_lofi_decider_unittest.cc
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.cc
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate.h
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/components/data_reduction_proxy/core/browser/data_reduction_proxy_network_delegate_unittest.cc
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.cc
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/components/data_reduction_proxy/core/browser/data_reduction_proxy_settings.h
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.cc
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/components/data_reduction_proxy/core/common/data_reduction_proxy_headers.h
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/components/data_reduction_proxy/core/common/data_reduction_proxy_params.h
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.cc
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/components/data_reduction_proxy/core/common/lofi_decider.h
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/tools/chrome_proxy/common/chrome_proxy_metrics.py
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py
[add] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lite_page.py
[delete] https://crrev.com/87ee8b86123d1ecf3f9d458ccf92674d3e7b75fc/tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/lo_fi_preview.py
[modify] https://crrev.com/778536d860ed092880bdd114e8adee54c7f0dac3/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/06da892b412e18d9e19c4cadf817782739d4d942

commit 06da892b412e18d9e19c4cadf817782739d4d942
Author: Megan Jablonski <megjablon@google.com>
Date: Tue Sep 27 00:42:15 2016

Project Member

Comment 5 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/06da892b412e18d9e19c4cadf817782739d4d942

commit 06da892b412e18d9e19c4cadf817782739d4d942
Author: Megan Jablonski <megjablon@google.com>
Date: Tue Sep 27 00:42:15 2016

Status: Fixed (was: Assigned)

Sign in to add a comment