(Most?) EME code on the Chromium side uses GURL for origins. A more reasonable url::Origin is being introduced (issue 490074), and we should use it where we really intend to track the origin and not a URL, which should be everywhere.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9200cb229ebc7a8517faccd74fc2a5b767e1abed commit 9200cb229ebc7a8517faccd74fc2a5b767e1abed Author: John Rummell <jrummell@chromium.org> Date: Wed Aug 30 22:50:51 2017 Use url::Origin rather than GURL for EME origins BUG= 639438 TEST=EME browser_tests pass Change-Id: Ieea762cb77c518412f4c9ee3e8deddb34ff00569 Reviewed-on: https://chromium-review.googlesource.com/639251 Reviewed-by: Luke Halliwell <halliwell@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#498653} [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/chromecast/media/cdm/cast_cdm_factory.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/chromecast/media/cdm/cast_cdm_factory.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/content/renderer/media/cdm/pepper_cdm_wrapper.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/content/renderer/media/cdm/pepper_cdm_wrapper_impl.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/content/renderer/media/cdm/pepper_cdm_wrapper_impl.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/content/renderer/media/cdm/ppapi_decryptor.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/content/renderer/media/cdm/ppapi_decryptor.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/content/renderer/media/cdm/render_cdm_factory.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/content/renderer/media/cdm/render_cdm_factory.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/content/renderer/media/media_factory.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/content/renderer/media/media_factory.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/base/android/android_cdm_factory.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/base/android/android_cdm_factory.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/base/android/media_drm_bridge.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/base/android/media_drm_bridge.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/base/cdm_factory.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/base/mock_filters.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/base/mock_filters.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/blink/cdm_session_adapter.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/blink/cdm_session_adapter.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/blink/webcontentdecryptionmodule_impl.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/cdm/aes_decryptor.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/cdm/aes_decryptor.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/cdm/aes_decryptor_unittest.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/cdm/cdm_adapter_factory.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/cdm/cdm_adapter_factory.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/cdm/default_cdm_factory.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/cdm/default_cdm_factory.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/cdm/ppapi/external_clear_key/clear_key_cdm.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/cdm/ppapi/external_clear_key/clear_key_cdm.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/cdm/ppapi/external_clear_key/clear_key_persistent_session_cdm.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/cdm/ppapi/external_clear_key/clear_key_persistent_session_cdm.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/mojo/clients/mojo_cdm.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/mojo/clients/mojo_cdm.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/mojo/clients/mojo_cdm_factory.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/mojo/clients/mojo_cdm_factory.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/mojo/clients/mojo_cdm_unittest.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/mojo/services/mojo_cdm_service.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/remoting/BUILD.gn [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/remoting/remoting_cdm_factory.cc [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/remoting/remoting_cdm_factory.h [modify] https://crrev.com/9200cb229ebc7a8517faccd74fc2a5b767e1abed/media/test/fake_encrypted_media.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42c963e41aeaa449eea8ca1d882fcf7424e35b4f commit 42c963e41aeaa449eea8ca1d882fcf7424e35b4f Author: John Rummell <jrummell@chromium.org> Date: Wed Sep 06 22:04:32 2017 Use proper mojo class to pass |security_origin| Now that the EME code uses url::Origin, use url.mojom.Origin as the mojo parameter type to avoid conversion issues. BUG= 639438 TEST=updated media_mojo_unittests pass Change-Id: I89bfa0f84a987757dfde222cb6951fcf708fab7e Reviewed-on: https://chromium-review.googlesource.com/644666 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#500107} [modify] https://crrev.com/42c963e41aeaa449eea8ca1d882fcf7424e35b4f/media/base/BUILD.gn [modify] https://crrev.com/42c963e41aeaa449eea8ca1d882fcf7424e35b4f/media/base/mock_filters.cc [modify] https://crrev.com/42c963e41aeaa449eea8ca1d882fcf7424e35b4f/media/base/mock_filters.h [modify] https://crrev.com/42c963e41aeaa449eea8ca1d882fcf7424e35b4f/media/mojo/clients/mojo_cdm.cc [modify] https://crrev.com/42c963e41aeaa449eea8ca1d882fcf7424e35b4f/media/mojo/clients/mojo_cdm_unittest.cc [modify] https://crrev.com/42c963e41aeaa449eea8ca1d882fcf7424e35b4f/media/mojo/clients/mojo_renderer_unittest.cc [modify] https://crrev.com/42c963e41aeaa449eea8ca1d882fcf7424e35b4f/media/mojo/interfaces/content_decryption_module.mojom [modify] https://crrev.com/42c963e41aeaa449eea8ca1d882fcf7424e35b4f/media/mojo/services/media_service_unittest.cc [modify] https://crrev.com/42c963e41aeaa449eea8ca1d882fcf7424e35b4f/media/mojo/services/mojo_cdm_service.cc [modify] https://crrev.com/42c963e41aeaa449eea8ca1d882fcf7424e35b4f/media/mojo/services/mojo_cdm_service.h
jrummell: Is this fixed?
Comment 1 by xhw...@chromium.org
, Mar 3 2017Labels: Hotlist-CodeHealth Hotlist-Fixit
Owner: jrumm...@chromium.org