New issue
Advanced search Search tips

Issue 639416 link

Starred by 1 user
Status: Fixed
Owner:
pwnall@chromium.org
Closed: Sep 2016
Cc:
afakhry@chromium.org
michae...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Remove non-namespaced usage of base::Version

Project Member Reported by pwnall@chromium.org, Aug 19 2016 
We have a "using base::Version;" workaround in base/version.h.
https://cs.chromium.org/chromium/src/base/version.h?q=using+base::Version;&sq=package:chromium&l=78

We have a TODO for removing it. I looked into what it'd take to get the TODO done, and I got a working (but most likely not landable) CL: https://codereview.chromium.org/2256363002/

While looking into it, I saw many files had mixed usage of bare Version and namespaced base::Version. I'm guessing this is from a previous attempt of getting this TODO done.

I intend to break down the CL above into a bunch of smaller CLs that can be reviewed and landed. This bug is intended to tie the CLs together.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db0b7241cb831c1a6cf66494bc0b611f6e80487a

commit db0b7241cb831c1a6cf66494bc0b611f6e80487a
Author: pwnall <pwnall@chromium.org>
Date: Fri Aug 19 21:39:12 2016

Consistently use namespaced base::Version in components/update_client.

BUG= 639416 

Review-Url: https://codereview.chromium.org/2266533002
Cr-Commit-Position: refs/heads/master@{#413249}

[modify] https://crrev.com/db0b7241cb831c1a6cf66494bc0b611f6e80487a/components/update_client/action_update_check.cc
[modify] https://crrev.com/db0b7241cb831c1a6cf66494bc0b611f6e80487a/components/update_client/crx_update_item.h
[modify] https://crrev.com/db0b7241cb831c1a6cf66494bc0b611f6e80487a/components/update_client/test_installer.cc
[modify] https://crrev.com/db0b7241cb831c1a6cf66494bc0b611f6e80487a/components/update_client/test_installer.h
[modify] https://crrev.com/db0b7241cb831c1a6cf66494bc0b611f6e80487a/components/update_client/update_client.cc
[modify] https://crrev.com/db0b7241cb831c1a6cf66494bc0b611f6e80487a/components/update_client/update_client.h
[modify] https://crrev.com/db0b7241cb831c1a6cf66494bc0b611f6e80487a/components/update_client/update_client_internal.h
[modify] https://crrev.com/db0b7241cb831c1a6cf66494bc0b611f6e80487a/components/update_client/update_client_unittest.cc
[modify] https://crrev.com/db0b7241cb831c1a6cf66494bc0b611f6e80487a/components/update_client/update_response.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9484f3a00bf11f6c73b556aed42f21b64cca0c66

commit 9484f3a00bf11f6c73b556aed42f21b64cca0c66
Author: pwnall <pwnall@chromium.org>
Date: Sat Aug 20 00:34:38 2016

Consistently use namespaced base::Version in gpu/ code.

BUG= 639416 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2258273002
Cr-Commit-Position: refs/heads/master@{#413295}

[modify] https://crrev.com/9484f3a00bf11f6c73b556aed42f21b64cca0c66/gpu/config/gpu_info.cc
[modify] https://crrev.com/9484f3a00bf11f6c73b556aed42f21b64cca0c66/gpu/config/gpu_info.h
[modify] https://crrev.com/9484f3a00bf11f6c73b556aed42f21b64cca0c66/gpu/config/gpu_info_collector_win.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbd731923424faa070da2083b59e749003ad8f79

commit cbd731923424faa070da2083b59e749003ad8f79
Author: pwnall <pwnall@chromium.org>
Date: Mon Aug 22 18:59:17 2016

Consistently use namespaced base::Version in extensions code.

BUG= 639416 

Review-Url: https://codereview.chromium.org/2259383002
Cr-Commit-Position: refs/heads/master@{#413496}

[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/api/runtime/chrome_runtime_api_delegate.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/chrome_extensions_browser_client.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/extension_management_internal.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/extension_service.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/extension_service_unittest.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/extension_sync_data.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/extension_sync_data_unittest.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/external_policy_loader_unittest.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/external_provider_impl.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/external_registry_loader_win.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/pending_extension_info.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/pending_extension_info.h
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/pending_extension_manager.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/unpacked_installer.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/updater/extension_updater_unittest.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/updater/local_extension_cache.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/webstore_installer.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/browser/extensions/webstore_installer.h
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/extensions/browser/api/runtime/runtime_api.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/extensions/browser/updater/extension_downloader.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/extensions/browser/updater/update_service.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/extensions/browser/updater/update_service_unittest.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/extensions/browser/user_script_loader.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/extensions/common/extension.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/extensions/common/manifest_handlers/shared_module_info.cc
[modify] https://crrev.com/cbd731923424faa070da2083b59e749003ad8f79/extensions/common/update_manifest.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 22 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c3f931d06d184b5c2c7363bbd72ee00772fe6c76

commit c3f931d06d184b5c2c7363bbd72ee00772fe6c76
Author: pwnall <pwnall@chromium.org>
Date: Mon Aug 22 21:27:37 2016

Consistently use namespaced base::Version in chrome/installer.

BUG= 639416 

Review-Url: https://codereview.chromium.org/2258243002
Cr-Commit-Position: refs/heads/master@{#413537}

[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/setup/install.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/setup/install.h
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/setup/install_unittest.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/setup/install_worker.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/setup/install_worker_unittest.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/setup/setup_main.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/setup/setup_util.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/setup/setup_util.h
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/setup/setup_util_unittest.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/setup/uninstall.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/test/alternate_version_generator.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/util/browser_distribution.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/util/browser_distribution.h
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/util/fake_installation_state.h
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/util/fake_product_state.h
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/util/google_chrome_distribution.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/util/google_chrome_distribution.h
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/util/google_update_settings.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/util/google_update_settings.h
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/util/google_update_settings_unittest.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/util/install_util.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/util/installation_state.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/util/installation_state.h
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/util/installation_validator_unittest.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/util/installer_state.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/util/installer_state_unittest.cc
[modify] https://crrev.com/c3f931d06d184b5c2c7363bbd72ee00772fe6c76/chrome/installer/util/product_unittest.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58f42cbc6e1bad2ca642f08d7d4cf5a029ff6808

commit 58f42cbc6e1bad2ca642f08d7d4cf5a029ff6808
Author: pwnall <pwnall@chromium.org>
Date: Fri Aug 26 19:04:44 2016

Consistently use namespaced base::Version in base/ code.

BUG= 639416 

Review-Url: https://codereview.chromium.org/2260933002
Cr-Commit-Position: refs/heads/master@{#414771}

[modify] https://crrev.com/58f42cbc6e1bad2ca642f08d7d4cf5a029ff6808/base/version_unittest.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9cfc0f3665a675e0726889e894cb2d34a06ff42

commit a9cfc0f3665a675e0726889e894cb2d34a06ff42
Author: pwnall <pwnall@chromium.org>
Date: Tue Aug 30 23:17:23 2016

Consistently use namespaced base::Version.

BUG= 639416 

Review-Url: https://codereview.chromium.org/2258263002
Cr-Commit-Position: refs/heads/master@{#415485}

[modify] https://crrev.com/a9cfc0f3665a675e0726889e894cb2d34a06ff42/chrome/browser/chrome_browser_main_win.cc
[modify] https://crrev.com/a9cfc0f3665a675e0726889e894cb2d34a06ff42/chrome/browser/chromeos/app_mode/startup_app_launcher.cc
[modify] https://crrev.com/a9cfc0f3665a675e0726889e894cb2d34a06ff42/chrome/browser/chromeos/login/kiosk_browsertest.cc
[modify] https://crrev.com/a9cfc0f3665a675e0726889e894cb2d34a06ff42/chrome/browser/metrics/chrome_browser_main_extra_parts_metrics.cc
[modify] https://crrev.com/a9cfc0f3665a675e0726889e894cb2d34a06ff42/chrome/browser/net/crl_set_fetcher.cc
[modify] https://crrev.com/a9cfc0f3665a675e0726889e894cb2d34a06ff42/chrome/browser/profiles/profile_impl.cc
[modify] https://crrev.com/a9cfc0f3665a675e0726889e894cb2d34a06ff42/chrome/browser/ui/startup/default_browser_prompt.cc
[modify] https://crrev.com/a9cfc0f3665a675e0726889e894cb2d34a06ff42/chrome/browser/upgrade_detector_impl.cc
[modify] https://crrev.com/a9cfc0f3665a675e0726889e894cb2d34a06ff42/chrome/common/chrome_content_client.cc
[modify] https://crrev.com/a9cfc0f3665a675e0726889e894cb2d34a06ff42/chrome/common/service_process_util.cc
[modify] https://crrev.com/a9cfc0f3665a675e0726889e894cb2d34a06ff42/chrome/common/service_process_util_mac.mm
[modify] https://crrev.com/a9cfc0f3665a675e0726889e894cb2d34a06ff42/components/variations/processed_study.cc
[modify] https://crrev.com/a9cfc0f3665a675e0726889e894cb2d34a06ff42/components/variations/study_filtering_unittest.cc
[modify] https://crrev.com/a9cfc0f3665a675e0726889e894cb2d34a06ff42/ios/chrome/browser/net/crl_set_fetcher.cc
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0de2231894d4289190b8661ae40f9a6cc29fc910

commit 0de2231894d4289190b8661ae40f9a6cc29fc910
Author: pwnall <pwnall@chromium.org>
Date: Wed Aug 31 14:18:39 2016

Disallow non-namespaced use of base::Version.

BUG= 639416 

Review-Url: https://codereview.chromium.org/2261523006
Cr-Commit-Position: refs/heads/master@{#415626}

[modify] https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910/base/version.h
[modify] https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910/chrome/browser/policy/policy_browsertest.cc

Comment 11 by battre@chromium.org, Aug 31 2016 

The last CL closed the tree, reverting:

https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Mac/builds/13512/steps/compile/logs/stdio

FAILED: obj/chrome/browser/browser/pepper_flash_component_installer.o 
/b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/browser/pepper_flash_component_installer.o.d -DV8_DEPRECATION_WARNINGS -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_BROWSER_SPELLCHECKER=1 -DNO_TCMALLOC -DUSE_EXTERNAL_POPUP_MENU=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_RLZ -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -DCR_CLANG_REVISION=280106-1 -DCR_XCODE_VERSION=0511 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_CUPS -DTOOLKIT_VIEWS=1 -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DSK_BUILD_FOR_MAC -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_WEBSOCKETS -DMESA_EGL_NO_X11_HEADERS -DLEVELDB_PLATFORM_CHROMIUM=1 -DI18N_ADDRESSINPUT_USE_BASICTYPES_OVERRIDE=1 -DI18N_ADDRESS_VALIDATION_DATA_URL=\"https://chromium-i18n.appspot.com/ssl-aggregate-address/\" -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DXML_STATIC -DSSL_USE_OPENSSL -DHAVE_OPENSSL_SSL_H -DFEATURE_ENABLE_SSL -DLOGGING=1 -DNO_MAIN_THREAD_WRAPPING -DHUNSPELL_STATIC -DHUNSPELL_CHROME_CLIENT -DUSE_HUNSPELL -I../.. -Igen -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -Igen/chrome -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -Igen/components/strings -Igen/components/strings -Igen/components/strings -Igen/components/strings -I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include -Igen -I../../v8/include -I../../third_party/libwebm/source -I../../third_party/opus/src/include -I../../third_party/boringssl/src/include -I../../third_party/re2/src -I../../third_party/mesa/src/include -Igen/ui/resources -Igen/ui/resources -Igen -Igen/extensions -Igen/extensions -Igen/extensions -Igen -Igen/extensions/strings -I../../third_party/google_toolbox_for_mac -I../../third_party/google_toolbox_for_mac/src -I../../third_party/google_toolbox_for_mac/src/AppKit -I../../third_party/google_toolbox_for_mac/src/DebugUtils -I../../third_party/google_toolbox_for_mac/src/Foundation -Igen/chrome -Igen/chrome -Igen/chrome -Igen/ui/views/resources -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -Igen/components -Igen/components -I../../third_party/libaddressinput/src/cpp/include -I../../third_party/libaddressinput/chromium/override -I../../third_party/webrtc_overrides -I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc_overrides -I../../third_party -I../../third_party/expat/files/lib -I../../third_party/jsoncpp/overrides/include -I../../third_party/jsoncpp/source/include -I../../third_party/libxml/src/include -I../../third_party/libxml/mac/include -I../../third_party/libyuv -I../../third_party/libyuv/include -I../../third_party/zlib -Igen -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -Wall -Werror -Wextra -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -O2 -gdwarf-2 -fno-standalone-debug -isysroot /b/c/b/Google_Chrome_Mac/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.7 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wexit-time-destructors -Wno-unused-function -DLIBXML_STATIC= -fno-threadsafe-statics -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -c ../../chrome/browser/component_updater/pepper_flash_component_installer.cc -o obj/chrome/browser/browser/pepper_flash_component_installer.o
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:65:38: error: unknown type name 'Version'; did you mean 'base::Version'?
                               const Version& flash_version,
                                     ^~~~~~~
                                     base::Version
../../content/public/common/webplugininfo.h:17:7: note: 'base::Version' declared here
class Version;
      ^
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:104:42: error: unknown type name 'Version'; did you mean 'base::Version'?
                                   const Version& version) {
                                         ^~~~~~~
                                         base::Version
../../content/public/common/webplugininfo.h:17:7: note: 'base::Version' declared here
class Version;
      ^
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:120:5: error: use of undeclared identifier 'Version'; did you mean 'version'?
    Version registered_version(base::UTF16ToUTF8(plugin.version));
    ^~~~~~~
    version
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:104:51: note: 'version' declared here
                                   const Version& version) {
                                                  ^
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:120:12: error: expected ';' after expression
    Version registered_version(base::UTF16ToUTF8(plugin.version));
           ^
           ;
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:120:13: error: use of undeclared identifier 'registered_version'
    Version registered_version(base::UTF16ToUTF8(plugin.version));
            ^
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:123:9: error: use of undeclared identifier 'registered_version'
    if (registered_version.IsValid() &&
        ^
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:124:27: error: use of undeclared identifier 'registered_version'
        version.CompareTo(registered_version) < 0) {
                          ^
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:141:9: error: use of undeclared identifier 'registered_version'
    if (registered_version.IsValid() &&
        ^
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:142:27: error: use of undeclared identifier 'registered_version'
        version.CompareTo(registered_version) == 0 &&
                          ^
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:120:5: error: expression result unused [-Werror,-Wunused-value]
    Version registered_version(base::UTF16ToUTF8(plugin.version));
    ^~~~~~~
../../chrome/browser/component_updater/pepper_flash_component_installer.cc:235:3: error: unknown type name 'Version'; did you mean 'base::Version'?
  Version unused;
  ^~~~~~~
  base::Version
../../content/public/common/webplugininfo.h:17:7: note: 'base::Version' declared here
class Version;
      ^
11 errors generated.
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7b1944ca277f1167c34f81b170e3f0b5fcf9570

commit e7b1944ca277f1167c34f81b170e3f0b5fcf9570
Author: battre <battre@chromium.org>
Date: Wed Aug 31 14:45:33 2016

Revert of Disallow non-namespaced use of base::Version. (patchset #2 id:40001 of https://codereview.chromium.org/2261523006/ )

Reason for revert:
Mac builders fail. See  http://crbug.com/639416#c11 

Original issue's description:
> Disallow non-namespaced use of base::Version.
>
> BUG= 639416 
>
> Committed: https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910
> Cr-Commit-Position: refs/heads/master@{#415626}

TBR=thakis@chromium.org,pwnall@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 639416 

Review-Url: https://codereview.chromium.org/2296703005
Cr-Commit-Position: refs/heads/master@{#415627}

[modify] https://crrev.com/e7b1944ca277f1167c34f81b170e3f0b5fcf9570/base/version.h
[modify] https://crrev.com/e7b1944ca277f1167c34f81b170e3f0b5fcf9570/chrome/browser/policy/policy_browsertest.cc

Comment 13 by battre@chromium.org, Aug 31 2016 

Windows compilers are unhappy as well:
[1330/2974] CXX obj/chrome/browser/browser_3/pepper_flash_component_installer.obj
FAILED: obj/chrome/browser/browser_3/pepper_flash_component_installer.obj 
ninja -t msvc -e environment.x64 -- C:\b\c\cipd\goma/gomacc.exe "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/chrome/browser/browser_3/pepper_flash_component_installer.obj.rsp /c ../../chrome/browser/component_updater/pepper_flash_component_installer.cc /Foobj/chrome/browser/browser_3/pepper_flash_component_installer.obj /Fd"obj/chrome/browser/browser_3_cc.pdb"
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(65): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(65): error C2143: syntax error: missing ',' before '&'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(68): error C2065: 'flash_version': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(68): error C2228: left of '.IsValid' must have class/struct/union
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(68): note: type is 'unknown-type'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(70): error C2065: 'flash_version': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(70): error C2228: left of '.components' must have class/struct/union
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(70): note: type is 'unknown-type'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(74): error C2065: 'plugin_info': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(74): error C2227: left of '->is_internal' must point to class/struct/union/generic type
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(74): note: type is 'unknown-type'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(75): error C2065: 'plugin_info': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(75): error C2227: left of '->is_out_of_process' must point to class/struct/union/generic type
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(75): note: type is 'unknown-type'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(75): error C2065: 'out_of_process': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(76): error C2065: 'plugin_info': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(76): error C2227: left of '->path' must point to class/struct/union/generic type
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(76): note: type is 'unknown-type'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(77): error C2065: 'plugin_info': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(77): error C2227: left of '->name' must point to class/struct/union/generic type
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(77): note: type is 'unknown-type'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(78): error C2065: 'plugin_info': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(78): error C2227: left of '->permissions' must point to class/struct/union/generic type
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(78): note: type is 'unknown-type'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(81): error C2065: 'plugin_info': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(81): error C2227: left of '->description' must point to class/struct/union/generic type
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(81): note: type is 'unknown-type'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(87): error C2065: 'plugin_info': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(87): error C2227: left of '->version' must point to class/struct/union/generic type
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(87): note: type is 'unknown-type'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(87): error C2065: 'flash_version': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(87): error C2228: left of '.GetString' must have class/struct/union
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(87): note: type is 'unknown-type'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(92): error C2065: 'plugin_info': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(92): error C2227: left of '->mime_types' must point to class/struct/union/generic type
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(92): note: type is 'unknown-type'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(92): error C2228: left of '.push_back' must have class/struct/union
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(96): error C2065: 'plugin_info': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(96): error C2227: left of '->mime_types' must point to class/struct/union/generic type
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(96): note: type is 'unknown-type'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(96): error C2228: left of '.push_back' must have class/struct/union
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(104): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(104): error C2143: syntax error: missing ',' before '&'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(107): error C2065: 'version': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(120): error C2146: syntax error: missing ';' before identifier 'registered_version'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(120): error C3861: 'registered_version': identifier not found
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(123): error C2065: 'registered_version': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(123): error C2228: left of '.IsValid' must have class/struct/union
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(123): note: type is 'unknown-type'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(124): error C2065: 'version': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(124): error C2228: left of '.CompareTo' must have class/struct/union
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(124): note: type is 'unknown-type'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(124): error C2065: 'registered_version': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(141): error C2065: 'registered_version': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(141): error C2228: left of '.IsValid' must have class/struct/union
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(141): note: type is 'unknown-type'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(142): error C2065: 'version': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(142): error C2228: left of '.CompareTo' must have class/struct/union
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(142): note: type is 'unknown-type'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(142): error C2065: 'registered_version': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(226): error C2664: 'void component_updater::`anonymous-namespace'::RegisterPepperFlashWithChrome(const base::FilePath &,const int)': cannot convert argument 2 from 'const base::Version' to 'const int'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(226): note: No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(235): error C2065: 'Version': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(235): error C2146: syntax error: missing ';' before identifier 'unused'
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(235): error C2065: 'unused': undeclared identifier
c:\b\c\b\win_x64_builder\src\chrome\browser\component_updater\pepper_flash_component_installer.cc(236): error C2065: 'unused': undeclared identifier

Comment 14 by afakhry@chromium.org, Aug 31 2016

Cc: afakhry@chromium.org michae...@chromium.org
This CL: https://codereview.chromium.org/2261523006 has broken the builder: lumpy-tot-chrome-pfq-informational [1]

chromeos-chrome-55.0.2846.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/chrome/browser/component_updater/pepper_flash_component_installer.cc: In member function 'virtual bool component_updater::{anonymous}::FlashComponentInstallerTraits::VerifyInstallation(const base::DictionaryValue&, const base::FilePath&) const':
chromeos-chrome-55.0.2846.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/chrome/browser/component_updater/pepper_flash_component_installer.cc:235:3: error: 'Version' was not declared in this scope
chromeos-chrome-55.0.2846.0_alpha-r1:    Version unused;
chromeos-chrome-55.0.2846.0_alpha-r1:    ^
chromeos-chrome-55.0.2846.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/chrome/browser/component_updater/pepper_flash_component_installer.cc:235:3: note: suggested alternative:
chromeos-chrome-55.0.2846.0_alpha-r1: In file included from ../../../../../../../home/chrome-bot/chrome_root/src/chrome/browser/component_updater/pepper_flash_component_installer.cc:27:0:
chromeos-chrome-55.0.2846.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/base/version.h:20:7: note:   'base::Version'
chromeos-chrome-55.0.2846.0_alpha-r1:  class BASE_EXPORT Version {
chromeos-chrome-55.0.2846.0_alpha-r1:        ^
chromeos-chrome-55.0.2846.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/chrome/browser/component_updater/pepper_flash_component_installer.cc:236:54: error: 'unused' was not declared in this scope
chromeos-chrome-55.0.2846.0_alpha-r1:    return chrome::CheckPepperFlashManifest(manifest, &unused);
chromeos-chrome-55.0.2846.0_alpha-r1:                                                       ^
chromeos-chrome-55.0.2846.0_alpha-r1: ../../../../../../../home/chrome-bot/chrome_root/src/chrome/browser/component_updater/pepper_flash_component_installer.cc:237:1: error: control reaches end of non-void function [-Werror=return-type]
chromeos-chrome-55.0.2846.0_alpha-r1:  }
chromeos-chrome-55.0.2846.0_alpha-r1:  ^
chromeos-chrome-55.0.2846.0_alpha-r1: cc1plus: all warnings being treated as errors

[1]: https://uberchromegw.corp.google.com/i/chromeos.chrome/builders/lumpy-tot-chrome-pfq-informational/builds/20267

Reverted already.

Comment 16 by battre@chromium.org, Sep 1 2016 

https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/13362/steps/compile/logs/stdio

[18419/25810] CXX obj/chrome/browser/browser/obsolete_system_linux.o
FAILED: obj/chrome/browser/browser/obsolete_system_linux.o 
/b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/browser/obsolete_system_linux.o.d -DUSE_LIBSECRET -DV8_DEPRECATION_WARNINGS -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -DCR_CLANG_REVISION=280106-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DCFI_ENFORCEMENT -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_CUPS -DUSE_GNOME_KEYRING -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DTOOLKIT_VIEWS=1 -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DV8_USE_EXTERNAL_STARTUP_DATA -DENABLE_WEBSOCKETS -DLEVELDB_PLATFORM_CHROMIUM=1 -DI18N_ADDRESSINPUT_USE_BASICTYPES_OVERRIDE=1 -DI18N_ADDRESS_VALIDATION_DATA_URL=\"https://chromium-i18n.appspot.com/ssl-aggregate-address/\" -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DSSL_USE_OPENSSL -DHAVE_OPENSSL_SSL_H -DFEATURE_ENABLE_SSL -DLOGGING=1 -DNO_MAIN_THREAD_WRAPPING -DHUNSPELL_STATIC -DHUNSPELL_CHROME_CLIENT -DUSE_HUNSPELL -I../.. -Igen -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/gnome-keyring-1 -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -Igen/chrome -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -Igen/components/strings -Igen/components/strings -Igen/components/strings -Igen/components/strings -I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include -Igen -I../../v8/include -I../../third_party/libwebm/source -I../../third_party/opus/src/include -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/nss -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/nspr -I../../third_party/boringssl/src/include -I../../third_party/re2/src -I../../third_party/mesa/src/include -Igen/ui/resources -Igen/ui/resources -Igen -Igen/extensions -Igen/extensions -Igen/extensions -Igen -Igen/extensions/strings -Igen/chrome -Igen/chrome -Igen/chrome -Igen/ui/views/resources -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -Igen/components -Igen/components -I../../third_party/libaddressinput/src/cpp/include -I../../third_party/libaddressinput/chromium/override -I../../third_party/webrtc_overrides -I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc_overrides -I../../third_party -I../../third_party/jsoncpp/overrides/include -I../../third_party/jsoncpp/source/include -I../../third_party/libxml/src/include -I../../third_party/libxml/linux/include -I../../third_party/libyuv -I../../third_party/libyuv/include -I../../third_party/zlib -Igen -I../../third_party/libsecret -I../../breakpad/src -I../../build/linux/debian_wheezy_amd64-sysroot/usr/include/dbus-1.0 -I../../build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu/dbus-1.0/include -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/b/c/b/Google_Chrome_Linux_x64/src=. -flto -fwhole-program-vtables -pthread -m64 -march=x86-64 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -O2 -fno-ident -fdata-sections -ffunction-sections -g2 --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fsanitize=cfi-vcall -fsanitize-blacklist=../../tools/cfi/blacklist.txt -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wexit-time-destructors -Wno-unused-function -Wno-header-guard -DLIBXML_STATIC= -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -fno-rtti -fno-exceptions -c ../../chrome/browser/obsolete_system/obsolete_system_linux.cc -o obj/chrome/browser/browser/obsolete_system_linux.o
../../chrome/browser/obsolete_system/obsolete_system_linux.cc:34:3: error: unknown type name 'Version'; did you mean 'base::Version'?
  Version version(gnu_get_libc_version());
  ^~~~~~~
  base::Version
../../base/version.h:20:19: note: 'base::Version' declared here
class BASE_EXPORT Version {
                  ^
1 error generated.

Reverting.
Project Member

Comment 17 by bugdroid1@chromium.org, Sep 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eae359bdbd66abae7461dcb12e5026b4dfc8e7ea

commit eae359bdbd66abae7461dcb12e5026b4dfc8e7ea
Author: battre <battre@chromium.org>
Date: Thu Sep 01 14:22:43 2016

Revert of Disallow non-namespaced use of base::Version. (patchset #2 id:20001 of https://codereview.chromium.org/2290173006/ )

Reason for revert:
Breaks Google Chrome Linux x64 builder, see  http://crbug.com/639416#c16 

Original issue's description:
> Disallow non-namespaced use of base::Version.
>
> This is a reland of
> https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910
>
> BUG= 639416 
>
> Committed: https://crrev.com/bc8e5f797c9fac1708ab7b27da4d96ec274c6ca0
> Cr-Commit-Position: refs/heads/master@{#415940}

TBR=thakis@chromium.org,pwnall@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 639416 

Review-Url: https://codereview.chromium.org/2305433003
Cr-Commit-Position: refs/heads/master@{#415946}

[modify] https://crrev.com/eae359bdbd66abae7461dcb12e5026b4dfc8e7ea/base/version.h
[modify] https://crrev.com/eae359bdbd66abae7461dcb12e5026b4dfc8e7ea/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/eae359bdbd66abae7461dcb12e5026b4dfc8e7ea/chrome/browser/policy/policy_browsertest.cc
Project Member

Comment 19 by bugdroid1@chromium.org, Sep 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd28ba5979255a1a328acb3916ca7f985bf0cd0e

commit bd28ba5979255a1a328acb3916ca7f985bf0cd0e
Author: fgorski <fgorski@chromium.org>
Date: Thu Sep 01 19:38:14 2016

Revert of Disallow non-namespaced use of base::Version. (patchset #1 id:1 of https://codereview.chromium.org/2298923003/ )

Reason for revert:

Build broken again:

https://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20Linux%20x64&number=13369

Original issue's description:
> Disallow non-namespaced use of base::Version.
>
> This is a reland of
> https://crrev.com/bc8e5f797c9fac1708ab7b27da4d96ec274c6ca0
> which is a reland of
> https://crrev.com/0de2231894d4289190b8661ae40f9a6cc29fc910
>
> BUG= 639416 
>
> Committed: https://crrev.com/706bd25d40c82c7cb8dadb99ce24b8ebfd4a09ab
> Cr-Commit-Position: refs/heads/master@{#415991}

TBR=thakis@chromium.org,pwnall@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 639416 

Review-Url: https://codereview.chromium.org/2301183002
Cr-Commit-Position: refs/heads/master@{#416017}

[modify] https://crrev.com/bd28ba5979255a1a328acb3916ca7f985bf0cd0e/base/version.h
[modify] https://crrev.com/bd28ba5979255a1a328acb3916ca7f985bf0cd0e/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/bd28ba5979255a1a328acb3916ca7f985bf0cd0e/chrome/browser/obsolete_system/obsolete_system_linux.cc
[modify] https://crrev.com/bd28ba5979255a1a328acb3916ca7f985bf0cd0e/chrome/browser/policy/policy_browsertest.cc

Comment 21 by pwnall@chromium.org, Sep 2 2016

Status: Fixed (was: Untriaged)
Closing this bug, because the CL that nixed "using base::Version;" seems to have stuck after its 4th landing.
►

Sign in to add a comment