Issue metadata
Sign in to add a comment
|
1%-3.7% regression in system_health.memory_mobile at 404887:404977 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Aug 19 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9003875999937248816
,
Aug 20 2016
=== Auto-CCing suspected CL author kozyatinskiy@chromium.org === Hi kozyatinskiy@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : [DevTools] Remove functionDetails from protocol.json Author : kozyatinskiy Commit description: BUG= 623763 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2122423002 Cr-Commit-Position: refs/heads/master@{#404926} Commit : 5b6a87d77630749c6c5a64ba94a6bb855d18a81d Date : Wed Jul 13 02:47:54 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@404908 1646952 0.0 5 good chromium@404920 1647013 135.953 5 good chromium@404923 1646952 0.0 5 good chromium@404925 1646952 0.0 5 good chromium@404926 1705984 0.0 5 bad <-- chromium@404931 1705984 0.0 5 bad Bisect job ran on: android_s5_perf_bisect Bug ID: 639379 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_mobile Test Metric: load_games-memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/load_games_lazors Relative Change: 3.58% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_s5_perf_bisect/builds/927 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9003875999937248816 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=4927507896205312 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Aug 22 2016
My change affects only behavior when DevTools is opened and some protocol methods are called. I think that my change can't produce this memory regression on Android.
,
Aug 22 2016
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/9003605845569882352
,
Aug 22 2016
kozyatinskiy: Telemetry uses the DevTools protocol to drive benchmarks and the bisect results were very clear. Nevertheless, I kicked off one more bisect to double check.
,
Aug 23 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : [DevTools] Remove functionDetails from protocol.json Author : kozyatinskiy Commit description: BUG= 623763 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2122423002 Cr-Commit-Position: refs/heads/master@{#404926} Commit : 5b6a87d77630749c6c5a64ba94a6bb855d18a81d Date : Wed Jul 13 02:47:54 2016 ===== TESTED REVISIONS ===== Revision Mean Std Dev N Good? chromium@404886 2008932 0.0 5 good chromium@404911 2008968 80.4984 5 good chromium@404923 2008932 0.0 5 good chromium@404925 2008968 80.4984 5 good chromium@404926 2026639 16.0997 5 bad <-- chromium@404929 2026639 16.0997 5 bad chromium@404935 2026646 19.718 5 bad Bisect job ran on: android_nexus7_perf_bisect Bug ID: 639379 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests system_health.memory_mobile Test Metric: load_tools-memory:chrome:all_processes:reported_by_chrome:v8:effective_size_avg/load_tools_docs Relative Change: 0.88% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus7_perf_bisect/builds/3236 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9003605845569882352 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5209181481598976 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Aug 23 2016
kozyatinskiy: Another bisect (on a different device) confirmed that your patch is the most likely culprit. Could you please investigate the issue (e.g. try if reverting your patch fixes the issue)? To try this on the Android trybots: 1. Check out ToT 2. Revert your patch 3. Run the benchmark: tools/perf/run_benchmark try all-android system_health.memory_mobile
,
Aug 23 2016
I'll investigate. Thank you.
,
Aug 30 2016
,
Sep 30 2016
In my patch I merged two protocol methods for functions. Before getProperties on function object returns only its properties without internal properties and getFunctionDetails returns scopes and location of function. With my patch getProperties method return scopes and location in internalProperties, scopes can be big. We can improve our protocol and provide flag in getProperties method to ignore internal properties and then we need to update telemetry code and issue will be solved. But how critical is it? Can we left everything as is since it doesn't affect real users experience and only change perfomance runner consumption?
,
Oct 3 2016
The System Health benchmark strives to simulate real-world usage of Chrome, so I would agree that this regression could affect real users. However, the regression is quite small (~17 KiB), so I think it's ok to mark it as WontFix. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by petrcermak@chromium.org
, Aug 19 2016