Issue 639372 link

Starred by 1 user

Issue metadata

Status:	Verified
Owner:	ljusten@chromium.org
Closed:	Sep 2016
Cc:	atwilson@chromium.org tnagel@chromium.org █ bartfab@chromium.org █ saswat@chromium.org █ vidster@chromium.org
Components:	Enterprise
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
VerifyIn-55 UIShellKiosk VerifyIn-56 VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60

Blocked on:
issue 450523

Change DeviceStatusCollector to return status asynchronously Part 2

Project Member Reported by ljusten@chromium.org, Aug 19 2016

Issue description

In part 1 of this change (crbug/450523), the DeviceStatusCollector interface was refactored to return status asynchronously. However, the actual status gathering process is still synchronous.

DeviceStatusCollector should be changed to gather CPU temp and drive volume info on demand instead of sampling the data in regular intervals. Geo location should be removed, it is not used.

Moreover, consider using NonThreadSafe / ThreadChecker instead of the current implementation to verify that the calls happen on the correct threads.

Comment 1 by bartfab@chromium.org, Aug 26 2016

Cc: bartfab@chromium.org

Comment 2 by ljusten@chromium.org, Sep 28 2016

Status: Fixed (was: Started)

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e4082c0fc2425bb6f040e29baae4362246ef93d

commit 6e4082c0fc2425bb6f040e29baae4362246ef93d
Author: ljusten <ljusten@chromium.org>
Date: Wed Sep 28 08:12:43 2016

Refactored DeviceStatusCollector to enable truely asynchronous status queries

Combined GetDeviceStatusAsync and GetDeviceSessionStatusAsync into one function. They are always called together and combining them makes StatusGetter in status_uploader.h/cc unnecessary.
Added helper class to keep state for asynchronous status queries.
Disk volume info and CPU temp info are now collected asynchronously when status is requested. Before, the data was sampled regularly and only the last sample was used.
Removed unused geo location reporting code.
Deprecated device_location field in protobuf.
Changed thread-checking to use ThreadChecker class.

BUG= 639372 

Review-Url: https://codereview.chromium.org/2314813002
Cr-Commit-Position: refs/heads/master@{#421475}

[modify] https://crrev.com/6e4082c0fc2425bb6f040e29baae4362246ef93d/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/6e4082c0fc2425bb6f040e29baae4362246ef93d/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/6e4082c0fc2425bb6f040e29baae4362246ef93d/chrome/browser/chromeos/policy/device_status_collector.h
[modify] https://crrev.com/6e4082c0fc2425bb6f040e29baae4362246ef93d/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/6e4082c0fc2425bb6f040e29baae4362246ef93d/chrome/browser/chromeos/policy/status_uploader.cc
[modify] https://crrev.com/6e4082c0fc2425bb6f040e29baae4362246ef93d/chrome/browser/chromeos/policy/status_uploader.h
[modify] https://crrev.com/6e4082c0fc2425bb6f040e29baae4362246ef93d/chrome/browser/chromeos/policy/status_uploader_unittest.cc
[modify] https://crrev.com/6e4082c0fc2425bb6f040e29baae4362246ef93d/chrome/common/pref_names.cc
[modify] https://crrev.com/6e4082c0fc2425bb6f040e29baae4362246ef93d/chrome/common/pref_names.h
[modify] https://crrev.com/6e4082c0fc2425bb6f040e29baae4362246ef93d/components/policy/proto/device_management_backend.proto
[modify] https://crrev.com/6e4082c0fc2425bb6f040e29baae4362246ef93d/components/policy/resources/policy_templates.json