New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639354 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clean up uses of synthesized IsOfflinePagesEnabled flag

Project Member Reported by dougarnett@chromium.org, Aug 19 2016

Issue description

Consider just relying on feature-specific flags for cases that can create or schedule offline pages but not require a flag to consume/manage existing offline pages.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bf1e183f5e7ffd28b687b0e2107479f92dee00d

commit 1bf1e183f5e7ffd28b687b0e2107479f92dee00d
Author: dougarnett <dougarnett@chromium.org>
Date: Tue Aug 30 04:08:47 2016

[Offline Pages] Removes check on deprecated IsOfflinePagesEnabled flag from BrowsingDataRemover

BUG= 639354 

Review-Url: https://codereview.chromium.org/2288823002
Cr-Commit-Position: refs/heads/master@{#415075}

[modify] https://crrev.com/1bf1e183f5e7ffd28b687b0e2107479f92dee00d/chrome/browser/browsing_data/browsing_data_remover.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11266087108f0bfbd5818322d432fa2749f37d1c

commit 11266087108f0bfbd5818322d432fa2749f37d1c
Author: dougarnett <dougarnett@chromium.org>
Date: Tue Aug 30 20:14:25 2016

Removes check on deprecated OfflinePageBridge.isOfflinePagesEnabled() from isNtpOfflinePagesEnabled()

BUG= 639354 

Review-Url: https://codereview.chromium.org/2285313002
Cr-Commit-Position: refs/heads/master@{#415405}

[modify] https://crrev.com/11266087108f0bfbd5818322d432fa2749f37d1c/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Status: Fixed (was: Assigned)

Sign in to add a comment