cros_ec_ring: simplify buffer |
||||||||||
Issue descriptionAs suggested by Jonathan Cameron <jic23@kernel.org>, cros_ec_ring uses a trigger_buffer, but it is not required given we always enable the trigger. Use a simpler kfifo buffer: indio_dev->modes = INDIO_BUFFER_SOFTWARE; buffer = devm_iio_kfifo_allocate(&device->dev); if (!buffer) return -ENOMEM; iio_device_attach_buffer(indio_dev, buffer); In the notifier, use cros_ec_ring_handler() directly. We won't trigger the interrupt on another thread, the notifier will appear stuck, but we are using the EC bus anyway, other notified won't be able to do anything with the EC anyway.
,
Aug 31 2016
,
Aug 31 2016
Your change meets the bar and is auto-approved for M54 (branch: 2840)
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/568b2e39ad26cb3a3258170efd19d268921671a9 commit 568b2e39ad26cb3a3258170efd19d268921671a9 Author: Gwendal Grignou <gwendal@chromium.org> Date: Sat Aug 20 19:06:40 2016 CHROMIUM: iio: cros_ec: Remove cros_ec_sensor_ring trigger Using a IRQ trigger is not needed for cros_ec_sensor_ring. When the notifier indicates there are event, within that thread, collect from the EC and process all the datum. Using a separate thread is not useful, given it will take ownership of the EC and prevents other notified from getting their data. BUG= chromium:639341 TEST=Check on Kevin with ARC++ that sensor data are still collected properly. Change-Id: I5dda516a88d8108ed2b020ae92c6053c718518f7 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/373562 Reviewed-by: Guenter Roeck <groeck@chromium.org> (cherry picked from commit 357907813a8aaabaa813f71269348302cea3e496) Reviewed-on: https://chromium-review.googlesource.com/379563 Reviewed-by: Mohammed Habibulla <moch@google.com> Commit-Queue: Mohammed Habibulla <moch@google.com> Tested-by: Mohammed Habibulla <moch@google.com> [modify] https://crrev.com/568b2e39ad26cb3a3258170efd19d268921671a9/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_ring.c [modify] https://crrev.com/568b2e39ad26cb3a3258170efd19d268921671a9/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.h [modify] https://crrev.com/568b2e39ad26cb3a3258170efd19d268921671a9/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
,
Aug 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/568b2e39ad26cb3a3258170efd19d268921671a9 commit 568b2e39ad26cb3a3258170efd19d268921671a9 Author: Gwendal Grignou <gwendal@chromium.org> Date: Sat Aug 20 19:06:40 2016 CHROMIUM: iio: cros_ec: Remove cros_ec_sensor_ring trigger Using a IRQ trigger is not needed for cros_ec_sensor_ring. When the notifier indicates there are event, within that thread, collect from the EC and process all the datum. Using a separate thread is not useful, given it will take ownership of the EC and prevents other notified from getting their data. BUG= chromium:639341 TEST=Check on Kevin with ARC++ that sensor data are still collected properly. Change-Id: I5dda516a88d8108ed2b020ae92c6053c718518f7 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/373562 Reviewed-by: Guenter Roeck <groeck@chromium.org> (cherry picked from commit 357907813a8aaabaa813f71269348302cea3e496) Reviewed-on: https://chromium-review.googlesource.com/379563 Reviewed-by: Mohammed Habibulla <moch@google.com> Commit-Queue: Mohammed Habibulla <moch@google.com> Tested-by: Mohammed Habibulla <moch@google.com> [modify] https://crrev.com/568b2e39ad26cb3a3258170efd19d268921671a9/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_ring.c [modify] https://crrev.com/568b2e39ad26cb3a3258170efd19d268921671a9/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.h [modify] https://crrev.com/568b2e39ad26cb3a3258170efd19d268921671a9/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
,
Sep 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/4888b42a1659fcb4b54353d80655646a432665f2 commit 4888b42a1659fcb4b54353d80655646a432665f2 Author: Gwendal Grignou <gwendal@chromium.org> Date: Sat Aug 20 19:06:40 2016 CHROMIUM: iio: cros_ec: Remove cros_ec_sensor_ring trigger Using a IRQ trigger is not needed for cros_ec_sensor_ring. When the notifier indicates there are event, within that thread, collect from the EC and process all the datum. Using a separate thread is not useful, given it will take ownership of the EC and prevents other notified from getting their data. BUG= chromium:639341 TEST=Check on Kevin with ARC++ that sensor data are still collected properly. Change-Id: I5dda516a88d8108ed2b020ae92c6053c718518f7 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/373562 Reviewed-by: Guenter Roeck <groeck@chromium.org> (cherry picked from commit 357907813a8aaabaa813f71269348302cea3e496) Reviewed-on: https://chromium-review.googlesource.com/377739 Tested-by: Jongpil Jung <jongpil19.jung@samsung.com> Reviewed-by: Philip Chen <philipchen@chromium.org> Commit-Queue: Philip Chen <philipchen@chromium.org> [modify] https://crrev.com/4888b42a1659fcb4b54353d80655646a432665f2/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_ring.c [modify] https://crrev.com/4888b42a1659fcb4b54353d80655646a432665f2/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.h [modify] https://crrev.com/4888b42a1659fcb4b54353d80655646a432665f2/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c
,
Sep 4 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Sep 7 2016
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 20 2016
This issue hasn't been updated in the last 6 weeks, so removing its merge approval label. Please re-request a merge if needed. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 4 2017
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 28 2016