New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639315 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 589726



Sign in to add a comment

Move long_running_idle_google_cases to system health

Project Member Reported by rnep...@chromium.org, Aug 19 2016

Issue description

extract the story from long_running_idle_google_cases.py, adapt it to the structure used in tools/perf/page_sets/system_health/ and add a new file (long_running_stories.py).
 
Blocking: 589726
Cc: hpayer@chromium.org u...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13d57aa167188a0ea4388634fcf4589d892002ff

commit 13d57aa167188a0ea4388634fcf4589d892002ff
Author: rnephew <rnephew@chromium.org>
Date: Wed Aug 31 18:51:02 2016

[Telemetry] Convert long running user stories to the System Health format.

BUG= 639315 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2272993003
Cr-Commit-Position: refs/heads/master@{#415702}

[modify] https://crrev.com/13d57aa167188a0ea4388634fcf4589d892002ff/tools/perf/benchmarks/system_health_smoke_test.py
[modify] https://crrev.com/13d57aa167188a0ea4388634fcf4589d892002ff/tools/perf/page_sets/data/system_health_desktop.json
[modify] https://crrev.com/13d57aa167188a0ea4388634fcf4589d892002ff/tools/perf/page_sets/data/system_health_mobile.json
[add] https://crrev.com/13d57aa167188a0ea4388634fcf4589d892002ff/tools/perf/page_sets/system_health/long_running_stories.py

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50107db100baf17574adf73954af24da40532a77

commit 50107db100baf17574adf73954af24da40532a77
Author: petrcermak <petrcermak@chromium.org>
Date: Thu Sep 01 10:39:10 2016

Revert of [Telemetry] Convert long running user stories to the System Health format. (patchset #4 id:60001 of https://codereview.chromium.org/2272993003/ )

Reason for revert:
The patch broke perf bots because it doesn't contain WPR recordings.

Original issue's description:
> [Telemetry] Convert long running user stories to the System Health format.
>
> BUG= 639315 
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
>
> Committed: https://crrev.com/13d57aa167188a0ea4388634fcf4589d892002ff
> Cr-Commit-Position: refs/heads/master@{#415702}

TBR=charliea@chromium.org,nednguyen@google.com,perezju@chromium.org,rnephew@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 639315 , 643110 

Review-Url: https://codereview.chromium.org/2302803002
Cr-Commit-Position: refs/heads/master@{#415926}

[modify] https://crrev.com/50107db100baf17574adf73954af24da40532a77/tools/perf/benchmarks/system_health_smoke_test.py
[modify] https://crrev.com/50107db100baf17574adf73954af24da40532a77/tools/perf/page_sets/data/system_health_desktop.json
[modify] https://crrev.com/50107db100baf17574adf73954af24da40532a77/tools/perf/page_sets/data/system_health_mobile.json
[delete] https://crrev.com/a946e92eaa55cb6da801ada49dfdd51d786fa06d/tools/perf/page_sets/system_health/long_running_stories.py

Project Member

Comment 6 by bugdroid1@chromium.org, Sep 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff39c2e3c16c91a7beff4a959c918b344286b010

commit ff39c2e3c16c91a7beff4a959c918b344286b010
Author: picksi <picksi@chromium.org>
Date: Fri Sep 02 09:38:52 2016

Revert of Reland [Telemetry] Convert long running user stories to the System Health format. (patchset #1 id:1 of https://codereview.chromium.org/2297783005/ )

Reason for revert:
The long running gmail test enabled by the CL is failing and turning all the Android perf bots red. See  crbug.com/643110 /

Original issue's description:
> Reland [Telemetry] Convert long running user stories to the System Health format.
>
> BUG= 639315 
>
> Committed: https://crrev.com/1e7e98e048508e3c158244c409830f5a4ebc0630
> Cr-Commit-Position: refs/heads/master@{#415996}

TBR=nednguyen@google.com,petrcermak@chromium.org,perezju@chromium.org,charliea@chromium.org,rnephew@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 639315 , 643110 

Review-Url: https://codereview.chromium.org/2294913010
Cr-Commit-Position: refs/heads/master@{#416224}

[modify] https://crrev.com/ff39c2e3c16c91a7beff4a959c918b344286b010/tools/perf/benchmarks/system_health_smoke_test.py
[modify] https://crrev.com/ff39c2e3c16c91a7beff4a959c918b344286b010/tools/perf/page_sets/data/system_health_desktop.json
[delete] https://crrev.com/2fcb04a7eabd49c59a9b25edd7303973d01523b1/tools/perf/page_sets/data/system_health_desktop_028.wpr.sha1
[modify] https://crrev.com/ff39c2e3c16c91a7beff4a959c918b344286b010/tools/perf/page_sets/data/system_health_mobile.json
[delete] https://crrev.com/2fcb04a7eabd49c59a9b25edd7303973d01523b1/tools/perf/page_sets/data/system_health_mobile_042.wpr.sha1
[delete] https://crrev.com/2fcb04a7eabd49c59a9b25edd7303973d01523b1/tools/perf/page_sets/system_health/long_running_stories.py

Status: Fixed (was: Assigned)
Closing this since it has been running for awhile now.

Sign in to add a comment