New issue
Advanced search Search tips

Issue 639295 link

Starred by 3 users

Issue metadata

Status: Archived
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature
TT

Blocked on:
issue 658713
issue 661496



Sign in to add a comment

Implement install attributes changes for Chromad.

Project Member Reported by tnagel@chromium.org, Aug 19 2016

Issue description

Comment 1 by tnagel@chromium.org, Sep 28 2016

Labels: M-56
Owner: tnagel@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42d7ea0a129585044fa4461e7d581ad88e4525dc

commit 42d7ea0a129585044fa4461e7d581ad88e4525dc
Author: tnagel <tnagel@chromium.org>
Date: Thu Oct 13 10:14:17 2016

Remove unused email from install attributes and add support for AD.

Notable changes:
* Simplify attribute accessors by ensuring that attribute members
  are always self-consistent.
* Drop distinction between unset and empty attributes.
* Strict enforcement of *all* attributes being identical on
  re-locking.
* IsEnterpriseDevice() evaluates the device mode instead of
  the (deprecated) user.
* Improve encapsulation of StubInstallAttributes by disabling
  direct member access, provide high-level setters instead.

BUG= 639295 ,  638713 
TBR=achuith (chrome/browser/chromeos/{app_mode,login,system})
TBR=reillyg (chrome/browser/extensions)
TBR=eroman (chrome/browser/net)
TBR=bauerb (chrome/browser/ui/webui)

Review-Url: https://codereview.chromium.org/2403053003
Cr-Commit-Position: refs/heads/master@{#424994}

[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/policy/affiliated_invalidation_service_provider_impl_unittest.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/policy/blocking_login_browsertest.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/policy/device_cloud_policy_initializer_unittest.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/settings/install_attributes.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/settings/install_attributes.h
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/settings/install_attributes_unittest.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/settings/stub_install_attributes.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/settings/stub_install_attributes.h
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/chromeos/system/device_disabling_manager_unittest.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/extensions/api/enterprise_device_attributes/enterprise_device_attributes_apitest.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/extensions/api/identity/identity_apitest.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/net/errorpage_browsertest.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/chrome/browser/ui/webui/options/preferences_browsertest.cc
[modify] https://crrev.com/42d7ea0a129585044fa4461e7d581ad88e4525dc/components/policy/core/common/cloud/cloud_policy_constants.h

Comment 3 by tnagel@chromium.org, Oct 29 2016

Blockedon: 658713
Blockedon: 661496

Comment 5 by tnagel@chromium.org, Nov 21 2016

Labels: TT
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9faf37792aadb357b5895b318f69a1a84a62bbe9

commit 9faf37792aadb357b5895b318f69a1a84a62bbe9
Author: tnagel <tnagel@chromium.org>
Date: Fri Nov 25 15:36:46 2016

Mop up incorrect uses of IsEnterpriseManaged()

Adding Active Directory support has created ambiguity as to whether
IsEnterpriseManaged() means "cloud management" or just "any kind of
management" which used to be conflated in the past.  This CL aims to
eliminate the remaining incorrect calls.

BUG= 639295 

Review-Url: https://codereview.chromium.org/2534433002
Cr-Commit-Position: refs/heads/master@{#434509}

[modify] https://crrev.com/9faf37792aadb357b5895b318f69a1a84a62bbe9/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc
[modify] https://crrev.com/9faf37792aadb357b5895b318f69a1a84a62bbe9/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/9faf37792aadb357b5895b318f69a1a84a62bbe9/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/9faf37792aadb357b5895b318f69a1a84a62bbe9/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h
[modify] https://crrev.com/9faf37792aadb357b5895b318f69a1a84a62bbe9/chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
[modify] https://crrev.com/9faf37792aadb357b5895b318f69a1a84a62bbe9/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/9faf37792aadb357b5895b318f69a1a84a62bbe9/chrome/browser/chromeos/policy/enrollment_handler_chromeos.cc
[modify] https://crrev.com/9faf37792aadb357b5895b318f69a1a84a62bbe9/chrome/browser/chromeos/settings/install_attributes.h

Comment 7 by tnagel@chromium.org, Nov 25 2016

Status: Fixed (was: Started)

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment