Regression: Page does not navigate to chrome://settings/clearBrowserData on pressing Space bar key.
Reported by
jshan...@etouch.net,
Aug 19 2016
|
|||
Issue descriptionChrome Version: 54.0.2832.2 (Official Build) 373f6bdd42a605a49fa170b2bcdbae3fbd015acc-refs/branch-heads/2832@{#3} (32/64-bit) OS: Mac(10.10.5)(10.11.5), Windows(7,8,8.1,10), Linux(14.04 LTS) Steps: 1. Launch Chrome and navigate to chrome://history. 2. Pres tab key till focus is seen on 'Clear browsing data', press Space bar key and observe. Actual: No action is seen on pressing Space bar key when focus is on 'Clear browsing data',i.e page does not navigate to chrome://settings/clearBrowserData even though ripple effect is seen. Expected: Page should navigate to chrome://settings/clearBrowserData on pressing Space bar key. This is a regression issue, broken in M-54 series, below is bisect info. Good build: 54.0.2802.0 Bad build: 54.0.2803.0 Narrow bisect: https://chromium.googlesource.com/chromium/src/+log/d149b80d547b9766d90159f80e931005acf1b433..ae9bccd603ed3d867557a0ec4231bccf67640223?pretty=fuller&n=100 Suspecting: r406488 ? Please help to re-assign if your change is not the cause for this issue.
,
Aug 23 2016
calamity@: Can we get an update on this issue as we are approaching the M-54 branch point(few days from now). Please prioritize this accordingly. Thank you!
,
Aug 24 2016
,
Aug 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3798937bc576f5408b0d8a7b8789320acaeb821b commit 3798937bc576f5408b0d8a7b8789320acaeb821b Author: calamity <calamity@chromium.org> Date: Wed Aug 24 10:02:38 2016 [MD History] Make sidebar menu respond to spacebar. This CL allows the menu items in the sidebar to be activated by the spacebar. BUG= 639288 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2264933002 Cr-Commit-Position: refs/heads/master@{#414034} [modify] https://crrev.com/3798937bc576f5408b0d8a7b8789320acaeb821b/chrome/browser/resources/md_history/app.crisper.js [modify] https://crrev.com/3798937bc576f5408b0d8a7b8789320acaeb821b/chrome/browser/resources/md_history/compiled_resources2.gyp [modify] https://crrev.com/3798937bc576f5408b0d8a7b8789320acaeb821b/chrome/browser/resources/md_history/side_bar.html [modify] https://crrev.com/3798937bc576f5408b0d8a7b8789320acaeb821b/chrome/browser/resources/md_history/side_bar.js [modify] https://crrev.com/3798937bc576f5408b0d8a7b8789320acaeb821b/chrome/test/data/webui/md_history/history_routing_test.js
,
Aug 24 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by ranjitkan@chromium.org
, Aug 19 2016