New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 639284 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Nov 2017
Cc:
nyerramilli@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: [DevTools] RHS border of text box is missing under 'Watch' section.

Reported by dchau...@etouch.net, Aug 19 2016 
Chrome Version: 54.0.2832.2 (Official Build) 373f6bdd42a605a49fa170b2bcdbae3fbd015acc-refs/branch-heads/2832@{#3} (32/64-bit)
OS: Mac(10.10.5)(10.11.5), Windows(7,8,8.1,10), Linux(14.04 LTS)

What steps will reproduce the problem?
1. Launch chrome, open 'DevTools' and go to 'Sources' section.
2. Go to 'Watch' section, click on '+' icon to open text box and observe.

RHS border of textbox is missing.
RHS border of textbox should seen properly.

This is a regression issue, broken in M-54 series, below is bisect info.

Good build: 54.0.2802.0
Bad build: 54.0.2803.0

Narrow bisect:
https://chromium.googlesource.com/chromium/src/+log/d149b80d547b9766d90159f80e931005acf1b433..ae9bccd603ed3d867557a0ec4231bccf67640223?pretty=fuller&n=100

Suspecting: r406484

Kindly review the attached screen-cast for reference.
Actual behavior.mp4
563 KB View Download
Expectedl behavior.mp4
863 KB View Download

Comment 1 by sureshkumari@chromium.org, Nov 16 2016

Labels: -hasbisect hasbisect-per-revision
Just updating the hasbisect-per-revision information.

Change Log URL:
-------------- 
https://chromium.googlesource.com/chromium/src/+log/e080ea95241ea911fa5b97e27b18308ed4d8c1ae..ca00017577716b2aa19bda3382fb88c2f7c80a1b

From the above change log suspecting below change

Review url:https://codereview.chromium.org/2157713002

pfeldman@ Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks..

Comment 2 by pfeldman@chromium.org, Oct 4 2017

Owner: l...@chromium.org

Comment 3 by l...@chromium.org, Oct 4 2017

Labels: -Pri-1 Hotlist-Polish Pri-2
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f707616d6ea7777d21c9bb4ace3ec47b8844c454

commit f707616d6ea7777d21c9bb4ace3ec47b8844c454
Author: Erik Luo <luoe@chromium.org>
Date: Thu Nov 09 18:47:52 2017

DevTools: add right margin to object/watch expression prompts

Add some margin so the watch expression prompt does not go off screen.
Today, text can overflow outside of the prompt, so we should hide
overflow.

Screenshot: https://imgur.com/a/pQfSV

Bug:  639284 
Change-Id: Ib23fc2561ce6895164850474788279e9889fe53d
Reviewed-on: https://chromium-review.googlesource.com/759426
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515225}
[modify] https://crrev.com/f707616d6ea7777d21c9bb4ace3ec47b8844c454/third_party/WebKit/Source/devtools/front_end/object_ui/ObjectPropertiesSection.js
[modify] https://crrev.com/f707616d6ea7777d21c9bb4ace3ec47b8844c454/third_party/WebKit/Source/devtools/front_end/object_ui/objectPropertiesSection.css
[modify] https://crrev.com/f707616d6ea7777d21c9bb4ace3ec47b8844c454/third_party/WebKit/Source/devtools/front_end/sources/watchExpressionsSidebarPane.css

Comment 5 by l...@chromium.org, Nov 9 2017

Status: Fixed (was: Assigned)

Comment 6 by dchau...@etouch.net, Nov 10 2017

Labels: TE-Verified-M64 TE-Verified-64.0.3264.0
Update:

Retested this issue on Windows(7,8,8.1,10), Linux(14.04 LTS) and Mac OS X(10.12.6 machines using latest Canary build # 64.0.3264.0 (Official Build) and fix is working as expected i.e. RHS border of textbox is seen properly.

Attaching screen-cast for the same.
Latest Canary behavior.mp4
465 KB View Download
►

Sign in to add a comment