CQ no longer posting "waiting for LGTM" messages |
||
Issue descriptionThe CQ has the ability for projects to configure whether it should wait for LGTMs. Skia has this enabled. When a CL does not have an LGTM yet it waits for a configurable amount of time after posting this message: """ Note for Reviewers: The CQ is waiting for an approval. If you believe that the CL is not ready yet, or if you would like to L-G-T-M with comments then please uncheck the CQ checkbox. Waiting for LGTM from valid reviewer(s) till 2016-07-09 02:20 UTC """ (from https://codereview.chromium.org/2133613004/) This seems to have stopped after around July 8th. Skia CLs no longer post this message and this makes it hard to figure out why the CL has not landed yet Eg: https://codereview.chromium.org/2254733008/#msg10 Could somebody please investigate how this functionality went away?
,
Aug 19 2016
So, git history says there was just 1 change to reviewer_lgtm verifier - my https://chromereviews.googleplex.com/468907014.
,
Aug 19 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/c4fdc357fd30d5a94869adc64eda593e4febd22f commit c4fdc357fd30d5a94869adc64eda593e4febd22f Author: tandrii <tandrii@google.com> Date: Fri Aug 19 20:38:26 2016
,
Aug 19 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/3713f2e821b731d3d8ff2151014f000d9f1bdeb7 commit 3713f2e821b731d3d8ff2151014f000d9f1bdeb7 Author: tandrii <tandrii@google.com> Date: Fri Aug 19 21:17:53 2016
,
Aug 19 2016
Verified that revert above was deployed and worked.
,
Aug 22 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/417adc5508bd46eb24c7792be37838b707ef53d7 commit 417adc5508bd46eb24c7792be37838b707ef53d7 Author: tandrii <tandrii@google.com> Date: Mon Aug 22 12:52:23 2016
,
Aug 22 2016
OK, and comments work now: https://codereview.chromium.org/2260323002#msg10 The only thing is i've marked the message auto-generated, and it shouldn't be because otherwise Rietveld hides it (thhough email is still sent), and that's not very userfriendly. Fix: https://chromereviews.googleplex.com/486537014
,
Aug 22 2016
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal.git/+/7eda5ae285e748a41d45a3f783b92e9ebeab15cc commit 7eda5ae285e748a41d45a3f783b92e9ebeab15cc Author: tandrii <tandrii@google.com> Date: Mon Aug 22 13:30:11 2016
,
Aug 22 2016
,
Aug 22 2016
Thanks for the quick fix!! |
||
►
Sign in to add a comment |
||
Comment 1 by tandrii@chromium.org
, Aug 19 2016Status: Started (was: Untriaged)