New issue
Advanced search Search tips

Issue 639273 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

MediaControls computeWhichControlsFit() is called too often

Project Member Reported by mlamouri@chromium.org, Aug 19 2016

Issue description

It seems that leaving a page idle will still produce a lot of calls to computeWhichControlsFit(). We should either reduce these calls or add optimisation to early return.
 

Comment 1 by w...@chromium.org, Jan 17 2017

Labels: Hotlist-Media-UX
Owner: steimel@chromium.org
Status: Assigned (was: Available)
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fb1451de0171f8bdd0915c22016750d79c0b3ac

commit 6fb1451de0171f8bdd0915c22016750d79c0b3ac
Author: steimel <steimel@chromium.org>
Date: Wed Feb 15 00:24:19 2017

Remove unnecessary refreshCastButtonVisiblity call

computeWhichControlsFit is being called on every mousemove event on a video
(via a call to refreshCastButtonVisiblity). After discussing offline with
mlamouri@ and avayvod@, it was determined that the call to
refreshCastButtonVisiblity is no longer needed, and therefore can be removed.

In addition, this CL refactors some media layout tests that test the cast button visibility, and appends to an existing cast button visibility test (controls-cast-button-narrow.html) to test for correct visibility after expanding and contracting a video.

BUG= 639273 

Review-Url: https://codereview.chromium.org/2684973004
Cr-Commit-Position: refs/heads/master@{#450524}

[modify] https://crrev.com/6fb1451de0171f8bdd0915c22016750d79c0b3ac/third_party/WebKit/LayoutTests/media/controls-cast-button-narrow.html
[modify] https://crrev.com/6fb1451de0171f8bdd0915c22016750d79c0b3ac/third_party/WebKit/LayoutTests/media/controls-cast-button.html
[modify] https://crrev.com/6fb1451de0171f8bdd0915c22016750d79c0b3ac/third_party/WebKit/LayoutTests/media/controls-overlay-cast-button.html
[modify] https://crrev.com/6fb1451de0171f8bdd0915c22016750d79c0b3ac/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/6fb1451de0171f8bdd0915c22016750d79c0b3ac/third_party/WebKit/Source/core/html/shadow/MediaControls.cpp

Status: Fixed (was: Started)
We can't find other obvious spam call to the method so closing this.

Thank you steimel@ for the fix :)

Sign in to add a comment