New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639225 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Concatenate file manager's background scripts.

Project Member Reported by fukino@chromium.org, Aug 19 2016

Issue description

We have listed many background scripts in manifest.json.
https://codesearch.chromium.org/chromium/src/ui/file_manager/file_manager/manifest.json?l=198

Concatenating them into one script will save the resource ids for scripts, and can reduce some overhead.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d19f48706428300449ca4aed64b764bd23c69da7

commit d19f48706428300449ca4aed64b764bd23c69da7
Author: fukino <fukino@chromium.org>
Date: Tue Aug 23 06:08:46 2016

Files app: Concatenate background scripts.

Concatenate scripts to:
- Reduce HTTP requests in background script.
- Save resource IDs.
- Make it easier to divide JS files into smaller ones.

The size of file_manager_resources.pak increases by 24 KB (4,187 KB => 4,211 KB),
but I think it worth doing.

BUG= 639225 , 636289 
TEST=run browser_tests

Review-Url: https://codereview.chromium.org/2261043003
Cr-Commit-Position: refs/heads/master@{#413677}

[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/audio_player/js/background_scripts.js
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/audio_player/manifest.json
[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/file_manager/background/js/background_common_scripts.js
[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/file_manager/background/js/background_scripts.js
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/file_manager/manifest.json
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/file_manager_resources.grd
[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/gallery/js/background_scripts.js
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/gallery/manifest.json
[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/image_loader/background_scripts.js
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/image_loader/manifest.json
[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/video_player/js/background_scripts.js
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/video_player/manifest.json

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d19f48706428300449ca4aed64b764bd23c69da7

commit d19f48706428300449ca4aed64b764bd23c69da7
Author: fukino <fukino@chromium.org>
Date: Tue Aug 23 06:08:46 2016

Files app: Concatenate background scripts.

Concatenate scripts to:
- Reduce HTTP requests in background script.
- Save resource IDs.
- Make it easier to divide JS files into smaller ones.

The size of file_manager_resources.pak increases by 24 KB (4,187 KB => 4,211 KB),
but I think it worth doing.

BUG= 639225 , 636289 
TEST=run browser_tests

Review-Url: https://codereview.chromium.org/2261043003
Cr-Commit-Position: refs/heads/master@{#413677}

[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/audio_player/js/background_scripts.js
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/audio_player/manifest.json
[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/file_manager/background/js/background_common_scripts.js
[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/file_manager/background/js/background_scripts.js
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/file_manager/manifest.json
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/file_manager_resources.grd
[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/gallery/js/background_scripts.js
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/gallery/manifest.json
[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/image_loader/background_scripts.js
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/image_loader/manifest.json
[add] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/video_player/js/background_scripts.js
[modify] https://crrev.com/d19f48706428300449ca4aed64b764bd23c69da7/ui/file_manager/video_player/manifest.json

Comment 3 by fukino@chromium.org, Aug 23 2016

Status: Fixed (was: Started)
Labels: VerifyIn-54

Comment 5 by dchan@chromium.org, Oct 7 2016

Labels: VerifyIn-55
Status: Verified (was: Fixed)
closing

Sign in to add a comment