New issue
Advanced search Search tips

Issue 639213 link

Starred by 1 user
Status: Fixed
Owner:
xiaoche...@chromium.org
Closed: Aug 2016
Cc:
yosin@chromium.org
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocking:
issue 638152



Sign in to add a comment

Tests unrelated to spell checking should not be affected by spell checker

Project Member Reported by xiaoche...@chromium.org, Aug 19 2016 
We are tired of rebaselining layout tests that are not related to spell checking, but have to be rebaselined because of the appearance/disappearance of misspelling markers in their pixel results.

A typical example is "foo", which appears in almost all layout tests. Every time we do some change to the spell checker, the misspelling markers appear in some tests and disappear in some other tests, while none of these tests are for spell checking.

We should make sure that we see spelling markers in the pixel results only when we are intentionally testing the spell checker. For this purpose, we should ensure that MockSpellCheck's list of misspelled words contains only some very special strings that cannot appear in other tests.

Comment 1 by xiaoche...@chromium.org, Aug 19 2016

Cc: yosin@chromium.org
+yosin

WDYT?

Comment 2 by xiaoche...@chromium.org, Aug 19 2016

Summary: Tests related to spell checking to specify by themselves what words are misspelled (was: Remove common strings (e.g., "foo") from MockSpellCheck's list of misspelled words)
Talked to yosin@ offline.

A better way is to let tests specify what words are misspelled, instead of having a hard coded list in MockSpellCheck. MockSpellCheck should just start with an empty list, and it should be the tests themselves to populate this list.

For example, if a test wants to test spelling markers under "asdf", it should run something like |internals.addMisspelledWord('asdf')| at its beginning so that MockSpellCheck returns 'asdf' as a misspelled word. Tests unrelated to spell checking do not populate the list, and hence, will not be affected be spell checker.

Comment 3 by groby@chromium.org, Aug 19 2016 

Why don't test just switch off spell checking by default, and the spellcheck tests turn it on?

That does break the general dependency of those tests on whatever spellcheck does, while addMisspelledWord relies on MockSpellCheck never gaining an additional way to flag items. (It's unlikely that will happen, so the approach in c#2 is still a great improvement - I'm just wondering why we don't make use of the already-existing flag to turn off checking)

Comment 4 by xiaoche...@chromium.org, Aug 22 2016

Blocking: 638152

Comment 5 by xiaoche...@chromium.org, Aug 22 2016

Summary: Tests unrelated to spell checking should not be affected by spell checker (was: Tests related to spell checking to specify by themselves what words are misspelled)
#3 seems to be a neat and much easier approach.

Trying it here: crrev.com/2268503003

Comment 6 by yosin@chromium.org, Aug 23 2016 

Please enable spelling checker on default, since Chrome enables spell checking by default.

Even if texts aren't marked, we would like to verify the path for spell checking.

Comment 7 by xiaoche...@chromium.org, Aug 24 2016 

I think I have an approach that utilizes existing code as much as possible, and still keeps spell checking code paths tested:

Add a switch to test runner's |SpellCheckClient| class, so that it performs checking only when the switch is on, and returns empty result when it's off. The switch is off by default and set to false in |TestRunner::Reset|. Spell checking tests can manually set it on by |testRunner.setMockSpellCheckerEnabled(true)|.

Trying here: http://crrev.com/2270293003
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fa3e76400d5f0fcc39eea19f9818599a3ea5016

commit 2fa3e76400d5f0fcc39eea19f9818599a3ea5016
Author: xiaochengh <xiaochengh@chromium.org>
Date: Wed Aug 24 11:27:04 2016

Add a switch to TestRunner to enable/disable mock spell checker

Most layout tests are not related to spell checker, and we do not want
to see failures due to appearance/disappearance of spelling markers in
their pixel results.

This patch adds a switch to TestRunner (more specifically, its
SpellCheckClient) so that the mock spell checker returns non-empty result
only when the switch is on. It is off by default, and hence, spelling
markers do not appear in unrelated tests. Spell checking tests are modified
to explicitly set this switch on so their results remain the same as before.

The following tests are rebaselined to remove the spelling markers from their
pixel results:
- compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html
- editing/execCommand/5569741.html
- editing/inserting/5418891.html
- editing/inserting/insert-div-027.html
- editing/inserting/paragraph-separator-01.html
- editing/inserting/paragraph-separator-02.html
- editing/inserting/paragraph-separator-03.html
- editing/inserting/return-key-with-selection-003.html
- editing/pasteboard/cut-text-001.html
- editing/pasteboard/undoable-fragment-removes.html
- editing/selection/move-backwords-by-word-001.html
- editing/selection/move-by-word-001.html
- editing/style/block-styles-007.html
- fast/dom/blur-contenteditable.html
- fast/dom/focus-contenteditable.html
- fast/forms/text/input-double-click-selection-gap-bug.html
- fast/inline-block/14498-positionForCoordinates.html
- fast/repaint/inline-outline-repaint.html
- virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html

BUG= 639213 

Review-Url: https://codereview.chromium.org/2270293003
Cr-Commit-Position: refs/heads/master@{#414042}

[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/components/test_runner/spell_check_client.cc
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/components/test_runner/spell_check_client.h
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/components/test_runner/test_runner.cc
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/components/test_runner/test_runner.h
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/accessibility/misspellings.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/context-menu-suggestions.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/design-mode-spellcheck-off.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/grammar-edit-word.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/grammar-markers-hidpi.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/grammar-markers.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/grammar.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi-composited.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/inline-spelling-markers-hidpi.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/inline_spelling_markers.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/mark-empty-crash.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/markers-input-type-text.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/markers.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/mixed-paste-long.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/mixed-paste-short.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/move-cursor-to-misspelled-word.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/resources/util.js
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/right-click-no-renderer-crash.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/script-tests/spellcheck-paste.js
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/script-tests/spelling-attribute-at-child.js
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/script-tests/spelling-attribute-change.js
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/script-tests/spelling-backspace-between-lines.js
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/script-tests/spelling-hasspellingmarker.js
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-api-crash.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-async-mutation.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-async-remove-frame.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-async.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-attribute.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-disable-enable.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-editable-on-focus-multiframe.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-editable-on-focus-sync.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-editable-on-focus.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-input-search-crash.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-mixed-editable-crash.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-mixed-editable-long-text-crash.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-queue.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spellcheck-sequencenum.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spelling-backward.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spelling-huge-text.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spelling-linebreak.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spelling-marker-description.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spelling-unified-emulation.html
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/editing/spelling/spelling.html
[delete] https://crrev.com/07b0c0a38a4d33cd72af233db22b6fc51b65795a/third_party/WebKit/LayoutTests/platform/android/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[delete] https://crrev.com/07b0c0a38a4d33cd72af233db22b6fc51b65795a/third_party/WebKit/LayoutTests/platform/android/fast/dom/blur-contenteditable-expected.png
[delete] https://crrev.com/07b0c0a38a4d33cd72af233db22b6fc51b65795a/third_party/WebKit/LayoutTests/platform/android/fast/forms/text/input-double-click-selection-gap-bug-expected.png
[delete] https://crrev.com/07b0c0a38a4d33cd72af233db22b6fc51b65795a/third_party/WebKit/LayoutTests/platform/android/fast/inline-block/14498-positionForCoordinates-expected.png
[delete] https://crrev.com/07b0c0a38a4d33cd72af233db22b6fc51b65795a/third_party/WebKit/LayoutTests/platform/android/fast/repaint/inline-outline-repaint-expected.png
[delete] https://crrev.com/07b0c0a38a4d33cd72af233db22b6fc51b65795a/third_party/WebKit/LayoutTests/platform/android/virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/editing/execCommand/5569741-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/5418891-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/insert-div-027-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/paragraph-separator-01-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/paragraph-separator-02-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/paragraph-separator-03-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/editing/inserting/return-key-with-selection-003-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/cut-text-001-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/editing/pasteboard/undoable-fragment-removes-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/editing/selection/move-backwords-by-word-001-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/editing/selection/move-by-word-001-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/editing/style/block-styles-007-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/fast/dom/blur-contenteditable-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/fast/dom/focus-contenteditable-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/fast/forms/text/input-double-click-selection-gap-bug-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/fast/inline-block/14498-positionForCoordinates-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/fast/repaint/inline-outline-repaint-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/linux/virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac-mac10.10/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac-mac10.10/editing/inserting/paragraph-separator-03-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/text/input-double-click-selection-gap-bug-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac-mac10.10/virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac-mac10.9/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/dom/focus-contenteditable-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/text/input-double-click-selection-gap-bug-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/editing/execCommand/5569741-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/5418891-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/insert-div-027-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/paragraph-separator-01-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/paragraph-separator-02-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/paragraph-separator-03-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/editing/inserting/return-key-with-selection-003-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/cut-text-001-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/editing/pasteboard/undoable-fragment-removes-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/editing/selection/move-backwords-by-word-001-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/editing/selection/move-by-word-001-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/editing/style/block-styles-007-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/fast/dom/blur-contenteditable-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/fast/dom/focus-contenteditable-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/fast/forms/text/input-double-click-selection-gap-bug-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/fast/inline-block/14498-positionForCoordinates-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/fast/repaint/inline-outline-repaint-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/mac/virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/editing/execCommand/5569741-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/editing/inserting/5418891-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/editing/inserting/insert-div-027-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/editing/inserting/paragraph-separator-01-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/editing/inserting/paragraph-separator-02-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/editing/inserting/paragraph-separator-03-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/editing/inserting/return-key-with-selection-003-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/cut-text-001-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/editing/pasteboard/undoable-fragment-removes-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/editing/selection/move-backwords-by-word-001-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/editing/selection/move-by-word-001-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/editing/style/block-styles-007-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/fast/dom/blur-contenteditable-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/fast/dom/focus-contenteditable-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/fast/forms/text/input-double-click-selection-gap-bug-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/fast/inline-block/14498-positionForCoordinates-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/fast/repaint/inline-outline-repaint-expected.png
[modify] https://crrev.com/2fa3e76400d5f0fcc39eea19f9818599a3ea5016/third_party/WebKit/LayoutTests/platform/win/virtual/prefer_compositing_to_lcd_text/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents-expected.png

Comment 9 by xiaoche...@chromium.org, Aug 25 2016

Status: Fixed (was: Assigned)

Comment 10 by lafo...@chromium.org, Apr 27 2017

Components: -UI>Browser>Spellcheck UI>Browser>Language>Spellcheck
►

Sign in to add a comment