New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 639208 link

Starred by 1 user
Status: Fixed
Owner:
finnur@chromium.org
Closed: Aug 2016
Cc:
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
█ dschuyler@chromium.org
█ durga.behera@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to Clear and Reset Exceptions in Site details page

Project Member Reported by sc00335...@techmahindra.com, Aug 19 2016 
Version: 54.0.2832.2 dev
OS:Ubuntu 14.04,Windows

What steps will reproduce the problem?
(1) Launch chrome and go to chrome://md-settings/siteSettings >> Select any section like Cookies/Plugins etc.. >> Add Exception >> Click on that exception and try deleting that exception by clicking clear and reset button.

Expected: Should be able to clear exception.
Actual: Instead it navigates to All sites page on clicking reset and clear button and unable to delete exception.

This is a regression issue broken in M54. Will provide bisect info soon.
Actual_clear and reset.ogv
1.8 MB View Download

Comment 1 by sc00335...@techmahindra.com, Aug 19 2016

Labels: -Needs-Bisect hasbisect
Owner: finnur@chromium.org
Status: Assigned (was: Unconfirmed)
Good Build: 54.0.2824.0 dev
Bad Build: 54.0.2825.0 dev

CHANGELOG URL:
 https://chromium.googlesource.com/chromium/src/+log/f6c9b6f8d1880e0746a1e7cd1712d8c541264cdd..82e5d1649102d7bc18c98d3330396c5821eeea25

Suspecting https://codereview.chromium.org/2226613003 from changelog.

@finnur: Please confirm the issue and help in re-assigning if it is not related to your change.
Expected_clear and reset.ogv
2.3 MB View Download

Comment 2 Deleted

Comment 3 by durga.behera@chromium.org, Aug 19 2016

Labels: Proj-MaterialDesign-WebUI

Comment 4 by durga.behera@chromium.org, Aug 19 2016

Labels: OS-Mac
Able to reproduce the issue on Mac 10.11.6 using 54.0.2832.2.

Comment 5 by ajha@chromium.org, Aug 23 2016

Cc: dschuyler@chromium.org
finnur@: Could you please take a look and update the thread accordingly.

Comment 6 by finnur@chromium.org, Aug 23 2016 

I can reproduce this, but I think this is two separate bugs.

Firstly, it is not deleting Cookie exceptions. That could be because of my change (I'll take a look).

Secondly, it is not navigating back correctly. I suspect that is due to:
https://codereview.chromium.org/2226003002/diff/1/chrome/browser/resources/settings/site_settings/site_details.js#newcode92

Comment 7 by dschuyler@chromium.org, Aug 23 2016 

Finnur, should the Status on this be Started (I'm asking because of the note "I'll take a look").

Comment 8 by finnur@chromium.org, Aug 24 2016 

Yes indeed. Thank you.

It is in your review queue now. :)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58420c6d82b10a7d1fcd636694f8b50dae3b3f3b

commit 58420c6d82b10a7d1fcd636694f8b50dae3b3f3b
Author: finnur <finnur@chromium.org>
Date: Fri Aug 26 13:41:27 2016

Site Settings Desktop: Fix bug with deleting manually added exceptions.

This is accomplished by using the embedderOrigin more
consistently throughout.

BUG= 639208 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2269963003
Cr-Commit-Position: refs/heads/master@{#414698}

[modify] https://crrev.com/58420c6d82b10a7d1fcd636694f8b50dae3b3f3b/chrome/browser/resources/settings/site_settings/add_site_dialog.js
[modify] https://crrev.com/58420c6d82b10a7d1fcd636694f8b50dae3b3f3b/chrome/browser/resources/settings/site_settings/site_details.js
[modify] https://crrev.com/58420c6d82b10a7d1fcd636694f8b50dae3b3f3b/chrome/browser/resources/settings/site_settings/site_details_permission.js
[modify] https://crrev.com/58420c6d82b10a7d1fcd636694f8b50dae3b3f3b/chrome/browser/resources/settings/site_settings/site_list.js
[modify] https://crrev.com/58420c6d82b10a7d1fcd636694f8b50dae3b3f3b/chrome/browser/resources/settings/site_settings/site_settings_behavior.js
[modify] https://crrev.com/58420c6d82b10a7d1fcd636694f8b50dae3b3f3b/chrome/browser/ui/webui/settings/site_settings_handler.cc
[modify] https://crrev.com/58420c6d82b10a7d1fcd636694f8b50dae3b3f3b/chrome/test/data/webui/settings/site_details_permission_tests.js
[modify] https://crrev.com/58420c6d82b10a7d1fcd636694f8b50dae3b3f3b/content/public/test/test_web_ui.cc
[modify] https://crrev.com/58420c6d82b10a7d1fcd636694f8b50dae3b3f3b/content/public/test/test_web_ui.h

Comment 10 by finnur@chromium.org, Aug 26 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment