New issue
Advanced search Search tips

Issue 639198 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Printing with same fonts does not support bold

Reported by 3ue...@gmail.com, Aug 19 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.3; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/52.0.2743.116 Safari/537.36

Example URL:

Steps to reproduce the problem:
Install the font Eurostele-Roman-DTC
Open the testpage NewFile.html
Print the page

What is the expected behavior?
Chrome printed the first Hallo with normal weight and the next three with bold weight.

What went wrong?
All four Hallos are printed with normal weight

Does it occur on multiple sites: Yes

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? Yes 

Chrome version: 52.0.2743.116  Channel: stable
OS Version: 6.3
Flash Version:
 
NewFile.html
366 bytes View Download

Comment 1 by junov@chromium.org, Aug 22 2016

Components: -Blink Internals>Printing Blink>Fonts

Comment 2 by e...@chromium.org, Aug 22 2016

Components: -Blink>Fonts
May be related to  bug 614612 .

Comment 4 by 3ue...@gmail.com, Sep 2 2016

Do you make any progress? 

I tried to search the reason for my own. I downloaded the source and compiled it successful. But Visual Studio crashed whenever I start to debug chromium. How do you debug and fix code under Windows what do you use??
Lack of comments usually means no.
Cc: halcanary@chromium.org
Status: Untriaged (was: Unconfirmed)
halcanary: Can you help take a look?
This is probably a Windows synthetic bold issue, but I can not yet be sure.

Please attach a PDF produced by the "Save As PDF" workflow.  https://github.com/HalCanary/howto-save-as-pdf 

Comment 8 by 3ue...@gmail.com, Sep 13 2016

The PDF has the same problem.
BoldProblemExample.pdf
8.9 KB Download
Owner: bunge...@chromium.org
Yep, that looks like the synthetic bold typeface problem.  I see two identical fonts embedded, so Skia's font manager assigns them different fontIDs, they rasterize differently, but SkTypeface::openStream returns the same data.

SkTypeface::onGetAdvancedTypefaceMetrics() should return kOther_Font for these synthetic typefaces.
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 13 2016

The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/0b7758236ca81337aa465a9f61cf466f03718862

commit 0b7758236ca81337aa465a9f61cf466f03718862
Author: bungeman <bungeman@google.com>
Date: Tue Sep 13 21:03:54 2016

Simulated fonts aren't TrueType fonts.

Some font back-ends provide simulated fonts such as fake bold or fake
oblique. These fonts should not be reported as TrueType, since the font
data isn't what is actually used to draw the glyphs.

BUG= chromium:639198 
BUG= chromium:614612 
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2333423002

Review-Url: https://codereview.chromium.org/2333423002

[modify] https://crrev.com/0b7758236ca81337aa465a9f61cf466f03718862/src/ports/SkFontMgr_fontconfig.cpp
[modify] https://crrev.com/0b7758236ca81337aa465a9f61cf466f03718862/src/ports/SkTypeface_win_dw.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afd01f9796e6267b5ca702e74be2043c610f3f7e

commit afd01f9796e6267b5ca702e74be2043c610f3f7e
Author: skia-deps-roller <skia-deps-roller@chromium.org>
Date: Wed Sep 14 01:07:45 2016

Roll src/third_party/skia/ cecd617a4..21cc9950c (6 commits).

https://chromium.googlesource.com/skia.git/+log/cecd617a4297..21cc9950c4b4

$ git log cecd617a4..21cc9950c --date=short --no-merges --format='%ad %ae %s'
2016-09-13 mikejurka re-add SkDebug_stdio for Fuchsia builds
2016-09-13 bungeman Simulated fonts aren't TrueType fonts.
2016-09-13 fmalita [SVGDom] Linear gradient 'gradientTransform' support
2016-09-13 mtklein Update gn_android_flavor for Vulkan.
2016-09-13 jcgregorio No \n in bench names.
2016-09-13 mtklein Android GN: don't reboot before running

BUG= 639198 

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=djsollen@google.com

Review-Url: https://codereview.chromium.org/2336233003
Cr-Commit-Position: refs/heads/master@{#418442}

[modify] https://crrev.com/afd01f9796e6267b5ca702e74be2043c610f3f7e/DEPS

Status: Fixed (was: Untriaged)
Fixed, needing verification.
As in, fixed in 55.0.2861.0 and newer. i.e. Check Chrome Canary in a day or two.

Comment 14 by 3ue...@gmail.com, Sep 19 2016

It looks OK, thank you for the fast bugfixing.

Sign in to add a comment