fast/repaint/align-self-change-keeping-geometry-grid.html and fast/repaint/justify-self-change-keeping-geometry.html are failing on WebKit Win7 and WebKit Win7(dbg) |
|||||
Issue descriptionTests are failing: webkit_tests fast/repaint/align-self-change-keeping-geometry-grid.html https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Frepaint%2Falign-self-change-keeping-geometry-grid.html&testType=webkit_tests webkit_tests fast/repaint/justify-self-change-keeping-geometry.html https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Frepaint%2Fjustify-self-change-keeping-geometry.html&testType=webkit_tests Revision range: Failing builders: WebKit Win7: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7 WebKit Win7 (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg)
,
Aug 19 2016
Still failing: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/45088 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/6970
,
Aug 19 2016
Assigning to the author of https://codereview.chromium.org/2254953002/ (which triggered the apparently bad rebaseline https://codereview.chromium.org/2260013002). I'm going to disable these tests on Win7 for now.
,
Aug 19 2016
,
Aug 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/548ac5dc24f475f3f10ea2486cda91339f24aaed commit 548ac5dc24f475f3f10ea2486cda91339f24aaed Author: treib <treib@chromium.org> Date: Fri Aug 19 13:05:37 2016 Mark fast/repaint/align-self and justify-self as flaky on Win7 BUG= 639196 TBR=schenney@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2264573002 Cr-Commit-Position: refs/heads/master@{#413121} [modify] https://crrev.com/548ac5dc24f475f3f10ea2486cda91339f24aaed/third_party/WebKit/LayoutTests/TestExpectations
,
Aug 19 2016
I don't mind having these tests rebaselined, and disabled in Win7, because I'm working on the proper fix to make these tests use the correct expectations and enabled on all platforms. However, I think we should keep them as disabled in all platforms based on bug #474798 , using the previous expectations with empty invalidation regions.
,
Aug 19 2016
It's Chromium policy to rebaseline tests even if the result is wrong provided there is a tracking bug, as there is for these. Tests that don't trigger failure on changes cause us to miss changes in behavior, and on multiple occasions we've seen regressions get missed due to disabled tests. Any change in behavior should show up as a change in test outcomes, even if it's a positive change.
,
Aug 23 2016
This issue should be FIXED now and all the Alignment repainting tests enabled again. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jfernan...@igalia.com
, Aug 19 2016