Enable RenderTextHarfbuzz tests on Mac. |
||
Issue descriptionCurrently, most tests in render_text_unittest.cc use RenderText::CreateInstance(), which will run the test for RenderTextMac. Change the tests, so that on Mac, these tests are run both on RenderTextMac and RenderTextHarfBuzz.
,
Aug 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50b6fa15b332c7f049069a1f569ca1e374462601 commit 50b6fa15b332c7f049069a1f569ca1e374462601 Author: karandeepb <karandeepb@chromium.org> Date: Fri Aug 26 03:25:53 2016 Use parameterized tests to test multiple render text implementations. Currently, on Mac most of the tests in render_text_unittest.cc use RenderText::CreateInstance to create their render text instance. Also, many tests which would fail on Mac with RenderTextMac are not compiled on Mac. As a result there is negligible test coverage for RenderTextHarfBuzz on Mac. This CL uses parameterized tests to test both RenderTextMac and RenderTextHarfBuzz on Mac. It does this by introducing three new test fixture classes which support parameterized tests- -RenderTextTest -RenderTextHarfBuzzTest -RenderTextMacTest The test helper class RenderTextAllBackends is removed. Before this CL, 65 tests in render_text_unittest.cc are run on Mac. After this CL, a total of 129 tests in render_text_unittest.cc are run on Mac. BUG= 639194 Review-Url: https://codereview.chromium.org/2251893004 Cr-Commit-Position: refs/heads/master@{#414644} [modify] https://crrev.com/50b6fa15b332c7f049069a1f569ca1e374462601/tools/valgrind/gtest_exclude/ui_base_unittests.gtest-memcheck.txt [modify] https://crrev.com/50b6fa15b332c7f049069a1f569ca1e374462601/ui/gfx/platform_font_win.h [modify] https://crrev.com/50b6fa15b332c7f049069a1f569ca1e374462601/ui/gfx/render_text.h [modify] https://crrev.com/50b6fa15b332c7f049069a1f569ca1e374462601/ui/gfx/render_text_harfbuzz.cc [modify] https://crrev.com/50b6fa15b332c7f049069a1f569ca1e374462601/ui/gfx/render_text_harfbuzz.h [modify] https://crrev.com/50b6fa15b332c7f049069a1f569ca1e374462601/ui/gfx/render_text_mac.h [modify] https://crrev.com/50b6fa15b332c7f049069a1f569ca1e374462601/ui/gfx/render_text_unittest.cc
,
Aug 26 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by karandeepb@chromium.org
, Aug 19 2016