New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 639182 link

Starred by 0 users
Status: Fixed
Owner:
█ halliwell@chromium.org
Last visit > 30 days ago
Closed: Aug 2016
Cc:
dcasta...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Chromecast video playback broken

Project Member Reported by halliwell@chromium.org, Aug 19 2016 
To repro, play any video on a Chromecast device build.

Breakage comes from here: https://codereview.chromium.org/2162663003
since this change rejects non-opaque video frames, and it turns out that WMPI treats all video as non-opaque by default.

Comment 1 by dcasta...@chromium.org, Aug 19 2016 

Sorry. :/

Why does quad->ShouldDrawWithBlending() return true?
I'm assuming that quad doesn't really need blending.

Is quad->opaque_rect not set?

Comment 2 by halliwell@chromium.org, Aug 19 2016 

Right ... if you look in WMPI, opaque_ is initialized to false, and we never change that.

My CL sets opaque to true, although I don't understand why the default is false.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c3ec304053760c3439f6848fd624a3a9e7e8793

commit 9c3ec304053760c3439f6848fd624a3a9e7e8793
Author: halliwell <halliwell@chromium.org>
Date: Fri Aug 19 19:56:05 2016

[Chromecast] Set all video to opaque

Our video overlay codepath was broken here; this change rejects
non-opaque video frames for overlay:
https://codereview.chromium.org/2162663003

BUG= 639182 
TEST=manual

Review-Url: https://codereview.chromium.org/2257873004
Cr-Commit-Position: refs/heads/master@{#413219}

[modify] https://crrev.com/9c3ec304053760c3439f6848fd624a3a9e7e8793/chromecast/browser/media/cast_renderer.cc

Comment 4 by halliwell@chromium.org, Aug 19 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment