The following tests crash: webkit_tests compositing/reflections/nested-reflection-transformed.html https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Freflections%2Fnested-reflection-transformed.html&testType=webkit_tests webkit_tests compositing/reflections/nested-reflection-transformed2.html https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Freflections%2Fnested-reflection-transformed2.html&testType=webkit_tests webkit_tests compositing/reflections/reflection-in-composited.html https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=compositing%2Freflections%2Freflection-in-composited.html&testType=webkit_tests webkit_tests css3/filters/filter-repaint-shadow-rotated.html https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Ffilters%2Ffilter-repaint-shadow-rotated.html&testType=webkit_tests webkit_tests fast/css/transformed-mask.html https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fcss%2Ftransformed-mask.html&testType=webkit_tests webkit_tests fast/reflections/opacity-reflection-transform.html https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Freflections%2Fopacity-reflection-transform.html&testType=webkit_tests webkit_tests fast/repaint/reflection-repaint-test.html https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Frepaint%2Freflection-repaint-test.html&testType=webkit_tests Revision range: chromium 412947 : 412963 Failing builders: WebKit Win7 (dbg): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20(dbg) c.f. 17:03:27.063 3664 [1676:5284:0818/170326:4461425:INFO:skcanvas.cpp(1843)] e:\b\c\b\win\src\third_party\skia\src\core\skcanvas.cpp:1843: fatal error: "assert(fIsScaleTranslate == fMCRec->fMatrix.isScaleTranslate())" https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/276544/steps/webkit_tests%20%28with%20patch%29/logs/stdio
There's a Skia roll in the blame list, and https://skia.googlesource.com/skia/+/9637ea91b88ff8f8e95325bfc41417ffc4d5ee0b looks related. msarett, could you take a look?
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a6957723d980c818d451f51f926ad9f4a4378ad0 commit a6957723d980c818d451f51f926ad9f4a4378ad0 Author: treib <treib@chromium.org> Date: Fri Aug 19 12:09:42 2016 Disable broken WebKit tests on Win7 Debug BUG= 639179 TBR=msarett@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2263563002 Cr-Commit-Position: refs/heads/master@{#413114} [modify] https://crrev.com/a6957723d980c818d451f51f926ad9f4a4378ad0/third_party/WebKit/LayoutTests/TestExpectations
This looks like me - I'll investigate.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82d37bfa3a4947b5005b722ee96e83260f1b3c22 commit 82d37bfa3a4947b5005b722ee96e83260f1b3c22 Author: treib <treib@chromium.org> Date: Fri Aug 19 12:28:14 2016 Disable broken WebKit tests also on Mac10.11 and Linux Follow-up to https://codereview.chromium.org/2263563002/ BUG= 639179 TBR=msarett@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2254973007 Cr-Commit-Position: refs/heads/master@{#413117} [modify] https://crrev.com/82d37bfa3a4947b5005b722ee96e83260f1b3c22/third_party/WebKit/LayoutTests/TestExpectations
Fix is ready: https://codereview.chromium.org/2263513003/ Once it rolls into Chrome, I'll revert the CLs that disable the tests.
The following revision refers to this bug: https://skia.googlesource.com/skia.git/+/9da5a5a198e5dc9148f7f30a6089377590eee55b commit 9da5a5a198e5dc9148f7f30a6089377590eee55b Author: msarett <msarett@google.com> Date: Fri Aug 19 15:38:36 2016 Fix bug, always keep fIsScaleTranslate in correct state BUG:639179 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2263513003 Review-Url: https://codereview.chromium.org/2263513003 [modify] https://crrev.com/9da5a5a198e5dc9148f7f30a6089377590eee55b/src/core/SkCanvas.cpp [modify] https://crrev.com/9da5a5a198e5dc9148f7f30a6089377590eee55b/tests/QuickRejectTest.cpp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9eda0c10aa70db52f93af87bd346934dea7f4388 commit 9eda0c10aa70db52f93af87bd346934dea7f4388 Author: msarett <msarett@google.com> Date: Fri Aug 19 20:13:11 2016 Revert of Disable broken WebKit tests also on Mac10.11 and Linux (patchset #1 id:1 of https://codereview.chromium.org/2254973007/ ) Reason for revert: Bug should be fixed. Reenabling tests. Original issue's description: > Disable broken WebKit tests also on Mac10.11 and Linux > > Follow-up to https://codereview.chromium.org/2263563002/ > > BUG= 639179 > TBR=msarett@chromium.org > NOTRY=true > > Committed: https://crrev.com/82d37bfa3a4947b5005b722ee96e83260f1b3c22 > Cr-Commit-Position: refs/heads/master@{#413117} TBR=msarett@chromium.org,treib@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 639179 Review-Url: https://codereview.chromium.org/2260923002 Cr-Commit-Position: refs/heads/master@{#413225} [modify] https://crrev.com/9eda0c10aa70db52f93af87bd346934dea7f4388/third_party/WebKit/LayoutTests/TestExpectations
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/74392416c7254103ab86293f98c3c024105429e2 commit 74392416c7254103ab86293f98c3c024105429e2 Author: msarett <msarett@google.com> Date: Fri Aug 19 20:25:45 2016 Revert of Disable broken WebKit tests on Win7 Debug (patchset #1 id:1 of https://codereview.chromium.org/2263563002/ ) Reason for revert: Bug should be fixed. Reenabling tests. Original issue's description: > Disable broken WebKit tests on Win7 Debug > > BUG= 639179 > TBR=msarett@chromium.org > NOTRY=true > > Committed: https://crrev.com/a6957723d980c818d451f51f926ad9f4a4378ad0 > Cr-Commit-Position: refs/heads/master@{#413114} TBR=treib@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 639179 Review-Url: https://codereview.chromium.org/2263703002 Cr-Commit-Position: refs/heads/master@{#413228} [modify] https://crrev.com/74392416c7254103ab86293f98c3c024105429e2/third_party/WebKit/LayoutTests/TestExpectations
Issue 639551 has been merged into this issue.
The Skia CL: https://codereview.chromium.org/2263513003 (Fix bug, always keep fIsScaleTranslate in correct state) should've fixed this.
Comment 1 by treib@chromium.org
, Aug 19 2016Owner: msarett@chromium.org
Status: Assigned (was: Available)