Issue metadata
Sign in to add a comment
|
Interstitials are rendering in a tiny frame on Android |
||||||||||||||||||||
Issue descriptionInterstitials are rendering in a tiny corner of the screen on Android, starting with current dev channel (M54). If you pinch to zoom it becomes clear that the window size has been bounded as if it were in a small iframe (see 2nd screenshot). Possibly related to https://bugs.chromium.org/p/chromium/issues/detail?id=637462?
,
Aug 19 2016
I think it's likely to be related to issue 637462 , but I'm currently investigating another release blocker, so I'll probably only be able to look at this in the beginning of next week.
,
Aug 19 2016
This might also be an issue with dp to pixels conversion. You would have the same effect if you set PhysicalBackingSize with dp instead of pixels. This might be related with a patch khushalsagar@ landed recently if it is ToT only. https://codereview.chromium.org/2253313002/ should fix the issue, if that is the case.
,
Aug 22 2016
,
Aug 26 2016
re: #3 4c584d37669a3b2a4e0b80130cb61bad93b0e32e is in 54.0.2838.0 which is now in Canary and I am still seeing this bug on that version.
,
Aug 26 2016
yusuf@, I don't think that patch is related. The size there was being used only to decide whether a background layer should be added or not.
,
Aug 26 2016
Yeah, looks like it is not. I will have to take a look at this next week.
,
Aug 29 2016
Issue 638341 has been merged into this issue.
,
Sep 2 2016
[Bulk edit] This is marked as a beta blocker for Android M54. We're looking to ship that very soon, so please try to have this bug fixed no later than next Wednesday 9/7 so that it can be merged to branch 2840 ASAP. Know for sure this isn't a beta blocker? Remove the label (or retarget to stable if appropriate). Not sure if this should block beta or not? CC me and ask! Know this should block beta, but also know you won't be able to fix it in time? CC me and let me know ASAP. Thanks!
,
Sep 6 2016
,
Sep 7 2016
Hey felt@, neither myself nor tedchoc@ can repro this anymore - can you confirm and close this if you can't repro either?
,
Sep 7 2016
I can't repro on 55.0.2852.0. it would be nice to know which CL fixed this so 1. it doesn't regress again and 2. tests could be added.
,
Sep 7 2016
,
Sep 7 2016
It could be related ... it would be simple to create a build with this CL reverted to see if it fixes things. However, in that case I would have to pose the question as to why intersitials had the correct DSF in the first place, i.e. does Android have some different mechanism in place for setting DSF on interstitials that is now conflicting with this?
,
Sep 7 2016
Ooops, just finished reading backwards through the comments ... yes, https://crrev.com/26840c53c281e98b2f33a5e94aa7f04d372eb9c6 could well have fixed this.
,
Sep 9 2016
That CL was merged back to branch 2840, so I feel comfy marking this as fixed. Please feel free to continue discussion w.r.t. adding unit testing though.
,
Dec 9 2016
Security>UX component is deprecated in favor of the Team-Security-UX label |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by f...@chromium.org
, Aug 19 2016Owner: yus...@chromium.org
Status: Assigned (was: Available)