New issue
Advanced search Search tips

Issue 639147 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

svg/wicd/test-rightsizing-b.xhtml flaky on various waterfall bots

Project Member Reported by alex...@chromium.org, Aug 18 2016

Issue description

Sample builds:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/69150
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/13748

Sample text diff:
--- E:\b\rr\tmpvf9cz_\w\layout-test-results\svg/wicd/test-rightsizing-b-expected.txt
+++ E:\b\rr\tmpvf9cz_\w\layout-test-results\svg/wicd/test-rightsizing-b-actual.txt
@@ -54,26 +54,26 @@
     layer at (0,0) size 295x150
       LayoutBlockFlow {HTML} at (0,0) size 295x150
         LayoutBlockFlow {BODY} at (8,8) size 279x134
-layer at (347,97) size 147x148
-  LayoutEmbeddedObject {object} at (299.59,2) size 147.58x147.58 [bgcolor=#FF0000]
-    layer at (0,0) size 148x148
-      LayoutView at (0,0) size 148x148
-    layer at (0,0) size 148x148
-      LayoutSVGRoot {svg} at (0,0) size 148x148
+layer at (347,95) size 147x150
+  LayoutEmbeddedObject {object} at (299.59,0) size 147.58x150 [bgcolor=#FF0000]
+    layer at (0,0) size 148x150
+      LayoutView at (0,0) size 148x150
+    layer at (0,0) size 148x150
+      LayoutBlockFlow {HTML} at (0,0) size 148x150
+        LayoutBlockFlow {BODY} at (8,8) size 132x134
+layer at (499,171) size 73x74
+  LayoutEmbeddedObject {object} at (451.61,76) size 73.78x73.78 [bgcolor=#FF0000]
+    layer at (0,0) size 74x74
+      LayoutView at (0,0) size 74x74
+    layer at (0,0) size 74x74
+      LayoutSVGRoot {svg} at (0,0) size 74x74
         LayoutSVGHiddenContainer {defs} at (0,0) size 0x0
-        LayoutSVGRect {rect} at (0,0) size 148x148 [fill={[type=SOLID] [color=#5588FF]}] [x=-3000.00] [y=-1000.00] [width=6200.00] [height=2200.00]
-        LayoutSVGEllipse {circle} at (0,0) size 148x148 [fill={[type=SOLID] [color=#0000FF]}] [cx=100.00] [cy=100.00] [r=100.00]
-        LayoutSVGContainer {g} at (22,46) size 105x58
-          LayoutSVGText {text} at (29,62) size 142x78 contains 1 chunk(s)
-            LayoutSVGInlineText {#text} at (0,0) size 141x78
+        LayoutSVGRect {rect} at (0,0) size 74x74 [fill={[type=SOLID] [color=#5588FF]}] [x=-3000.00] [y=-1000.00] [width=6200.00] [height=2200.00]
+        LayoutSVGEllipse {circle} at (0,0) size 74x74 [fill={[type=SOLID] [color=#0000FF]}] [cx=100.00] [cy=100.00] [r=100.00]
+        LayoutSVGContainer {g} at (11,23) size 52x30
+          LayoutSVGText {text} at (29,62) size 141x80 contains 1 chunk(s)
+            LayoutSVGInlineText {#text} at (0,0) size 141x79
               chunk 1 (middle anchor) text run 1 at (29.98,125.00) startOffset 0 endOffset 3 width 140.03: "SVG"
-layer at (499,95) size 73x150
-  LayoutEmbeddedObject {object} at (451.61,0) size 73.78x150 [bgcolor=#FF0000]
-    layer at (0,0) size 74x150
-      LayoutView at (0,0) size 74x150
-    layer at (0,0) size 74x150
-      LayoutBlockFlow {HTML} at (0,0) size 74x150
-        LayoutBlockFlow {BODY} at (8,8) size 58x134
 layer at (577,95) size 37x150
   LayoutEmbeddedObject {object} at (529.83,0) size 36.89x150 [bgcolor=#FF0000]
     layer at (0,0) size 37x150

I see that there was a recent rebaseline attempt in r412906, which is likely what started causing these failures.  schenney@, can you please take a look?  I'll mark this test as flaky again in the meantime.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d802ab200f8a926e415d575e42e0571aa12f56f

commit 0d802ab200f8a926e415d575e42e0571aa12f56f
Author: alexmos <alexmos@chromium.org>
Date: Fri Aug 19 00:08:45 2016

Mark svg/wicd/test-rightsizing-b.xhtml as flaky

BUG= 639147 
NOTRY=true
TBR=schenney@chromium.org

Review-Url: https://codereview.chromium.org/2256423002
Cr-Commit-Position: refs/heads/master@{#412980}

[modify] https://crrev.com/0d802ab200f8a926e415d575e42e0571aa12f56f/third_party/WebKit/LayoutTests/TestExpectations

Comment 2 by f...@opera.com, Aug 22 2016

We have a bug for this flakiness already ( issue 444095 ), so consider duping and updating TestExpectations to point there instead.
Cc: japhet@chromium.org
 Issue 444095  has been merged into this issue.
I would rather leave this as the active bug, rather than mess with expectations some more.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25ace1cf28b7f2b6a1aaecd1416103c0ca6709b5

commit 25ace1cf28b7f2b6a1aaecd1416103c0ca6709b5
Author: fs <fs@opera.com>
Date: Tue Nov 29 11:56:14 2016

Update svg/wicd/test-rightsizing-b.xhtml expectations

Attempt to compensate for some recent changes to DRT output. Also try
to get some more "correct" reference images.

TBR=schenney@chromium.org
NOTRY=true
BUG= 639147 

Review-Url: https://codereview.chromium.org/2537083003
Cr-Commit-Position: refs/heads/master@{#434962}

[modify] https://crrev.com/25ace1cf28b7f2b6a1aaecd1416103c0ca6709b5/third_party/WebKit/LayoutTests/platform/linux/svg/wicd/test-rightsizing-b-expected.png
[modify] https://crrev.com/25ace1cf28b7f2b6a1aaecd1416103c0ca6709b5/third_party/WebKit/LayoutTests/platform/linux/svg/wicd/test-rightsizing-b-expected.txt
[modify] https://crrev.com/25ace1cf28b7f2b6a1aaecd1416103c0ca6709b5/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/wicd/test-rightsizing-b-expected.png
[modify] https://crrev.com/25ace1cf28b7f2b6a1aaecd1416103c0ca6709b5/third_party/WebKit/LayoutTests/platform/mac/svg/wicd/test-rightsizing-b-expected.png
[modify] https://crrev.com/25ace1cf28b7f2b6a1aaecd1416103c0ca6709b5/third_party/WebKit/LayoutTests/platform/win/svg/wicd/test-rightsizing-b-expected.png
[modify] https://crrev.com/25ace1cf28b7f2b6a1aaecd1416103c0ca6709b5/third_party/WebKit/LayoutTests/platform/win/svg/wicd/test-rightsizing-b-expected.txt
[modify] https://crrev.com/25ace1cf28b7f2b6a1aaecd1416103c0ca6709b5/third_party/WebKit/LayoutTests/platform/win7/svg/wicd/test-rightsizing-b-expected.txt

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c80903155fb3400934e2350dcbb7b5c4f6a7926

commit 7c80903155fb3400934e2350dcbb7b5c4f6a7926
Author: schenney <schenney@chromium.org>
Date: Fri Mar 17 22:42:54 2017

Update expectations for svg/wicd/test-rightsizing-b.xhtml

TBR=fs@opera.com
BUG= 639147 

Review-Url: https://codereview.chromium.org/2755713002
Cr-Commit-Position: refs/heads/master@{#457896}

[modify] https://crrev.com/7c80903155fb3400934e2350dcbb7b5c4f6a7926/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/7c80903155fb3400934e2350dcbb7b5c4f6a7926/third_party/WebKit/LayoutTests/platform/linux/svg/wicd/test-rightsizing-b-expected.png
[modify] https://crrev.com/7c80903155fb3400934e2350dcbb7b5c4f6a7926/third_party/WebKit/LayoutTests/platform/linux/svg/wicd/test-rightsizing-b-expected.txt
[modify] https://crrev.com/7c80903155fb3400934e2350dcbb7b5c4f6a7926/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/wicd/test-rightsizing-b-expected.png
[modify] https://crrev.com/7c80903155fb3400934e2350dcbb7b5c4f6a7926/third_party/WebKit/LayoutTests/platform/mac/svg/wicd/test-rightsizing-b-expected.png
[modify] https://crrev.com/7c80903155fb3400934e2350dcbb7b5c4f6a7926/third_party/WebKit/LayoutTests/platform/win/svg/wicd/test-rightsizing-b-expected.png
[modify] https://crrev.com/7c80903155fb3400934e2350dcbb7b5c4f6a7926/third_party/WebKit/LayoutTests/platform/win/svg/wicd/test-rightsizing-b-expected.txt
[delete] https://crrev.com/1584446da5f69aa0035eb628e4aedd48e328a9b3/third_party/WebKit/LayoutTests/platform/win7/svg/wicd/test-rightsizing-b-expected.txt
[modify] https://crrev.com/7c80903155fb3400934e2350dcbb7b5c4f6a7926/third_party/WebKit/LayoutTests/svg/wicd/test-rightsizing-b.xhtml

Status: Fixed (was: Assigned)

Sign in to add a comment