New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 639145 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
OOO until 2019-01-24
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocked on:
issue 649250
issue 664643

Blocking:
issue 295792
issue 665656



Sign in to add a comment

Implement new WebGL function entry points and overloads with offset and offset+length arguments

Project Member Reported by zmo@chromium.org, Aug 18 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Aug 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2f904fc2724f49084be34f7b730353a66770d8d4

commit 2f904fc2724f49084be34f7b730353a66770d8d4
Author: zmo <zmo@chromium.org>
Date: Tue Aug 23 05:20:45 2016

Implement buffer{Sub}Data overloads with sub source.

BUG= 639145 
TEST=webgl2_conformance
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2266563002
Cr-Commit-Position: refs/heads/master@{#413671}

[modify] https://crrev.com/2f904fc2724f49084be34f7b730353a66770d8d4/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/2f904fc2724f49084be34f7b730353a66770d8d4/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
[modify] https://crrev.com/2f904fc2724f49084be34f7b730353a66770d8d4/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33f717b1e3bf71f5001e08040a17024a9c6fa1b0

commit 33f717b1e3bf71f5001e08040a17024a9c6fa1b0
Author: zmo <zmo@chromium.org>
Date: Wed Aug 24 16:45:45 2016

Add Tex{Sub}Image function overloads with sub source.

This is first part, where function implementation is to be added later.

BUG= 639145 
TEST=gpu bots
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2270203002
Cr-Commit-Position: refs/heads/master@{#414090}

[modify] https://crrev.com/33f717b1e3bf71f5001e08040a17024a9c6fa1b0/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/33f717b1e3bf71f5001e08040a17024a9c6fa1b0/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
[modify] https://crrev.com/33f717b1e3bf71f5001e08040a17024a9c6fa1b0/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46768c6c985640e066946771aef2301e35f316f9

commit 46768c6c985640e066946771aef2301e35f316f9
Author: zmo <zmo@chromium.org>
Date: Thu Aug 25 05:34:44 2016

Implement tex{Sub}Image{2|3}D with ArrayBufferView sub source.

BUG= 639145 
TEST=https://github.com/KhronosGroup/WebGL/pull/1982
R=kbr@chromium.org,tkent@chromium.org,haraken@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2277603005
Cr-Commit-Position: refs/heads/master@{#414323}

[modify] https://crrev.com/46768c6c985640e066946771aef2301e35f316f9/third_party/WebKit/Source/core/dom/DOMArrayBufferView.h
[modify] https://crrev.com/46768c6c985640e066946771aef2301e35f316f9/third_party/WebKit/Source/core/dom/DOMDataView.cpp
[modify] https://crrev.com/46768c6c985640e066946771aef2301e35f316f9/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/46768c6c985640e066946771aef2301e35f316f9/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/46768c6c985640e066946771aef2301e35f316f9/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
[modify] https://crrev.com/46768c6c985640e066946771aef2301e35f316f9/third_party/WebKit/Source/wtf/typed_arrays/ArrayBufferView.h
[modify] https://crrev.com/46768c6c985640e066946771aef2301e35f316f9/third_party/WebKit/Source/wtf/typed_arrays/TypedArrayBase.h

Comment 4 by kbr@chromium.org, Sep 22 2016

Blockedon: 649250
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f32c007a212163867271de976999a32a02161209

commit f32c007a212163867271de976999a32a02161209
Author: kbr <kbr@chromium.org>
Date: Fri Sep 23 19:56:19 2016

Remove obsolete getBufferSubData compatibility entry points.

BUG= 639145 ,  649250 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2360353002
Cr-Commit-Position: refs/heads/master@{#420706}

[modify] https://crrev.com/f32c007a212163867271de976999a32a02161209/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/f32c007a212163867271de976999a32a02161209/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/f32c007a212163867271de976999a32a02161209/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
[modify] https://crrev.com/f32c007a212163867271de976999a32a02161209/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/936bf933e5b57ed08bc8ff211233a21783260615

commit 936bf933e5b57ed08bc8ff211233a21783260615
Author: kbr <kbr@chromium.org>
Date: Tue Nov 01 00:53:33 2016

Support 2D texture sub-source uploads from HTMLImageElement.

Covers both texImage2D and texSubImage2D.

Verified with new tests in https://github.com/KhronosGroup/WebGL/pull/2119 .

Other code paths will follow.

BUG= 639145 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2458943002
Cr-Commit-Position: refs/heads/master@{#428889}

[modify] https://crrev.com/936bf933e5b57ed08bc8ff211233a21783260615/gpu/command_buffer/client/gles2_implementation.cc
[modify] https://crrev.com/936bf933e5b57ed08bc8ff211233a21783260615/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/936bf933e5b57ed08bc8ff211233a21783260615/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/936bf933e5b57ed08bc8ff211233a21783260615/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
[modify] https://crrev.com/936bf933e5b57ed08bc8ff211233a21783260615/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
[modify] https://crrev.com/936bf933e5b57ed08bc8ff211233a21783260615/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.h

Comment 8 by zmo@chromium.org, Nov 5 2016

Owner: kbr@chromium.org
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2658d763101ffadcdff084dbcb239643192bf3b4

commit 2658d763101ffadcdff084dbcb239643192bf3b4
Author: kbr <kbr@chromium.org>
Date: Tue Nov 08 23:38:39 2016

Implement tex{Sub}Image3D taking sub-rectangles of HTMLImageElements.

Tested with new tests in
https://github.com/KhronosGroup/WebGL/pull/2132 .

Also includes the following needed WebGL conformance roll:

Roll WebGL 7516ab7..bc2b06d

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/7516ab7..bc2b06d

BUG= 639145 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2482793005
Cr-Commit-Position: refs/heads/master@{#430762}

[modify] https://crrev.com/2658d763101ffadcdff084dbcb239643192bf3b4/DEPS
[modify] https://crrev.com/2658d763101ffadcdff084dbcb239643192bf3b4/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/2658d763101ffadcdff084dbcb239643192bf3b4/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
[modify] https://crrev.com/2658d763101ffadcdff084dbcb239643192bf3b4/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl
[modify] https://crrev.com/2658d763101ffadcdff084dbcb239643192bf3b4/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/2658d763101ffadcdff084dbcb239643192bf3b4/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Comment 11 by kbr@chromium.org, Nov 11 2016

Blockedon: 664643

Comment 12 by kbr@chromium.org, Nov 11 2016

Labels: -Pri-2 ReleaseBlock-Stable M-56 Pri-1
This has to be completed before the M56 branch point in order for the WebGL 2.0 implementation to be complete.

Comment 13 by kbr@chromium.org, Nov 11 2016

Status: Started (was: Assigned)
Project Member

Comment 14 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fb2402f7eceb583b8f0ee1c86ffc1ce1735c897

commit 7fb2402f7eceb583b8f0ee1c86ffc1ce1735c897
Author: kainino <kainino@chromium.org>
Date: Tue Nov 15 03:38:15 2016

Roll WebGL bc2b06d..0028875

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/bc2b06d..0028875

BUG= 639145 

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2503593002
Cr-Commit-Position: refs/heads/master@{#432075}

[modify] https://crrev.com/7fb2402f7eceb583b8f0ee1c86ffc1ce1735c897/DEPS
[modify] https://crrev.com/7fb2402f7eceb583b8f0ee1c86ffc1ce1735c897/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 16 by kbr@chromium.org, Nov 16 2016

Blocking: 665656
Project Member

Comment 17 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e424d23a8af27dd4a30f8812bcbf05d4f1980aea

commit e424d23a8af27dd4a30f8812bcbf05d4f1980aea
Author: kbr <kbr@chromium.org>
Date: Wed Nov 16 06:33:41 2016

Support uploads of sub-rectangles of canvases to 2D and 3D textures.

Includes the following needed WebGL conformance roll:

Roll WebGL 130f5c1..7ff1300

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/130f5c1..7ff1300

BUG= 639145 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2495953002
Cr-Commit-Position: refs/heads/master@{#432396}

[modify] https://crrev.com/e424d23a8af27dd4a30f8812bcbf05d4f1980aea/DEPS
[modify] https://crrev.com/e424d23a8af27dd4a30f8812bcbf05d4f1980aea/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/e424d23a8af27dd4a30f8812bcbf05d4f1980aea/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/e424d23a8af27dd4a30f8812bcbf05d4f1980aea/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
[modify] https://crrev.com/e424d23a8af27dd4a30f8812bcbf05d4f1980aea/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl
[modify] https://crrev.com/e424d23a8af27dd4a30f8812bcbf05d4f1980aea/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/e424d23a8af27dd4a30f8812bcbf05d4f1980aea/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
[modify] https://crrev.com/e424d23a8af27dd4a30f8812bcbf05d4f1980aea/third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp
[modify] https://crrev.com/e424d23a8af27dd4a30f8812bcbf05d4f1980aea/third_party/WebKit/Source/platform/graphics/ImageBuffer.h
[modify] https://crrev.com/e424d23a8af27dd4a30f8812bcbf05d4f1980aea/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/e424d23a8af27dd4a30f8812bcbf05d4f1980aea/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d481a01bc050798a91512bdad6a70fccf0cb27a3

commit d481a01bc050798a91512bdad6a70fccf0cb27a3
Author: kbr <kbr@chromium.org>
Date: Fri Nov 18 03:52:48 2016

Fix semantics of uploading HTML sources to 3D textures.

The earlier code misinterpreted the spec as using the UNPACK_IMAGE_HEIGHT
pixel storage parameter to slice the image's sub-rectangle into multiple
layers of a 3D texture.

The new semantics, which Firefox implements, walk the image sub-rectangle
"depth" times through the source image, striding by UNPACK_IMAGE_HEIGHT
rows each time -- this parameter defaulting to the height of the 3D
texture.

Tested with all conformance2/textures/ tests in
https://github.com/KhronosGroup/WebGL/pull/2158 .

Incorporates needed WebGL conformance roll:

Roll WebGL b1a7540..453428f

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/b1a7540..453428f

BUG= 639145 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2511153002
Cr-Commit-Position: refs/heads/master@{#433079}

[modify] https://crrev.com/d481a01bc050798a91512bdad6a70fccf0cb27a3/DEPS
[modify] https://crrev.com/d481a01bc050798a91512bdad6a70fccf0cb27a3/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/d481a01bc050798a91512bdad6a70fccf0cb27a3/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
[modify] https://crrev.com/d481a01bc050798a91512bdad6a70fccf0cb27a3/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
[modify] https://crrev.com/d481a01bc050798a91512bdad6a70fccf0cb27a3/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.h

Comment 21 by zmo@chromium.org, Nov 18 2016

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-56; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-56 label, otherwise remove Merge-TBD label. Thanks.

Comment 23 by kbr@chromium.org, Nov 21 2016

Labels: -Merge-TBD Merge-Request-56
Yup, this needs to be merged. Requesting merge.

Comment 24 by dimu@chromium.org, Nov 21 2016

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
[Automated comment] DEPS changes referenced in bugdroid comments, needs manual review.

Comment 25 by kbr@chromium.org, Nov 21 2016

To be sure, the only CL for which merging is needed (in order to pass the WebGL 2.0 conformance tests) is:

https://chromium.googlesource.com/chromium/src/+/d481a01bc050798a91512bdad6a70fccf0cb27a3

Thanks.

Labels: -Merge-Review-56 Merge-Approved-56
Merge approved for M56 branch 2924.
Project Member

Comment 27 by bugdroid1@chromium.org, Nov 23 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3fa4ac854ab92ab1f7904d1ea08d4abfaf1abca8

commit 3fa4ac854ab92ab1f7904d1ea08d4abfaf1abca8
Author: Kenneth Russell <kbr@chromium.org>
Date: Wed Nov 23 01:17:22 2016

Fix semantics of uploading HTML sources to 3D textures.

The earlier code misinterpreted the spec as using the UNPACK_IMAGE_HEIGHT
pixel storage parameter to slice the image's sub-rectangle into multiple
layers of a 3D texture.

The new semantics, which Firefox implements, walk the image sub-rectangle
"depth" times through the source image, striding by UNPACK_IMAGE_HEIGHT
rows each time -- this parameter defaulting to the height of the 3D
texture.

Tested with all conformance2/textures/ tests in
https://github.com/KhronosGroup/WebGL/pull/2158 .

(Removes WebGL conformance roll that was included on master branch)

BUG= 639145 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2511153002
Cr-Commit-Position: refs/heads/master@{#433079}
(cherry picked from commit d481a01bc050798a91512bdad6a70fccf0cb27a3)

Review URL: https://codereview.chromium.org/2520043004 .

Cr-Commit-Position: refs/branch-heads/2924@{#71}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/3fa4ac854ab92ab1f7904d1ea08d4abfaf1abca8/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/3fa4ac854ab92ab1f7904d1ea08d4abfaf1abca8/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h
[modify] https://crrev.com/3fa4ac854ab92ab1f7904d1ea08d4abfaf1abca8/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
[modify] https://crrev.com/3fa4ac854ab92ab1f7904d1ea08d4abfaf1abca8/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.h

Project Member

Comment 28 by sheriffbot@chromium.org, Dec 16 2016

Labels: Merge-Review-56
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 29 by sheriffbot@chromium.org, Dec 16 2016

This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 30 by dimu@google.com, Dec 17 2016

Labels: -Merge-Review-56 -Hotlist-Merge-Review
[Automated comment] removing mislabelled Merge-Review-56, Hotlist-Merge-Review

Sign in to add a comment