New issue
Advanced search Search tips

Issue 639133 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner: ----
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Team-Security-UX


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

Security state icon alignment and sizing on Android

Project Member Reported by f...@chromium.org, Aug 18 2016

Issue description

From maxwalker: 
"there are still some issues around alignment, spacing and icon size. When testing on a Nexus 6P I noticed that the URL is too far on the left and the icon isn't centered within its bounding box. On the Pixel C the spacing and alignment are correct, however the icon seems to be too big."

Splitting this out from https://bugs.chromium.org/p/chromium/issues/detail?id=626646.
 
Nexus 6P.png
403 KB View Download
Pixel C.png
331 KB View Download
Labels: ConnectionInfo
Components: UI>Browser>Omnibox>SecurityIndicators
Components: -Security>UX
Labels: -Hotlist-SecurityIndicators

Comment 4 by f...@chromium.org, Nov 25 2016

Owner: lgar...@chromium.org

Comment 5 by raymes@chromium.org, Nov 30 2016

Components: UI>Browser>Permissions>Indicators
Labels: -ConnectionInfo
Cc: tedc...@chromium.org
I just realized this is still an issue, especially on Pixel C.

tedchoc, do you know why the tablet layout appears to use a different layout for the omnibox?
> tedchoc, do you know why the tablet layout appears to use a different layout for the omnibox?

To be clear: I'm aware that we do things differently for the tablet form factor. But I'm wondering why the security indicator icon doesn't automatically show up in the same place relative to the text.
the padding for all of this is likely from the material redesign of chrome for android, which is like 3ish years ago.  If the designers think it should be updated, then I don't think there is any reason stopping us (probably new designers think differently than designers at the time it was originally decided upon).

The main thing to consider is that we show icons in the omnibox dropdown on tablets, so the spacing between the security indicator and text is the same used for suggestions.  I wouldn't be surprised if that was a motivating factor on increasing the spacing compared to phones (and tablets have more space to begin with so it might be that phones were more compressed to give more room to the url)
Labels: -Pri-1 Pri-3
Labels: Hotlist-GoodFirstBug
Labels: Hotlist-EnamelAndFriendsFixIt
Owner: ----
Status: Available (was: Assigned)
maxwalker could you confirm if this is still an issue please?
I just checked. It looks good on both phones and tablets now. Please feel free to close the issue.
Status: WontFix (was: Available)
No longer applicable, so closing this out.

Sign in to add a comment