Issue metadata
Sign in to add a comment
|
"BrowserActionInteractiveTest.BrowserClickClosesPopup2" is flaky |
||||||||||||||||||||||||
Issue description"BrowserActionInteractiveTest.BrowserClickClosesPopup2" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyQAsSBUZsYWtlIjVCcm93c2VyQWN0aW9uSW50ZXJhY3RpdmVUZXN0LkJyb3dzZXJDbGlja0Nsb3Nlc1BvcHVwMgw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Aug 19 2016
jonross@, there's been a lot of these flakes cropping up in the last few days... are they all related to your patch? If so, should we consider reverting?
,
Aug 19 2016
I just made a CL to disable the test in the meantime: https://codereview.chromium.org/2260883002/ Feel free to cancel that if the underlying issue is getting addressed.
,
Aug 19 2016
This seems like an unrelated failure. BrowserActionInteractiveTest is reporting: [940:2420:0819/060607:ERROR:singleton_hwnd.cc(34)] Cannot create windows on non-UI thread! However in each failing trybot a series of tabdragging tests are also failing for the same reason, and they were not updated in the app_menu change. I wouldn't consider a revert right now, as the app_menu change fixed some bookmarks drag/drop crashes. I'd prefer to have that in while addressing the race conditions in the interactive_ui_tests
,
Aug 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/99a22a513d6909a1d6c835b50397b7422698883a commit 99a22a513d6909a1d6c835b50397b7422698883a Author: treib <treib@chromium.org> Date: Fri Aug 19 18:15:13 2016 Disable flaky BrowserActionInteractiveTest.BrowserClickClosesPopup2 on Win BUG= 639130 TBR=rdevlin.cronin@chromium.org Review-Url: https://codereview.chromium.org/2260883002 Cr-Commit-Position: refs/heads/master@{#413188} [modify] https://crrev.com/99a22a513d6909a1d6c835b50397b7422698883a/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc
,
Aug 19 2016
Note that this likely has the same cause as issue 639350 , which lists a bunch more flaky tests.
,
Aug 19 2016
Merging this into issue 639350 which is tracking all the falling tests
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f25dd42daf3cf68126cab769ff445922867bfb54 commit f25dd42daf3cf68126cab769ff445922867bfb54 Author: Greg Thompson <grt@chromium.org> Date: Mon Nov 27 09:14:48 2017 Enable interactive_ui_tests on Windows that now run mostly reliably. r516772 was the last of many commits that resolved a number of problems that made this test suite flaky on Windows. This CL enables tests that had been disabled over time due to flakes, yet now seem to run okay. BUG=515717, 639130 , 764415 This CL was uploaded by git cl split. R=jyasskin@chromium.org Change-Id: I76dc53552364b7f12fb2890663c3e680461b6b7e Reviewed-on: https://chromium-review.googlesource.com/784938 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#519249} [modify] https://crrev.com/f25dd42daf3cf68126cab769ff445922867bfb54/chrome/browser/extensions/api/extension_action/browser_action_interactive_test.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by treib@chromium.org
, Aug 19 2016