New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 639111 link

Starred by 2 users
Status: WontFix
Owner:
dcasta...@chromium.org
Closed: Jan 14
Cc:
dnicoara@chromium.org
█ kalyan.kondapally@chromium.org
█ reve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Switch primary plane format from RGB to BGR on ChromeOS.

Project Member Reported by dcasta...@chromium.org, Aug 18 2016 
The current format used by chrome on chromeos for the output surface is gfx::BufferFormat::BGRX_8888.

Buffers coming from Android via Wayland are DRM_FORMAT_XBGR8888 (gfx::BufferFormat::RGBX_8888).

In order to avoid GL compositing when those buffers could be used directly with drmModePageFlip we'd like to switch the format to gfx::BufferFormat::RGBX_8888 to match the Android buffers.

This is necessary since on many devices it's not possible to switch to a different format when drmModePageFlip is called.


NOTE:
In https://codereview.chromium.org/2254103002/ we allow ozone to set framebuffers with different formats since we know that works on certain arm devices. That hack should go away once we address this issue.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/minigbm/+/ac50d6472ce952a73b14066e0233d8b086c53fac

commit ac50d6472ce952a73b14066e0233d8b086c53fac
Author: Daniele Castagna <dcastagna@chromium.org>
Date: Fri Aug 05 22:50:34 2016

Add XBGR8888 to rockchip supported formats.

BUG= chromium:639111 ,b:29430506
TEST=Tested on minnie after changing chrome primary buffer format to XBGR

Change-Id: I2d1ba8711e9f15efa0d728948dba58c18ef5b918
Reviewed-on: https://chromium-review.googlesource.com/366900
Commit-Ready: Daniele Castagna <dcastagna@chromium.org>
Tested-by: Stéphane Marchesin <marcheu@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Stéphane Marchesin <marcheu@chromium.org>

[modify] https://crrev.com/ac50d6472ce952a73b14066e0233d8b086c53fac/rockchip.c

Comment 2 by benhenry@google.com, Jan 11 

You started fixing this bug over two years ago. Are you still working on it?

Comment 3 by dcastagna@google.com, Jan 14

Status: WontFix (was: Started)
We can dynamically flip from RGB to BGR on platforms where we use drm atomic, so switching the primary format to match android format for the benefit described in this bug is not useful anymore.
►

Sign in to add a comment